Re: Working divert socket example prog?

2016-04-28 Thread lpa lpa
On Thu, Apr 28, 2016 at 4:06 PM, Nikolay Denev wrote: > Hi, > > Have you looked at the natd(8) source code? > yes but it's a complete application, it does a lot of stuff and I am not able to "clean" it up to become a simple divert application which reinjects packet so I can measure something. I

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com updated the summary for this revision. REVISION DETAIL https://reviews.freebsd.org/D6120 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, adrian, rwatson, gnn, lstewart, glebius, delphij, mike-karels.net, jtl, networ

[Differential] D6137: tcp/lro: Refactor the free/active list operation.

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com updated this revision to Diff 15725. sepherosa_gmail.com added a comment. Skip the free list operation, which may introduce extra cmp on hot code path CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D6137?vs=15684&id=15725 REVISION DETAIL https://reviews.freebsd.

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5872#130813, @lstewart wrote: > In https://reviews.freebsd.org/D5872#130806, @sepherosa_gmail.com wrote: > > > In https://reviews.freebsd.org/D5872#130805, @lstewart wrote: > > > > > In https://reviews.freebsd.org

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-28 Thread lstewart (Lawrence Stewart)
lstewart added a comment. In https://reviews.freebsd.org/D5872#130806, @sepherosa_gmail.com wrote: > In https://reviews.freebsd.org/D5872#130805, @lstewart wrote: > > > In https://reviews.freebsd.org/D5872#130179, @sepherosa_gmail.com wrote: > > > > > We probably can leave the cwnd

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D5872#130805, @lstewart wrote: > In https://reviews.freebsd.org/D5872#130179, @sepherosa_gmail.com wrote: > > > We probably can leave the cwnd resetting to later rexmt timeout or possible later fast retransmit (I thin

[Differential] D5872: tcp: Don't prematurely drop receiving-only connections

2016-04-28 Thread lstewart (Lawrence Stewart)
lstewart added a comment. In https://reviews.freebsd.org/D5872#130179, @sepherosa_gmail.com wrote: > We probably can leave the cwnd resetting to later rexmt timeout or possible later fast retransmit (I think fast retransmit could kick in under some cases, if ENOBUFS happened); instead of

[Differential] D6137: tcp/lro: Refactor the free/active list operation.

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D6137#130603, @gallatin wrote: > The tcp_lro_entry_get() abstraction adds an extra compare to the critical path (the compare against NULL in the function itself, in addition to the same compare in the main routine). At

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added inline comments. INLINE COMMENTS sys/netinet/tcp_syncache.c:1507 OK, but as a different commit. REVISION DETAIL https://reviews.freebsd.org/D6120 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, adrian, rwats

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-28 Thread sepherosa_gmail.com (Sepherosa Ziehau)
sepherosa_gmail.com added a comment. In https://reviews.freebsd.org/D6120#130786, @hiren wrote: > I hope you'd write a bit more descriptive commit-log (not just 'what' but also 'why') for the change. Thanks a lot for your work! OK :) REVISION DETAIL https://reviews.freebsd.org/

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-28 Thread hiren (hiren panchasara)
hiren accepted this revision. hiren added a comment. This revision has a positive review. I hope you'd write a bit more descriptive commit-log (not just 'what' but also 'why') for the change. Thanks a lot for your work! Cheers, Hiren INLINE COMMENTS sys/netinet/tcp_syncache.c:1507 Do

Re: netmap overrun counters

2016-04-28 Thread bazzoola
Thanks Adrian, and thanks Luigi for the explanation: On 04/28/2016 01:15 PM, Luigi Rizzo wrote: > > please re-read the relevant part of the manual page: > >RECEIVE RINGS > On receive rings, after a netmap system call, the slots in the range > head... tail-1 contain received packets

Re: netmap overrun counters

2016-04-28 Thread Luigi Rizzo
On Thu, Apr 28, 2016 at 9:15 PM, bazzoola wrote: > > > On 04/28/2016 12:06 PM, Luigi Rizzo wrote: > > > > > > On Thursday, April 28, 2016, bazzoola > > wrote: > > > > > > > > On 04/28/2016 11:35 AM, Navdeep Parhar wrote: > > > On 04/28/2016 11:13, bazzoola wrot

Re: netmap overrun counters

2016-04-28 Thread Adrian Chadd
It doesn't overwrite unread slots; it just hits the end and stops RX'ing (and is counted by the NIC as an RX overflow) until you've RX'ed some frames and told netmap what you've handed. -adrian ___ freebsd-net@freebsd.org mailing list https://lists.free

Re: netmap overrun counters

2016-04-28 Thread bazzoola
On 04/28/2016 12:06 PM, Luigi Rizzo wrote: > > > On Thursday, April 28, 2016, bazzoola > wrote: > > > > On 04/28/2016 11:35 AM, Navdeep Parhar wrote: > > On 04/28/2016 11:13, bazzoola wrote: > >> Hi! > >> > >> Two questions: > >> > >> (

Re: netmap overrun counters

2016-04-28 Thread Luigi Rizzo
On Thursday, April 28, 2016, bazzoola wrote: > > > On 04/28/2016 11:35 AM, Navdeep Parhar wrote: > > On 04/28/2016 11:13, bazzoola wrote: > >> Hi! > >> > >> Two questions: > >> > >> (1) Is there a way to know when netmap rx rings overrun? Most NIC > >> drivers provide MPC (missed packet count) an

Re: Working divert socket example prog?

2016-04-28 Thread Nikolay Denev
Hi, Have you looked at the natd(8) source code? --Nikolay On Thu, Apr 28, 2016 at 7:21 AM, lpa lpa wrote: > Do anyone have a working example code of a divert loop program? > > I tried building this one[1] but it seems to be for FreeBSD 5 and won't > build on latest system. I want to make simpl

Re: netmap overrun counters

2016-04-28 Thread bazzoola
On 04/28/2016 11:35 AM, Navdeep Parhar wrote: > On 04/28/2016 11:13, bazzoola wrote: >> Hi! >> >> Two questions: >> >> (1) Is there a way to know when netmap rx rings overrun? Most NIC >> drivers provide MPC (missed packet count) and sysctl for rx_overrun. >> >> I would like to know if my applica

Re: netmap overrun counters

2016-04-28 Thread Navdeep Parhar
On 04/28/2016 11:13, bazzoola wrote: > Hi! > > Two questions: > > (1) Is there a way to know when netmap rx rings overrun? Most NIC > drivers provide MPC (missed packet count) and sysctl for rx_overrun. > > I would like to know if my application is not reading as fast, i.e., no > frames are bein

netmap overrun counters

2016-04-28 Thread bazzoola
Hi! Two questions: (1) Is there a way to know when netmap rx rings overrun? Most NIC drivers provide MPC (missed packet count) and sysctl for rx_overrun. I would like to know if my application is not reading as fast, i.e., no frames are being dropped. (2) What is the benefit of NETMAP_DO_RX_POL

[Differential] D6137: tcp/lro: Refactor the free/active list operation.

2016-04-28 Thread rrs (Randall Stewart)
rrs added a comment. It would be worth checking the assembly output.. if it truly inlines it then it should probably only do one compare.. but worth checking... REVISION DETAIL https://reviews.freebsd.org/D6137 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreference

Rayban Sunglasses : Buy Now!Don't Miss Out ! Save Price 83% OFF! Cheap buy! buy! buy!Latest styles

2016-04-28 Thread Rayban
Having trouble reading this email? View it in your browser. Not interested anymore? Unsubscribe instantly. HOME SUNGLASSES EYEGLASSES CUSTOMIZE CONTACT US LOGIN WELCOME TO RAYBAN OUTLET STORE! RAYBAN STORE EVERYTHING UP TO 82%OFF SHOP NOW BUY MORE SAVE MORE Our promises: - Free deli

[Differential] D6137: tcp/lro: Refactor the free/active list operation.

2016-04-28 Thread gallatin (Andrew Gallatin)
gallatin added a comment. The tcp_lro_entry_get() abstraction adds an extra compare to the critical path (the compare against NULL in the function itself, in addition to the same compare in the main routine). At least it does at the C level. Have you verified that the compiler is smart en