[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread smh (Steven Hartland)
smh accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D9847 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, tsoome, glebius, freebsd-net-list, #network, gnn, bapt, oshogbo, smh Cc: smh

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-03-03 Thread ale (Alex Dupre)
ale added a comment. Thanks for your comment, I'll improve the man page. INLINE COMMENTS > wblock wrote in ng_pppoe.4:108 > "host uniq" should be capitalized or otherwise identified with markup. Since > it's used below, just be consistent and say `Host-Uniq`. Are you fine with lower case

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-03-03 Thread wblock (Warren Block)
wblock added inline comments. INLINE COMMENTS > ng_pppoe.4:108 > +It is possible to request a connection to a specific access concentrator, > +and/or set a specific host uniq tag, required by some Internet providers, > +using the "[AC-Name\\][Host-Uniq|]Service-Name" syntax. "host uniq" should

[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread kczekirda (Kamil Czekirda)
kczekirda updated this revision to Diff 25936. kczekirda marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25931=25936 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c

[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread smh (Steven Hartland)
smh requested changes to this revision. smh added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pxe.c:296 > + > + if (dhcp_try_rfc1048(bootplayer.vendor.d, > BOOTP_DHCPVEND) < 0 ) { > + if (pxe_debug) space

GSSAPI and racoon

2017-03-03 Thread Victor Sudakov
Dear Colleagues, Is anyone running GSSAPI+IKE (racoon)? I have a Heimdal realm with a dozen FreeBSD hosts in it. I use GSSAPI for ssh access, also for CVS and SVN authentication. So I thought it would be a good idea to use Kerberos for IPSec as well, but the documentation is scarce, in fact

[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread bapt (Baptiste Daroussin)
bapt accepted this revision. REVISION DETAIL https://reviews.freebsd.org/D9847 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, tsoome, glebius, freebsd-net-list, #network, gnn, smh, oshogbo, bapt Cc: smh

[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread oshogbo (Mariusz Zaborski)
oshogbo added a comment. @smh Is it work for you know? I have one more patch from @kczekirda so is it ready for commit? REVISION DETAIL https://reviews.freebsd.org/D9847 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: kczekirda, bapt, tsoome,

[Differential] D9847: Try to extract the RFC1048 data from PXE

2017-03-03 Thread kczekirda (Kamil Czekirda)
kczekirda updated this revision to Diff 25931. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D9847?vs=25917=25931 REVISION DETAIL https://reviews.freebsd.org/D9847 AFFECTED FILES /usr/src/lib/libstand/bootp.c /usr/src/lib/libstand/bootp.h /usr/src/sys/boot/i386/libi386/pxe.c