i386 LINT-NOIP kernel fails to compile due to lio

2022-02-08 Thread Ryan Stone
Hi everyone, I got the following error on a make tinderbox. It only affects i386 for whatever reason; I haven't debug into why: linking kernel ld: warning: common OPENSSL_ia32cap_P is overridden ld: warning: common OPENSSL_ia32cap_P is overridden ld: warning: common OPENSSL_ia32cap_P is overridd

Re: Chelsio cards, jumbo frames, memory fragmentation and performance in FreeBSD 13.x?

2021-12-03 Thread Ryan Stone
Set it to 4k and move on. I'm not aware of any efforts in the VM layer or network stack to make >PAGE_SIZE clusters usable in practical situations. Honestly, at this point I wish that we'd just kill them entirely. On Fri, Dec 3, 2021 at 12:52 PM John Jasen wrote: > > Pretty close to two years a

Re: Bug in MAC filter on IGB/if_vlan?

2021-11-09 Thread Ryan Stone
You're trying to use different MACs with each vlan. I don't believe that this is really a support configuration in our stack, although putting the interface into promiscuous I guess works.

rip6_output not in net epoch across call to ip6_setpktopts()

2021-05-18 Thread Ryan Stone
Recently at work we saw a panic in ip6_setpktopt() while it's using an ifnet returned by ifnet_byindex, here: https://cgit.freebsd.org/src/tree/sys/netinet6/ip6_output.c#n2969 The issue seems to be that rip6_output() calls into ip6_setpktopts() outside of the net epoch. Should I just wrap the se

Re: ifaddr reference count leaks that seem to be related to routing code

2021-02-12 Thread Ryan Stone
On Fri, Feb 12, 2021 at 4:14 PM Alexander V. Chernikov wrote: > The slightly different approach here: https://reviews.freebsd.org/D28629 > We indeed are running under epoch, so that prevents _immediate_ ifa > destruction. > However, we still can run into the situation when > * in thread 1 we drop

Re: ifaddr reference count leaks that seem to be related to routing code

2021-02-12 Thread Ryan Stone
Thanks! For reference, I tried this patch and it did resolve my leak: https://github.com/rysto32/freebsd/commit/73caa71c351c072d673d477972fda2aeb369eb3d I haven't exhaustively tested the routing code, though, so I can't say for certain that the assert will always be true, nor am I certain that n

ifaddr reference count leaks that seem to be related to routing code

2021-02-12 Thread Ryan Stone
On main I'm seeing leaks of ifaddr reference counts. I can reproduce this in a bhyve VM by repeating this: vlan=`ifconfig vlan create vlandev vtnet0 vlan 777` ifconfig $vlan up ifconfig $vlan 1.0.0.1/24 ifconfig $vlan destroy If I watch the ifaddr column of vmstat -m

Re: iflib tx watchdog doesn't appear that it can work anymore

2020-12-10 Thread Ryan Stone
So what's the plan with the iflib watchdog? If it's not going to be fixed, should it just be removed entirely? I don't think that's a great idea but I remember that the Intel watchdogs got a lot of rototilling to try and get them right so I'm nervous about going in and just trying to reimplement

Re: iflib tx watchdog doesn't appear that it can work anymore

2020-11-10 Thread Ryan Stone
ric Joyner wrote: > > I'll add Piotr, the author of your linked patch, to this thread. > > Are you seeing a problem connected to the watchdog? Piotr tells me that > IFLIB_QUEUE_WORKING isn't used now, but it wasn't even used before his patch. > > - Eric > &

iflib tx watchdog doesn't appear that it can work anymore

2020-11-04 Thread Ryan Stone
https://svnweb.freebsd.org/base?view=revision&revision=356310 As of r356310, there does not appear to be a way that ift_qstatus can be set to anything but IFLIB_QUEUE_IDLE. As a result, I don't see that there is any way for the watchdog to ever fire. I think that iflib has missed setting ift_qst

Panic in in6_joingroup_locked

2020-10-21 Thread Ryan Stone
Today at $WORK we saw a panic due to a race between in6_joingroup_locked and if_detach_internal. This happened on a branch that's about 2 years behind head, but the relevant code in head does not appear to have changed. The backtrace of the panic was this: panic: Fatal trap 9: general protection

Re: safe_pause_us() is always at least 1 millisecond long

2020-10-21 Thread Ryan Stone
Using min is definitely not correct. That would ensure that you either got a pause of 1 tick or 0 ticks. This may get you better granularity, depending on the system. pause_sbt("e1000_delay", x * SBT_1US, x < 1000 ? 100 * SBT_1US : SBT_1MS, 0); ___ fre

Re: Socket option to configure Ethernet PCP / CoS per-flow

2020-09-24 Thread Ryan Stone
On Fri, Sep 11, 2020 at 12:33 PM Scheffenegger, Richard wrote: > > Hi, > > Currently, upstream head has only an IOCTL API to set up interface-wide > default PCP marking: > > #define SIOCGVLANPCPSIOCGLANPCP /* Get VLAN PCP */ > #define SIOCSVLANPCPSIOCSLANPCP /* Set VLAN PCP */

Re: Is anybody using ng_pipe?

2020-08-18 Thread Ryan Stone
On Tue, Aug 18, 2020 at 5:43 PM Marko Zec wrote: > Since in ng_pipe we define BER as an one error in BER bits (integer > value), wouldn't your formula P = 1 - BER yield results less than or > equal to zero for all non-zero values of BER? The domain of P is > [0..1], so that won't fly. > > Your an

Re: Is anybody using ng_pipe?

2020-08-18 Thread Ryan Stone
On Tue, Aug 18, 2020 at 2:43 PM Eugene Grosbein wrote: > Sorry, missed that. But why wasn't possible? There's a daemon running on the system that handles most network configuration. It's quite inflexible and will override any manual configuration changes. It manages firewall rules but is ignora

Re: Is anybody using ng_pipe?

2020-08-18 Thread Ryan Stone
On Tue, Aug 18, 2020 at 1:17 PM Ryan Stone wrote: > 4. The table calculation had two integer truncation bugs and used the > wrong formula. I'm reasonably sure it would never calculate a > probability other than 0 due a 64-bit constant being truncated to > 32-bits. I've

Is anybody using ng_pipe?

2020-08-18 Thread Ryan Stone
I recently needed to be able to simulate a lossy, high-latency network in an environment where dummynet wasn't possible. I gave ng_pipe a try, and hit some major issues 1. Instead of configuring a packet drop rate, you configure a bit error rate, which I found significantly less intuitive 2. The

ndp -P => panic: prefix 0xfffff80011c56700 has referencing addresses

2020-06-12 Thread Ryan Stone
# ifconfig vtnet0 inet6 1::1 # ndp -P panic: prefix 0xf80011c56700 has referencing addresses cpuid = 1 time = 1591991817 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe0022d08720 vpanic() at vpanic+0x19d/frame 0xfe0022d08770 panic() at panic+0x43/f

Re: Can net.iflib.min_tx_latency=0 introduce an unbounded amount of latency?

2020-03-24 Thread Ryan Stone
Thanks for the analysis. I haven't had much of an opportunity to get into the guts of iflib and I'm not very successful at following the round trips through mpring yet. On Mon, Mar 23, 2020 at 12:50 AM Patrick Kelsey wrote: > > > > On Sun, Mar 22, 2020 at 2:31 PM Ryan St

Can net.iflib.min_tx_latency=0 introduce an unbounded amount of latency?

2020-03-22 Thread Ryan Stone
I've been tracking down a bug at work that appears to be due to excessive latency introduced on the TX side of a TCP connection. In looking through the iflib code, I noticed the tunable net.iflib.min_tx_latency. My reading of the iflib code is that if a packet is enqueued to a tx ring but not pos

Re: IPv6: Invalid nd6 entry created for an RA without an lladdr

2019-10-02 Thread Ryan Stone
> At Wed, 2 Oct 2019 17:04:23 -0400, > Ryan Stone wrote: > > > > At work, our product is putting through an IPv6 conformance test and > > it's found an issue in our handling of Routing Advertisements (RAs). > > If we receive an RA that does not specify an llad

IPv6: Invalid nd6 entry created for an RA without an lladdr

2019-10-02 Thread Ryan Stone
At work, our product is putting through an IPv6 conformance test and it's found an issue in our handling of Routing Advertisements (RAs). If we receive an RA that does not specify an lladdr, then nd6_cache_lladdr() is called with lladdr NULL: https://svnweb.freebsd.org/base/head/sys/netinet6/nd6.c

Re: BBR patches?

2019-09-10 Thread Ryan Stone
rrs@ has just posted the BBR patch to phabricator: https://reviews.freebsd.org/D21582 ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Re: udp_notify() invalidates the routing cache without a write lock

2018-09-21 Thread Ryan Stone
I have put a CR up on phab for this: https://reviews.freebsd.org/D17246 ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Fwd: Status of 10.4 fixes for CVE-2018-6923 (Fragment Stack)

2018-09-18 Thread Ryan Stone
I didn't get a response to this, so I'm forwarding to a higher-traffic list. Does anybody know if there is work in progress on a for for stable/10? -- Forwarded message ----- From: Ryan Stone Date: Tue, Sep 11, 2018 at 2:37 PM Subject: Status of 10.4 fixes for CVE

udp_notify() invalidates the routing cache without a write lock

2018-09-10 Thread Ryan Stone
Recently at work I had a system crash while executing RTFREE() in udp_notify(). In looking at the system I discovered that two threads had called udp_notify() on the same pcb. This was possible because the threads only held a read lock on the socket. The obvious solution is to hold a write lock

Re: Testing VF/PF code

2018-05-30 Thread Ryan Stone
On Tue, May 29, 2018 at 12:58 PM Sean Bruno wrote: > > Does anyone have a process for testing the VF drivers (ixgbe igb, etc) > in FreeBSD without actually firing up linux to instantiate a VM or using > EC2? We have native support for creating VFs for ixl and ixgbe (and cxgbe). For igb you're out

Re: mlx5(4) jumbo receive

2018-04-25 Thread Ryan Stone
On Tue, Apr 24, 2018 at 4:55 AM, Konstantin Belousov wrote: > +#ifndef MLX5E_MAX_RX_BYTES > +#defineMLX5E_MAX_RX_BYTES MCLBYTES > +#endif Why do you use a 2KB buffer rather than a PAGE_SIZE'd buffer? MJUMPAGESIZE should offer significantly better performance for jumbo frames without incre

Re: Cisco shows LACP not enabled on 11.1U2, BCM 57810S-t, 2960X IOS 15.2

2018-03-13 Thread Ryan Stone
Unfortunately, this is a known issue with the bxe driver. I was under the impression that QLogic had committed a fix to -head, but I just checked and it hasn't seen any updates from QLogic in over a year, unfortunately. ___ freebsd-net@freebsd.org mailin

[PATCH] Fix for IPv4 subnet route migration

2018-02-28 Thread Ryan Stone
Currently, the FreeBSD stack gets itself into a bizarre state if you try to change the source IP for a subnet route (yes, this implies using two IPs on the same subnet on a system. Yes, I'm aware this is a Bad Idea(TM). Unfortunately I have a customer that insists on this configuration) You can

Review: Fix regression that did not allow "route change" that didn't re-specify the gateway

2018-02-09 Thread Ryan Stone
A change a while back (r264986) broke the ability to change a route's parameters if the gateway wasn't explicitly specified again. For example, you used to be able to run "route change 10.0.0.0/8 -mtu 9000" to change the MTU without having to provide the gateway IP to the command. I have a review

3 ARP cache related reviews

2018-01-19 Thread Ryan Stone
I've opened 3 phabricator reviews fixing issues with the inpcb llentry caching. https://reviews.freebsd.org/D13988 This fix invalidates the llentry cache after the L3 route cache was invalidated by the routing table's generation count incrementing. Without this fix existing connections would cont

Allowing a local subnet route to change to a different ifnet

2018-01-17 Thread Ryan Stone
I'm going to prefix this question by noting that I realize that the configuration that I am about to describe is quite nonsensical. Unfortunately, it seems that under older versions of FreeBSD (possibly FreeBSD 7-vintage), the configuration mostly "worked", and now at $WORK I am responsible for mak

Re: [PATCH] ifaddr leak when modifying a route

2017-12-12 Thread Ryan Stone
On Thu, Dec 7, 2017 at 4:59 PM, Ryan Stone wrote: > https://reviews.freebsd.org/D13417 I still haven't received any feedback on this review. If nobody raises an objection by Thursday, I will commit it. ___ freebsd-net@freebsd.org mailing li

[PATCH] ifaddr leak when modifying a route

2017-12-07 Thread Ryan Stone
I've put this phab review up that patches an ifaddr refcount leak in the routing code. When a route is modified in a way that modifies rt->rt_ifa, in most cases we don't release the reference on the old one, which can cause it to leak. I have a simple script here that I wrote to demonstrate the i

Re: BPF packet pagesize limit

2017-11-21 Thread Ryan Stone
Do not allocate MJUM9BYTES clusters under any circumstances. Trying to allocate them when the system is under memory pressure is enormously expensive and stands a good chance of livelocking the system if you try to allocate too many too quickly, even when allocating with M_NOWAIT. Honestly, suppo

Re: Intel I210 (igb) sometimes consume all CPU on not-so-big traffic — need help!

2017-11-20 Thread Ryan Stone
Please try the following patch. It should resolve your issue: https://people.freebsd.org/~rstone/patches/e1000-9k.diff ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "free

Re: Should RO_RTFREE() also free the cached lle entry?

2017-10-17 Thread Ryan Stone
Ah, never mind. When I started to investigate this problem I was looking at an old tree. I tried to verify that it was still a problem on -head, but missed that r315956 fixed the problem in a different way than I was expecting. Sorry for the noise. ___

Should RO_RTFREE() also free the cached lle entry?

2017-10-17 Thread Ryan Stone
About a year back we brought back lle (the ARP/NDP entry) caching back into the network stack. As near as I can tell, the ethernet layer will take a reference on the lle and place a pointer to it in the ro_lle field in the struct route passed down from the upper layer. The upper layer is expected

Re: mbuf_jumbo_9k & iSCSI failing

2017-09-22 Thread Ryan Stone
Hans and I have proposed different approaches to the problem. I was taken off this issue at $WORK for a while, but coincidentally I just picked it up again in the last week or so. I'm working on evaluating the performance characteristics of the two approaches and once I'm satisfied with that I'll

Re: mbuf_jumbo_9k & iSCSI failing

2017-07-11 Thread Ryan Stone
I've just put up a review that fixes mlx4_en to no longer use clusters larger than PAGE_SIZE in its receive path. The patch is based off of the older version of the driver which did the same, but keeps all of the changes to the driver since then (including support for bus_dma). The review can be

Re: Question on SRIOV vf -> pf mapping

2017-07-10 Thread Ryan Stone
This isn't possible in general. When PCI Passthrough is in use, the VF driver will run in the context of the VM's kernel and there is no device_t corresponding to the PF at all. If you're looking to pass information from the PF down to the VF, then you need to establish some kind of device-mediat

Re: mbuf_jumbo_9k & iSCSI failing

2017-06-25 Thread Ryan Stone
Having looking at the original email more closely, I see that you showed an mlxen interface with a 9020 MTU. Seeing allocation failures of 9k mbuf clusters increase while you are far below the zone's limit means that you're definitely running into the bug I'm describing, and this bug could plausib

Re: mbuf_jumbo_9k & iSCSI failing

2017-06-25 Thread Ryan Stone
Is this setup using the mlx4_en driver? If so, recent versions of that driver has a regression when using MTUs greater than the page size (4096 on i386/amd64). The bug will cause the card to drop packets when the system is under memory pressure, and in certain causes the card can get into a state

Re: vmx bug?

2017-05-17 Thread Ryan Stone
On Wed, May 17, 2017 at 7:32 PM, Andrew Vylegzhanin wrote: > > vmx0@pci0:4:0:0: class=0x02 card=0x07b015ad chip=0x07b015ad rev=0x01 > hdr=0x00 > > vendor = 'VMware' > > device = 'VMXNET3 Ethernet Controller' > > class = network > > subclass = ethernet > > vmx1@p

Re: vmx bug?

2017-05-17 Thread Ryan Stone
The bug that you refer to does not appear to be related to your issue. What does "pciconf -l" print in your FreeBSD VM? ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "free

Re: Problems with FreeBSD (amd64 stable/11) router

2016-12-06 Thread Ryan Stone
n the vlan interface (assuming that the network that you are routing to can accept 1518 byte packets), or only advertise a 1496 byte MTU in your internal network. On Mon, Dec 5, 2016 at 2:10 PM, Chris Ross wrote: > > > On Dec 5, 2016, at 11:59, Ryan Stone wrote: > > > > What

Re: Problems with FreeBSD (amd64 stable/11) router

2016-12-05 Thread Ryan Stone
What's the MTU on the bce and vlan interfaces? Does the bce interface show VLAN_MTU option set (in ifconfig)? On Mon, Dec 5, 2016 at 10:00 AM, Chris Ross wrote: > > Hello all. I recently replaced my router with a FreeBSD/11 box > (stable/11 r308579). I am running a lagg device across two bce

Re: mutex usage in if_bridge vs other drivers

2016-12-02 Thread Ryan Stone
On Fri, Dec 2, 2016 at 3:42 PM, Chris Torek wrote: > THE QUESTION: > > - Who is wrong, the bxe driver or the bridge code? I.e., >does the bridge driver need to release its lock here, >and if so, is that actually safe to do? (We might need >to restart the loop over all the members if

[Differential] D8685: Fix a false positive in a buf_ring assert

2016-12-01 Thread rstone (Ryan Stone)
This revision was automatically updated to reflect the committed changes. rstone marked an inline comment as done. Closed by commit rS309372: Fix a false positive in a buf_ring assert (authored by rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D8685?vs=22633&id=22651#toc REPOSITO

[Differential] D8685: Fix a false positive in a buf_ring assert

2016-11-30 Thread rstone (Ryan Stone)
rstone marked an inline comment as done. rstone added inline comments. INLINE COMMENTS > hselasky wrote in buf_ring.h:71 > should "br->br_cons_head + 1" be masked by br->br_cons_mask ?? Absolutely correct. Nice catch, thank you REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL PREFERE

[Differential] D8685: Fix a false positive in a buf_ring assert

2016-11-30 Thread rstone (Ryan Stone)
rstone updated this revision to Diff 22633. rstone added a comment. Ensure we don't walk off the end of the ring CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D8685?vs=22631&id=22633 REVISION DETAIL https://reviews.freebsd.org/D8685 AFFECTED FILES sys/sys/buf_ring.h CHANGE DET

[Differential] D8685: Fix a false positive in a buf_ring assert

2016-11-30 Thread rstone (Ryan Stone)
rstone added a subscriber: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rstone Cc: freebsd-net-list, emaste ___ freebsd-net@freebsd.org mailin

Re: lagg Interfaces - don't do Gratuitous ARP?

2016-09-22 Thread Ryan Stone
On Thu, Sep 22, 2016 at 4:04 AM, Steven Hartland wrote: > The disappointing thing about this is we had a solution, all be it one not > everyone liked, nearly a year ago now and yet here we are still stuck with > a broken lagg implementation in the tree. > I would point out this 4-year-old thread

Re: lagg Interfaces - don't do Gratuitous ARP?

2016-09-21 Thread Ryan Stone
On Wed, Sep 21, 2016 at 7:57 PM, Gleb Smirnoff wrote: > IMHO, the original patch was absolutely evil hack touching multiple > layers, for the sake of a very special problem. > > I think, that in order to kick forwarding table on switches, lagg > should: > > - allocate an mbuf itself > - set its s

Re: How can I send packets to 255.255.255.255 from the command line?

2016-08-18 Thread Ryan Stone
On Thu, Aug 18, 2016 at 4:48 PM, Paul A. Procacci wrote: > You should be able to ping the local subnet. > Alternatively you can use net/arping. > > ~Paul > I'm specifically looking to test the handling of 255.255.255.255, so a local broadcast address is out. Unfortunately, arping doesn't seem t

How can I send packets to 255.255.255.255 from the command line?

2016-08-18 Thread Ryan Stone
I want to test a change to broadcast packet handling and I want to confirm that 255.255.255.255 is still handled correctly. Are there any command-line tools in FreeBSD that can send to the broadcast address? ping 255.255.255.255 does not work correctly, unfortunately. _

Re: Unstable local network throughput

2016-08-04 Thread Ryan Stone
On Thu, Aug 4, 2016 at 11:33 AM, Ben RUBSON wrote: > But even without RSS, I should be able to go up to 2x40Gbps, don't you > think so ? > Nobody already did this ? > Try this patch, which should improve performance when multiple TCP streams are running in parallel over an mlx4_en port: https:/

Re: Is netmap jumbo frames broken in STABLE?

2016-06-06 Thread Ryan Stone
The use of mbuf clusters larger than a single page really doesn't work. The problem is that over time physical memory becomes fragmented and eventually 9K of contiguous memory can't be allocated anymore. This is why many drivers now limit themselves to page-sized clusters. On Mon, Jun 6, 2016 at

Re: VLANs are broken in HEAD

2016-05-19 Thread Ryan Stone
r299512 introduced breakage into dhclient, which was fixed in r300174. That may be the source of the issue? ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsub

Re: Regression? VLAN packet drop after upgrading from r281235

2016-04-27 Thread Ryan Stone
From a quick look at the vlan code, I can identify a few cases that might cause that counter to increment: 1) Error from the underlying ixgbe device. Does "netstat -dI ix0" show that the driver has been dropping packets? 2) Link down events on the underlying NIC. I believe that link flaps will

Re: Persist ifconfig aliases after disconnect

2016-04-22 Thread Ryan Stone
When you say the "connection drops", do you mean that the NIC loses link and then has it comes back? Are you using DHCP to get the main address? It sounds like perhaps dhclient is running and clearing the addresses it doesn't know about. ___ freebsd-net@

Re: Outgoing packets being sent via wrong interface

2015-11-25 Thread Ryan Stone
An easier way to block ICMP redirects would be to set the sysctl: sysctl net.inet.icmp.drop_redirect=1 ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr.

Re: Intel XL710 broken link down detection?

2015-11-11 Thread Ryan Stone
On Wed, Nov 11, 2015 at 11:18 AM, Steven Hartland wrote: > Comparing this to the Linux driver which does detect the link down I've > discovered it actually polls the link status by default in its watchdog. > > Disabling this with "ethtool --set-priv-flags eth1 LinkPolling off" and > the Linux dri

route command will perform DNS lookup of invalid interface name

2015-09-14 Thread Ryan Stone
At $WORK, we have observed that if you attempt to add a route with the -iface flag, but you specify an incorrect interface name, the route command will perform a DNS lookup of the interface name. It appears that if the DNS lookup succeeds that it will treat the parameter to -iface as if it were a

Re: [RFC] ifconfig description

2015-07-28 Thread Ryan Stone
On Jul 28, 2015 11:07 AM, "Sergey Kandaurov" wrote: > > On 28 July 2015 at 20:55, Alexander V. Chernikov wrote: > > 28.07.2015, 15:32, "Arseny Nasokin" : > > > > Separate ifconfig_IF_description will be simpler to use. > > > > I was also insisting on this.. > > +pluknet@ > > Sergey, maybe we coul

Re: Reg Intel Fortville IXL driver on 11-CURRENT

2015-06-17 Thread Ryan Stone
On Wed, Jun 17, 2015 at 7:00 AM, Lakshmi Narasimhan Sundararajan < lakshm...@msystechnologies.com> wrote: > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt ixl_txrx.c > ixl_txrx.c.mod > *** ixl_txrx.c Fri Jun 12 06:56:51 2015 > --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015 > *

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread rstone (Ryan Stone)
rstone added inline comments. INLINE COMMENTS sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?) sys/net/if_lagg.c:1773 style(9): put brackets around the return value: return (0); sys/net/if_lagg.c:1811 I find

[Differential] [Updated] D1986: Teach lagg(4) to change MTU

2015-03-01 Thread rstone (Ryan Stone)
rstone added a comment. RLOCK only gets a read lock. You want WLOCK to get a write lock to ensure serialization. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: ae, freebsd-net ___ freebsd-net@freebsd.org maili

HEADS UP: PCI SR-IOV infrastructure has been committed to head

2015-02-28 Thread Ryan Stone
I've just finished committing support for PCI Single Root I/O Virtualization in the pci subsystem to head. This should be a no-op for everyone right now, but there were some minor refactorings in the pci code that could have a lingering bug. I did make sure to test that it boots on a variety of s

[Differential] [Closed] D1883: Move libnv into the kernel and hook it into the kernel build

2015-02-28 Thread rstone (Ryan Stone)
rstone closed this revision. rstone updated this revision to Diff 4043. rstone added a comment. Closed by commit rS279439 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1883?vs=3826&id=4043#toc REVISION DETAIL https://reviews.freebsd.org/D1883 AFFECTED FILES h

[Differential] [Closed] D1882: Add macros to make code compile in kernel

2015-02-28 Thread rstone (Ryan Stone)
rstone closed this revision. rstone updated this revision to Diff 4041. rstone added a comment. Closed by commit rS279438 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1882?vs=3825&id=4041#toc REVISION DETAIL https://reviews.freebsd.org/D1882 AFFECTED FILES h

[Differential] [Closed] D1879: Don't allocate memory for operations that do not insert

2015-02-28 Thread rstone (Ryan Stone)
rstone closed this revision. rstone updated this revision to Diff 4039. rstone added a comment. Closed by commit rS279435 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1879?vs=3822&id=4039#toc REVISION DETAIL https://reviews.freebsd.org/D1879 AFFECTED FILES h

[Differential] [Closed] D1880: Prevent creation of an invalid nvlist

2015-02-28 Thread rstone (Ryan Stone)
rstone closed this revision. rstone updated this revision to Diff 4040. rstone added a comment. Closed by commit rS279436 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1880?vs=3823&id=4040#toc REVISION DETAIL https://reviews.freebsd.org/D1880 AFFECTED FILES h

[Differential] [Closed] D1870: Add tests for nvlist_clone

2015-02-28 Thread rstone (Ryan Stone)
rstone closed this revision. rstone updated this revision to Diff 4038. rstone added a comment. Closed by commit rS279425 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1870?vs=3862&id=4038#toc REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES h

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

2015-02-28 Thread rstone (Ryan Stone)
rstone added a subscriber: freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, se

Re: netmap support for the Intel 40G card in head

2015-02-24 Thread Ryan Stone
This is great! Thanks to both you and Intel. I'm planning on getting SR-IOV support into head this week, which would allow you to create ixlv instances (on the same hardware). Any chance that you'd have the time to look into supporting SR-IOV for that driver too?

Re: FreeBSD 10.1: Intel dual port 10GbE card (82599EB) second port not present?

2015-02-20 Thread Ryan Stone
I think that you might be a bit confused about the behaviour. An ix port will only be missing if a) You have a non-Intel SFP+ installed b) hw.ix.unsupported_sfp=1 is not set in loader.conf ix ports that have no SFP+ installed do show up in ifconfig ___

[Differential] [Closed] D1881: Allow Illumos code to co-exist with nv(9)

2015-02-20 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel, will Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe,

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

2015-02-19 Thread rstone (Ryan Stone)
rstone added a comment. Err, that was supposed to be "installed it into a couple of *VMs*" REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

2015-02-19 Thread rstone (Ryan Stone)
rstone added a comment. Ok, I did a full buildworld/buildkernel (with device zfs in my kernel config) and installed it into a couple of zfs. I tested creating a zpool out of a mfs disk, creating filesystems, setting some properties, doing a git clone into a file system, and then doing a zfs se

[Differential] [Updated, 120 lines] D1870: Add tests for nvlist_clone

2015-02-19 Thread rstone (Ryan Stone)
rstone updated this revision to Diff 3862. rstone added a comment. This revision now requires review to proceed. Fix the test case to actually test the clone CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1870?vs=3813&id=3862 BRANCH review_D1870 REVISION DETAIL https://reviews.fre

[Differential] [Closed] D1877: Implement asprintf in libkern

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1878: Add function to force an nvlist into the error state

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1869: Tests of basic nvlist add functions

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mai

[Differential] [Closed] D1868: Make libnv headers includable from C++

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "fr

[Differential] [Closed] D1872: Add test cases for nvlist_move_*

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1871: Add tests for nvlist_pack/unpack

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1873: Add tests for nvlist_take_*

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1874: Add tests for nvlist_free* functions

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1875: Add tests for dnv_get_*

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Closed] D1876: Add tests for dnvlist_take_*

2015-02-19 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

2015-02-18 Thread rstone (Ryan Stone)
rstone added a comment. The primary testing that I did was to ensure that a kernel with "device zfs" would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that

[Differential] [Closed] D1648: Add stubs for deprecated VC messages

2015-02-18 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1640: Refactor network stack state separate from VSI state

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1640 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1644: Add infrastructure for handling the VC msg channel from VFs

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1644 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1641: Implement PCI SR-IOV initialization methods

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1641 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1645: Add support for VERSION VC message

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1645 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1647: Add support for GET_VF_RESOURCES VC message

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1647 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

[Differential] [Closed] D1642: Implement PCI SR-IOV method to initialize individual VFs

2015-02-17 Thread rstone (Ryan Stone)
rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1642 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd

  1   2   3   >