[Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address

This revision was automatically updated to reflect the committed changes. Closed by commit rS366682: Join to AllHosts multicast group again when adding an existing IPv4 address. (authored by ae). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D26757?vs=78157&id=78184#toc REPOSITORY

[Differential] D26757: Fix to join AllHost mcast group again when adding an existing IP address

ae accepted this revision. ae added a comment. This revision is now accepted and ready to land. Looks correct to me. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D26757/new/ REVISION DETAIL https://reviews.freebsd.org/D26757 EMAIL

[Differential] D24989: netinet: Generate a random RSS key on boot.

ae added a comment. In D24989#552576 <https://reviews.freebsd.org/D24989#552576>, @avg wrote: > I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies). > So, maybe just being random is not good enough? &g

[Differential] D24061: Hyper-V socket implementation for FreeBSD guest

ae added a comment. Do you have performance test results for already existing linux implementation? From a quick look it seems to me there will be bottleneck regarding locking that seems can be reduced using CK and epoch. But this task can be done in future, if you plan support this code

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

ae added a comment. Also, how did test your changes? :) NAT64 currently is not widely used, thus changes here can break something and you will know about breakage when it will be not so easy to fix, e.g. after release. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

ae added a comment. In D23737#521593 <https://reviews.freebsd.org/D23737#521593>, @neel_neelc.org wrote: > Here, I also compare the destination addresses. Is this what you want? No, take a look at RFC 6052 p2.2. <https://tools.ietf.org/html/rfc6052#section-2.2>.

[Differential] D23737: nat64: Get the IPv4 address from a NAT64 address when comparing addresses in a ICMP translate

ae requested changes to this revision. ae added a comment. This revision now requires changes to proceed. The patch is not correct. IPv4 address can be embedded in different places depending from configuration. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https

[Differential] D12457: Complete INADDR_HASH lock protection

ae added inline comments. INLINE COMMENTS > eugen_grosbein.net wrote in if_stf.c:383 > in_localip() may be better, I just wished to make the patch as clear as > possible minizing changes for first revision. Using in_localip() is preferred, because INADDR_HASH is protected with rmlock

[Differential] D9451: Constrain IPv6 interface routes to each FIB

ae added a comment. Can you resubmit the patch with more context? You can make it using such arguments for svn diff "--diff-cmd=diff -x -U99" or similar arguments for your VCS. It produces a much large patches, but it is possible to see more context. REPOSITORY rS F

[Differential] D8214: ifnet: Use if_link_state snapshot to invoke ifnet_link_event

ae accepted this revision. ae added a reviewer: ae. ae added a comment. This revision has a positive review. Looks ok to me. REVISION DETAIL https://reviews.freebsd.org/D8214 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, glebius

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

ae added a comment. >>! In D1986#7, @rstone wrote: > RLOCK only gets a read lock. You want WLOCK to get a write lock to ensure > serialization. Also we can use another lock in the lagg_ioctl, that will prevent simultaneous MTU changing. REVISION DETAIL https://reviews.freebsd.o

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

ae added a subscriber: ae. ae added a comment. Just a thought. Imagine two interfaces, one has maximum MTU 2200, another 1500. lagg0 has MTU 1400. Two threads invokes changing MTU in the same time. One wants to change it to 2000, another - to 1500. It is possible, that when both threads will

[Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()

ae added a subscriber: ae. ae accepted this revision. ae added a reviewer: ae. ae added a comment. I have no objections against it, the code looks similar to previous implementation. REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, glebius, ae Cc: ae, glebius, freebsd-net

[Differential] [Changed Subscribers] D1815: Evaluate packet size after the firewall had its chance

ae added a subscriber: ae. ae added a comment. Since you are in ip6_forward(), this means ip6_input() has already checked this packet and PFIL had a chance to handle this packet. IPv6 router should not do reassembling fragmented packets and do new fragmentation of them, but if you want, I think

[Differential] [Changed Subscribers] D1777: Associated fix for arp/nd6 timer usage.

ae added a subscriber: ae. ae added a comment. You said about some panics, do you have traces? REVISION DETAIL https://reviews.freebsd.org/D1777 To: rrs, imp, sbruno, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz Cc: ae, bz, emaste, hiren, julian, hselasky, freebsd-net

[Differential] [Changed Subscribers] D1388: IP6: Turned on verbose logging for fragment handling code

ae added a subscriber: ae. ae added a comment. I think you need to adjust some comments in frag6_input(). REVISION DETAIL https://reviews.freebsd.org/D1388 To: kibab, bz Cc: ae, freebsd-net ___ freebsd-net@freebsd.org mailing list http

Re: kern/167793: [arp] mbuf leak if arp address is multicast

Synopsis: [arp] mbuf leak if arp address is multicast State-Changed-From-To: open->feedback State-Changed-By: ae State-Changed-When: Mon Apr 21 12:08:23 UTC 2014 State-Changed-Why: Do you able reproduce that? It seems the problem was fixed in r249742. Responsible-Changed-From-To: freebsd-

Re: kern/173521: [ip6] remove useless assign in ip6_hopopts_input

Synopsis: [ip6] remove useless assign in ip6_hopopts_input State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Thu Apr 17 06:40:24 UTC 2014 State-Changed-Why: Patched in head/. Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-C

Re: kern/176484: [ipsec] [enc] [patch] panic: IPsec + enc(4); device name clash with CAM

Synopsis: [ipsec] [enc] [patch] panic: IPsec + enc(4); device name clash with CAM State-Changed-From-To: open->closed State-Changed-By: ae State-Changed-When: Fri Apr 4 10:20:27 UTC 2014 State-Changed-Why: Fixed with r247424. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=176

Re: kern/174602: [gif] [ipsec] traceroute issue on gif tunnel with ipsec

Synopsis: [gif] [ipsec] traceroute issue on gif tunnel with ipsec Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Apr 4 09:52:50 UTC 2014 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=174

Re: kern/143593: [ipsec] When using IPSec, tcpdump doesn't show outgoing packets on gif interface

Synopsis: [ipsec] When using IPSec, tcpdump doesn't show outgoing packets on gif interface Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Apr 4 09:49:47 UTC 2014 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-p

Re: kern/143208: [ipsec] [gif] IPSec over gif interface not working

Synopsis: [ipsec] [gif] IPSec over gif interface not working Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Apr 4 09:45:33 UTC 2014 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=143

Re: kern/147894: [ipsec] IPv6-in-IPv4 does not work inside an ESP-only IPsec tunnel

Synopsis: [ipsec] IPv6-in-IPv4 does not work inside an ESP-only IPsec tunnel Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Apr 4 09:41:15 UTC 2014 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=147

Re: kern/65616: IPSEC can't detunnel GRE packets after real ESP encryption

Synopsis: IPSEC can't detunnel GRE packets after real ESP encryption Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Apr 4 09:37:42 UTC 2014 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?

Re: kern/181800: problem with router and vlan interface

Synopsis: problem with router and vlan interface State-Changed-From-To: open->closed State-Changed-By: ae State-Changed-When: Thu Sep 5 08:25:17 UTC 2013 State-Changed-Why: Actually the kernel uses right interfaces. Use -W key with netstat(1) and it will not truncate interface names in

Re: kern/181822: [netinet] [patch] drop dead / unused code

Synopsis: [netinet] [patch] drop dead / unused code State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Thu Sep 5 08:12:49 UTC 2013 State-Changed-Why: Committed. Thanks! Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Change

Re: kern/176596: [firewire] [ip6] Crash with IPv6 and Firewire

Synopsis: [firewire] [ip6] Crash with IPv6 and Firewire Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Fri Jun 14 15:40:18 UTC 2013 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=176

Re: kern/157209: [ip6] [patch] locking error in rip6_input() (sys/netinet6/raw_ip6.c)

Synopsis: [ip6] [patch] locking error in rip6_input() (sys/netinet6/raw_ip6.c) State-Changed-From-To: open->closed State-Changed-By: ae State-Changed-When: Sun Jun 9 04:31:46 UTC 2013 State-Changed-Why: This was fixed in r248180 and merged to stable/9, stable/8. Responsible-Changed-From

Re: kern/154169: [multicast] [ip6] Node Information Query multicast address wrong (FF02::2:x:y)

Synopsis: [multicast] [ip6] Node Information Query multicast address wrong (FF02::2:x:y) State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Sun Jun 9 04:26:47 UTC 2013 State-Changed-Why: This was patched in r250251. Thanks! http://www.freebsd.org/cgi/query-pr.cgi

Re: kern/177696: [patch] [net] Removing an unavailable sysctl from manpage

Synopsis: [patch] [net] Removing an unavailable sysctl from manpage State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Mon Apr 8 10:15:00 UTC 2013 State-Changed-Why: Committed to the head/. Thanks! Responsible-Changed-From-To: freebsd-net->ae Responsible-Chan

Re: kern/171697: [ip6] [ndp] panic when changing routes

Synopsis: [ip6] [ndp] panic when changing routes Responsible-Changed-From-To: freebsd-net->ae Responsible-Changed-By: ae Responsible-Changed-When: Sat Jan 5 22:22:46 UTC 2013 Responsible-Changed-Why: Take it. http://www.freebsd.org/cgi/query-pr.cgi?pr=171

Re: kern/168742: detaching of ethernet adapter with configured vlans leads to panic

Synopsis: detaching of ethernet adapter with configured vlans leads to panic Responsible-Changed-From-To: freebsd-bugs->freebsd-net Responsible-Changed-By: ae Responsible-Changed-When: Tue Aug 7 04:48:17 UTC 2012 Responsible-Changed-Why: Reassign. http://www.freebsd.org/cgi/query-pr.cgi

Re: kern/143939: [ipfw] [em] ipfw nat and em interface rxcsum problem

Synopsis: [ipfw] [em] ipfw nat and em interface rxcsum problem State-Changed-From-To: feedback->closed State-Changed-By: ae State-Changed-When: Mon Jul 25 04:25:21 UTC 2011 State-Changed-Why: The submitter has reported that the problem is already fixed. Thanks! http://www.freebsd.org/cgi/qu

Re: kern/143939: [ipfw] [em] ipfw nat and em interface rxcsum problem

Synopsis: [ipfw] [em] ipfw nat and em interface rxcsum problem State-Changed-From-To: open->feedback State-Changed-By: ae State-Changed-When: Wed Jul 20 19:17:03 UTC 2011 State-Changed-Why: Can you still reproduce this on a supported release? http://www.freebsd.org/cgi/query-pr.cgi?pr=143

Re: kern/155498: [ral] ral(4) needs to be resynced with OpenBSD's to gain RT2860/2870 support.

Synopsis: [ral] ral(4) needs to be resynced with OpenBSD's to gain RT2860/2870 support. Responsible-Changed-From-To: freebsd-net->freebsd-wireless Responsible-Changed-By: ae Responsible-Changed-When: Thu Jul 14 07:00:44 UTC 2011 Responsible-Changed-Why: Reassign to wireless tea

Re: kern/154831: [arp] [patch] arp sysctl setting log_arp_permanent_modify has no effect

Synopsis: [arp] [patch] arp sysctl setting log_arp_permanent_modify has no effect State-Changed-From-To: patched->closed State-Changed-By: ae State-Changed-When: Thu Jul 14 04:21:55 UTC 2011 State-Changed-Why: Merged to stable/8. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=154

Re: bin/137841: [patch] wpa_supplicant(8) cannot verify SHA256 signed certificates

Synopsis: [patch] wpa_supplicant(8) cannot verify SHA256 signed certificates State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Thu Jul 7 12:31:23 UTC 2011 State-Changed-Why: This issue was fixed in head/ with r214734. http://www.freebsd.org/cgi/query-pr.cgi?pr=137

Re: kern/154831: [arp] [patch] arp sysctl setting log_arp_permanent_modify has no effect

Synopsis: [arp] [patch] arp sysctl setting log_arp_permanent_modify has no effect State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Thu Jul 7 12:00:18 UTC 2011 State-Changed-Why: Committed to head/. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=154

Re: kern/157802: [dummynet] [panic] kernel panic in dummynet

Synopsis: [dummynet] [panic] kernel panic in dummynet State-Changed-From-To: open->feedback State-Changed-By: ae State-Changed-When: Fri Jun 17 11:33:59 UTC 2011 State-Changed-Why: Feedback requested. http://www.freebsd.org/cgi/query-pr.cgi?pr=157

Re: kern/152360: [dummynet] [panic] Crash related to dummynet.

Synopsis: [dummynet] [panic] Crash related to dummynet. Responsible-Changed-From-To: freebsd-net->freebsd-ipfw Responsible-Changed-By: ae Responsible-Changed-When: Tue Jun 14 06:56:18 UTC 2011 Responsible-Changed-Why: Reassign. It's ipfw related. http://www.freebsd.org/cgi/query-p

Re: kern/131601: [ipfilter] [panic] 7-STABLE panic in nat_finalise (tcp=0)

Old Synopsis: [ipfw] [panic] 7-STABLE panic in nat_finalise (tcp=0) New Synopsis: [ipfilter] [panic] 7-STABLE panic in nat_finalise (tcp=0) Responsible-Changed-From-To: freebsd-ipfw->freebsd-net Responsible-Changed-By: ae Responsible-Changed-When: Mon Jun 6 11:24:06 UTC 2011 Responsible-Chan

Re: kern/156770: [ipfw] [dummynet] [patch]: performance improvement and several extensions

Synopsis: [ipfw] [dummynet] [patch]: performance improvement and several extensions Responsible-Changed-From-To: freebsd-net->freebsd-ipfw Responsible-Changed-By: ae Responsible-Changed-When: Tue May 3 11:42:34 UTC 2011 Responsible-Changed-Why: Seems it is related to ipfw. h

Re: kern/137775: [netgraph] [patch] Add XMIT_FAILOVER to ng_one2many

Synopsis: [netgraph] [patch] Add XMIT_FAILOVER to ng_one2many State-Changed-From-To: patched->closed State-Changed-By: ae State-Changed-When: Tue Mar 15 07:16:53 UTC 2011 State-Changed-Why: Merged to stable/8 and stable/7. http://www.freebsd.org/cgi/query-pr.cgi?pr=137

Re: kern/137775: [netgraph] [patch] Add XMIT_FAILOVER to ng_one2many

Synopsis: [netgraph] [patch] Add XMIT_FAILOVER to ng_one2many State-Changed-From-To: open->patched State-Changed-By: ae State-Changed-When: Tue Mar 1 13:14:56 UTC 2011 State-Changed-Why: Commited to head/. Thanks! http://www.freebsd.org/cgi/query-pr.cgi?pr=137

RE: Broadcom 5780

. (Try a diff between 1.134 and 1.135 on -CURRENT to quickly identify the relevant changes.) Dave > -Original Message- > From: Pavol Čierny [mailto:[EMAIL PROTECTED] > Sent: Thursday, August 03, 2006 4:26 AM > To: David (Controller AE) Christensen > Cc: freebsd-net@freebs

RE: Broadcom 5780

I don't maintain that driver so I don't know the answer to that. Dave > -Original Message- > From: Pavol Čierny [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 19, 2006 11:43 AM > To: David (Controller AE) Christensen > Cc: freebsd-net@freebsd.org >

RE: Broadcom 5780

Pavol, The 5780 is functionally equivalent to the 5714. Support for the 5780 was added to -CURRENT on June 29, 2006 in version 1.135 of if_bge.c. Dave > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Pavol Cierny > Sent: Wednesday, July 19, 2006