ale added a comment.
I'd like to see this in the next 11.2-RELEASE. @eugen_grosbein.net can you
please commit it and MFH?
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
ale updated this revision to Diff 32487.
ale added a comment.
The updated patch fixes the reported issue on multiple PADO replies after the
session has been already established.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
ale added a comment.
> How the tag should be defined in mpd.conf then?
>
> set auth host-uniq "string" ?
No, to just set the host-uniq string you should use:
set pppoe service "string|"
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
ale marked 5 inline comments as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: ale, #manpages, wblock, #network, julian, mav, adrian, glebius
Cc: glebius,
ale updated this revision to Diff 27059.
ale added a comment.
Addressed latest comments, updated also the pppoe disconnect function.
Please check the correctness, and commit the patch if you are satisfied.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
ale added a comment.
The three mentioned comments apply also to the ng_pppoe_disconnect function
at line 2030 from which I took inspiration, do you want me to change that
function, too?
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL
ale added a comment.
This revision now requires review to proceed.
Who is going to commit it in the src tree and merge in 11 branch?
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
ale marked 14 inline comments as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: ale, julian, #manpages, mav, #network, adrian
Cc: wblock, mav,
ale updated this revision to Diff 25977.
ale added a comment.
This revision now requires review to proceed.
Man page improvements
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9270?vs=25849=25977
REVISION DETAIL
ale added a comment.
Thanks for your comment, I'll improve the man page.
INLINE COMMENTS
> wblock wrote in ng_pppoe.4:108
> "host uniq" should be capitalized or otherwise identified with markup. Since
> it's used below, just be consistent and say `Host-Uniq`.
Are you fine with lower case
ale retitled this revision from "Add support for user-supplied Host-Uniq tag in
Netgraph PPPoE" to "Add support for user-supplied Host-Uniq tag and handle PADM
messages in Netgraph PPPoE".
ale updated the summary for this revision.
ale updated the test plan for this revision.
ale added a
ale marked 2 inline comments as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: ale, #network, #manpages, julian
Cc: mandree, imp, freebsd-net-list
ale updated this revision to Diff 24314.
ale added a comment.
This revision now requires review to proceed.
Fixed typos and improved man page.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D9270?vs=24264=24314
REVISION DETAIL
ale created this revision.
ale added reviewers: network, julian.
ale added subscribers: freebsd-net-list, mandree.
ale set the repository for this revision to rS FreeBSD src repository.
Herald added a subscriber: imp.
Herald added a reviewer: manpages.
REVISION SUMMARY
Add support for
14 matches
Mail list logo
