[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste removed a subscriber: freebsd-net-list. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: brooks

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added a subscriber: brooks. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: brooks, freebsd-net

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added a comment. As @melifaro pointed out to prompt this change hp was passed to three getaddr() calls in newroute(), and was not otherwise used, and getaddr() does not use the passed-in value. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste updated this revision to Diff 100973. emaste added a comment. remove now-unused variable CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D33717?vs=100815&id=100973 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL h

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste added reviewers: imp, hrs. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: freebsd-net-list

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste removed reviewers: imp, hrs. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVISION DETAIL https://reviews.freebsd.org/D33717 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, melifaro, imp, hrs Cc: freebsd-net-list

[Differential] D33717: route: remove write-only struct hostent from getaddr()

emaste updated this revision to Diff 100815. emaste added reviewers: melifaro, imp, hrs. emaste added a subscriber: freebsd-net-list. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D33717?vs=100814&id=100815 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D33717/new/ REVI

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: emaste, ae, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To

[Differential] [Changed Subscribers] D1869: Tests of basic nvlist add functions

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send

[Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9)

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send

[Differential] [Changed Subscribers] D1805: [sockbuf] Don't access fields directly, use accessor functions

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1805 To: davide, kmacy, np, lstewart, rrs, rwatson Cc: emaste, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

emaste added inline comments. INLINE COMMENTS kern/kern_timeout.c:1159 Yeah, something like @imp's suggestion makes it more clear to me. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, sbruno, lstewart, jhb, kostikbel, hselasky, adrian, imp Cc: jhb, kost

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

emaste added a comment. For future diffs, please generate with full context, e.g. -U99 INLINE COMMENTS sys/kern/kern_timeout.c:789 added EOL whitespace? sys/kern/kern_timeout.c:1067-1069 I'm a bit confused by this sentence. REVISION DETAIL https://reviews.freebsd.org/D1711 To

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, hselasky, imp Cc: emaste, delphij, neel, erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http

[Differential] [Changed Subscribers] D1309: VIMAGE PF fixes #1

emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: emaste, freebsd-virtualization, freebsd-pf, freebsd-net

Re: kern/140634: [vlan] destroying if_lagg interface with if_vlan members causing 100% usage by ifconfig

Synopsis: [vlan] destroying if_lagg interface with if_vlan members causing 100% usage by ifconfig State-Changed-From-To: open->feedback State-Changed-By: emaste State-Changed-When: Mon Oct 15 00:59:14 UTC 2012 State-Changed-Why: A quick browse of the source suggests this should be fixed as

Re: kern/117271: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf

Synopsis: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf State-Changed-From-To: open->closed State-Changed-By: emaste State-Changed-When: Wed Sep 26 12:52:36 UTC 2012 State-Changed-Why: Submitter reports this works on stable/8. http://www.freebsd.org/cgi/qu

Re: kern/117271: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf

Synopsis: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf State-Changed-From-To: feedback->open State-Changed-By: emaste State-Changed-When: Wed Sep 26 00:37:49 UTC 2012 State-Changed-Why: Ahh, it's OpenVPN that consumed 100% CPU, so non-OpenVPN TAP consu

Re: kern/117271: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf

Synopsis: [tap] OpenVPN TAP uses 99% CPU on releng_6 when if_tap is in /boot/loader.conf State-Changed-From-To: open->feedback State-Changed-By: emaste State-Changed-When: Wed Sep 26 00:33:10 UTC 2012 State-Changed-Why: Does this problem persist on current releases? I have if_tap loaded

Re: kern/138620: [lagg] [patch] lagg port bpf-writes blocked

Synopsis: [lagg] [patch] lagg port bpf-writes blocked State-Changed-From-To: open->patched State-Changed-By: emaste State-Changed-When: Thu May 3 01:41:29 UTC 2012 State-Changed-Why: Committed revision 234936. http://www.freebsd.org/cgi/query-pr.cgi?pr=138

Re: kern/142518: [em] [lagg] Problem on 8.0-STABLE with em and lagg

Synopsis: [em] [lagg] Problem on 8.0-STABLE with em and lagg Responsible-Changed-From-To: jfv->net Responsible-Changed-By: emaste Responsible-Changed-When: Tue May 1 18:53:35 UTC 2012 Responsible-Changed-Why: It sounds like this is a problem with lagg(4) not em(4) and so shouldn't be ass

Re: kern/127834: [ixgbe] [patch] wrong error counting

Synopsis: [ixgbe] [patch] wrong error counting Responsible-Changed-From-To: freebsd-net->rstone Responsible-Changed-By: emaste Responsible-Changed-When: Wed May 12 14:07:07 UTC 2010 Responsible-Changed-Why: Ryan checked on this; it is fixed in -CURRENT. He'll check the state of stab

Re: kern/122780: [lagg] tcpdump on lagg interface during high pps wedges netcode

Synopsis: [lagg] tcpdump on lagg interface during high pps wedges netcode State-Changed-From-To: open->feedback State-Changed-By: emaste State-Changed-When: Mon Jan 18 20:54:42 UTC 2010 State-Changed-Why: Results of testing on more recent 7.x (or newer branch) requested http://www.freebsd.

Re: kern/122794: [lagg] Kernel panic after brings lagg(8) up if NICs are not bringed up before

Synopsis: [lagg] Kernel panic after brings lagg(8) up if NICs are not bringed up before State-Changed-From-To: patched->closed State-Changed-By: emaste State-Changed-When: Mon Aug 17 20:16:50 UTC 2009 State-Changed-Why: I see that thompsa has MFC'd this to 7 & 6. http://www.fre