[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2018-02-13 Thread franco_opnsense.org (Franco Fichtner)
franco_opnsense.org added a comment. Any news on this? :) REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, wblock, #network, julian, mav, adrian, gl

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-08-29 Thread franco_opnsense.org (Franco Fichtner)
franco_opnsense.org accepted this revision. franco_opnsense.org added a comment. this one is stable, thank you @ale REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To:

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-08-22 Thread franco_opnsense.org (Franco Fichtner)
franco_opnsense.org added a comment. No, I'm not asking for support that would take a few weeks of ping pong in a bug tracker, if any. This is real world feedback for this review. Take it or leave it. :) REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-08-22 Thread franco_opnsense.org (Franco Fichtner)
franco_opnsense.org added a comment. Thanks, but we've narrowed it down to this commit. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, wblock, #ne

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

2017-08-21 Thread franco_opnsense.org (Franco Fichtner)
franco_opnsense.org added a comment. We do seem to have a persistent problem with this patch in some PPPoE environments that will cause a crash in ng_pppoe_rcvdata_ether(): https://ibb.co/mRWKHF https://ibb.co/iOxRxF https://forum.opnsense.org/index.php?topic=5697.0 Please advise