gnn accepted this revision.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D26757/new/
REVISION DETAIL
https://reviews.freebsd.org/D26757
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To:
gnn accepted this revision.
gnn added a reviewer: gnn.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list,
gnn accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D8905
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, delphij, royger, decui_microsoft.com,
honzhan_microsoft.com,
gnn added a comment.
Not my comment "once everyone agrees" :-)
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, network, glebius, adrian, delphij,
decui_microsoft.com,
gnn added a comment.
Let's keep this moving along. Mike isn't (yet) a committer but if someone
can commit this once everyone agrees that would be great.
REVISION DETAIL
https://reviews.freebsd.org/D5872
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To:
gnn closed this revision.
gnn added a comment.
I believe we can close this.
REVISION DETAIL
https://reviews.freebsd.org/D1777
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rrs, imp, rwatson, lstewart, kib, adrian, jhb, bz, sbruno, gnn
Cc: ae, bz,
gnn added a comment.
Any update on this?
REVISION DETAIL
https://reviews.freebsd.org/D1944
To: nvass-gmx.com, bz, zec, trociny, glebius, rodrigc, kristof, gnn
Cc: freebsd-virtualization, freebsd-pf, freebsd-net
___
freebsd-net@freebsd.org mailing
gnn accepted this revision.
gnn added a comment.
BTW Mike Karels was in favor of this in an email thread. He's not yet on
phabricator but I'll ask him here as well.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1965
To: erj, adrian, jfvogel, gnn
Cc: glebius, freebsd-net
gnn accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1691
To: arybchik, gnn
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to put Approved by: gnn (mentor) in the commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1708
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to put Approved by: gnn (mentor) in the commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1698
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1705
To: arybchik, gnn
Cc: freebsd-net
gnn requested changes to this revision.
gnn added a comment.
This revision now requires changes to proceed.
If you look at other drivers you'll see they have #define'd macros for the
locks, rather than direct calls. This allows us to name the lock in the macro.
See, for instance, this example
gnn requested changes to this revision.
gnn added a comment.
This revision now requires changes to proceed.
__predict_false rarely, if ever, does the right thing. Have you run any
benchmarks to show that this improves performance?
REVISION DETAIL
https://reviews.freebsd.org/D1697
To:
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1704
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1703
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1702
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1706
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1701
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
REVISION DETAIL
https://reviews.freebsd.org/D1692
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to add Approved by: gnn (mentor) to your commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1700
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to put Approved by: gnn (mentor) in the commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1699
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a comment.
This revision is now accepted and ready to land.
Remember to put Approved by: gnn (mentor) in the commit message.
BRANCH
/head
REVISION DETAIL
https://reviews.freebsd.org/D1694
To: arybchik, gnn
Cc: freebsd-net
gnn accepted this revision.
gnn added a reviewer: gnn.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1309
To: rodrigc, bz, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv,
rpaulo, adrian, gnn, hiren, rwatson
Cc: freebsd-virtualization,
gnn added a comment.
No objection from me.
REVISION DETAIL
https://reviews.freebsd.org/D1201
To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo,
adrian, bz, gnn, hiren, rwatson
Cc: freebsd-net, emaste, gnn, rwatson
___
25 matches
Mail list logo