hselasky added a subscriber: glebius.
hselasky added a comment.
@oleg : Beware of the callout return value differences between FreeBSD
9-10-11 and 12 !
@glebius
REVISION DETAIL
https://reviews.freebsd.org/D1777
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferenc
hselasky accepted this revision.
hselasky added a reviewer: hselasky.
hselasky added a comment.
This revision has a positive review.
Looks good to me.
REVISION DETAIL
https://reviews.freebsd.org/D8685
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: rsto
hselasky added inline comments.
INLINE COMMENTS
> buf_ring.h:71
> + if (br->br_cons_head != br->br_prod_head) {
> + for (i = br->br_cons_head + 1; i != br->br_prod_head;
> + i = ((i + 1) & br->br_cons_mask))
should "br->br_cons_head + 1" be masked by br->br_cons_m
hselasky accepted this revision.
hselasky added a reviewer: hselasky.
hselasky added a comment.
Don't forget to MFC.
REVISION DETAIL
https://reviews.freebsd.org/D7710
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, glebius, bz, gnn,
hselasky accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D7593
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, glebius, bz, gnn, rwatson, hselasky
Cc: freebsd-net-list
___
hselasky accepted this revision.
hselasky added a comment.
This revision has a positive review.
Just make sure the code builds, amd64, i386, arm.
--HPS
REVISION DETAIL
https://reviews.freebsd.org/D7592
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To
hselasky accepted this revision.
REVISION DETAIL
https://reviews.freebsd.org/D7499
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, rrs, gallatin, np, #transport, hselasky
Cc: freebsd-net-list
hselasky added inline comments.
INLINE COMMENTS
> tcp_lro.c:79
> +
> +static unsigned tcp_lro_entries = TCP_LRO_ENTRIES;
> +SYSCTL_UINT(_net_inet_tcp_lro, OID_AUTO, entries,
Maybe you should use a procedure type and range check the argument.
REVISION DETAIL
https://reviews.freebsd.org/D7
hselasky accepted this revision.
hselasky added a comment.
Looks good to me.
--HPS
REVISION DETAIL
https://reviews.freebsd.org/D7415
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, rrs, gallatin, np, glebius, hiren, bz, #transp
hselasky added inline comments.
INLINE COMMENTS
> tcp_lro.c:852
> }
>
> /* Try to find an empty slot. */
Should there be added:
if (force_flush)
return (TCP_LRO_CANNOT);
If no match is found in the list?
REVISION DETAIL
https://reviews.freebsd.org/D7415
EMAIL PREFERENCES
hselasky added a comment.
@sepherosa_gmail.com
Regarding performance. Is it possible to get the Hyper-V to sort the
IP-packets before they enter the FreeBSD network stack in the VM?
REVISION DETAIL
https://reviews.freebsd.org/D6689
EMAIL PREFERENCES
https://reviews.freebsd.org/setti
hselasky added a comment.
Hi,
Were you able to test the performance using tcp_lro_queue_mbuf() ?
Better name for function?? tcp_lro_rx2() -> tcp_lro_rx_sub()
--HPS
REVISION DETAIL
https://reviews.freebsd.org/D6689
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
hselasky added a comment.
What is the advantage of this bit versus a hash-type range check?
REVISION DETAIL
https://reviews.freebsd.org/D6406
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: sepherosa_gmail.com, #network, adrian, delphij, rwatson, gnn, g
hselasky added a comment.
Basically what you're doing is to loop back the flowid of the received packet
- right?
Maybe you could put that in a code comment.
REVISION DETAIL
https://reviews.freebsd.org/D6120
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreference
hselasky added a comment.
The size of lro_ctrl already changed when the statistics was made 64-bit.
Just remember to bump the FreeBSD_version. Might not be possible to MFC.
REVISION DETAIL
https://reviews.freebsd.org/D5185
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emai
hselasky added inline comments.
INLINE COMMENTS
sys/netinet/tcp_lro.h:94 Might be worth set this limit to unsigned instead of
unsigned short. Technically we can LRO more than 64KBytes worth of data!
REVISION DETAIL
https://reviews.freebsd.org/D5185
EMAIL PREFERENCES
https://reviews.freebs
hselasky added a comment.
FYI
https://reviews.freebsd.org/D1761 might be related to this one.
Should you check that "lc->lro_hiwat" is greater or equal to
"lc->ifp->if_mtu" ?
--HPS
REVISION DETAIL
https://reviews.freebsd.org/D4825
EMAIL PREFERENCES
https://reviews.freebsd.
hselasky added a comment.
lstewart: We can generate a paper documenting the benefits of enlarging the
IP-packet input payload, so that we can fully understand what is going on.
Going the multipacket approach seems a bit more tricky, hence it involves
changing the TCP and posibly also if_output(
hselasky added a comment.
lawrence: It is someone well known to be using FreeBSD. This patch makes such a
big difference when applied to +10Gbit/s connections that we can run 2 TCP
streams totalling 37.5 GBit/s on a single 2.x GHz CPU core instead of only one.
REPOSITORY
rS FreeBSD src repos
hselasky added a comment.
lstewart: OK, just don't delete this patch, because some people are using it.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D1761
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: hselasky, rrs
hselasky updated this revision to Diff 5720.
hselasky added a comment.
Herald added a subscriber: imp.
Minor fix for computing correct ip6_plen in ip6_input().
Previously only the first 64K of the payload was consumed.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST UPDATE
https://r
hselasky abandoned this revision.
hselasky added a comment.
Committed to FreeBSD-head in r279281.
REVISION DETAIL
https://reviews.freebsd.org/D1893
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: hselasky, glebius, ken, eri, nitroboost-gmail.com, pluknet,
This revision was automatically updated to reflect the committed changes.
Closed by commit rS282414: Major callout subsystem cleanup and rewrite:
(authored by hselasky).
CHANGED PRIOR TO COMMIT
https://reviews.freebsd.org/D1438?vs=4870&id=5170#toc
REPOSITORY
rS FreeBSD src repository
REVISI
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1438
To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn,
rrs, kostikbel, delphij, neel, erj, mat, remkolodder, bcr, brueffer, brd,
allanjude, w
hselasky updated this revision to Diff 4870.
hselasky added a comment.
Revert more chunks as part of integration latest 11-current changes.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=4869&id=4870
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/ma
hselasky set the repository for this revision to rS (FreeBSD src repository).
hselasky updated this revision to Diff 4869.
hselasky added a comment.
Rebase patch to latest FreeBSD-current.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3956&id=4869
REVISION DETAIL
https://rev
hselasky added a subscriber: hselasky.
BRANCH
/head
INLINE COMMENTS
sys/net/if_media.h:182 Style nit. after define.
REVISION DETAIL
https://reviews.freebsd.org/D1965
To: erj, adrian, jfvogel, gnn
Cc: hselasky, mike-karels.net, glebius, freebsd-net
hselasky added a reviewer: ae.
REVISION DETAIL
https://reviews.freebsd.org/D1987
To: hselasky, glebius, ken, adrian, ae
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1987
To: hselasky, glebius, ken, adrian, ae
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/ma
hselasky updated this revision to Diff 4084.
hselasky added a comment.
Build fix.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4082&id=4084
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
sys/conf/files
sys/kern/uipc_mbufhash.c
sys/modules/mlxen/Make
hselasky updated this revision to Diff 4082.
hselasky added a comment.
Get the directory layout correct.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4081&id=4082
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
sys/conf/files
sys/kern/uipc_mbufhash.c
hselasky updated this revision to Diff 4081.
hselasky added a comment.
Update patch to latest FreeBSD-11 code and fix some build issues.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4033&id=4081
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
conf/files
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1987
To: hselasky, glebius, ken, adrian
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailma
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rrs, glebius, gnn, emaste, lstewart, rwatson, bz, imp, np,
adrian, jfvogel
Cc: freebsd-net
___
freebsd-net@f
hselasky added a reviewer: jfvogel.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rrs, glebius, gnn, emaste, lstewart, rwatson, bz, imp, np,
adrian, jfvogel
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freeb
hselasky added a comment.
Hi,
Adrian:
Would a set of macros hiding how we set and clear the LRO_TCP "flag" be
acceptable, then we can later resolve that minor detail, exactly how the bit is
encoded?
#define M_SET_LRO_TCP(m) ...
#define M_CLR_LRO_TCP(m) ...
#define M_GET_LRO_TCP(m) ...
--HPS
hselasky updated this revision to Diff 4033.
hselasky added a comment.
Remove patches not belonging to this issue.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4032&id=4033
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
sys/conf/files
sys/kern/uipc_mb
hselasky updated this revision to Diff 4032.
hselasky added a comment.
Factor out more code.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4030&id=4032
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
share/man/man9/Makefile
share/man/man9/timeout.9
sy
hselasky updated this revision to Diff 4030.
hselasky added a comment.
Add full patch context.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1987?vs=4029&id=4030
REVISION DETAIL
https://reviews.freebsd.org/D1987
AFFECTED FILES
sys/conf/files
sys/kern/uipc_mbufhash.c
sys/net/i
hselasky created this revision.
hselasky added reviewers: glebius, ken, adrian.
hselasky added a subscriber: freebsd-net.
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION SUMMARY
Factor out mbuf hashing code instead of copying it around.
REVISION DETAIL
h
hselasky updated the summary for this revision.
hselasky updated this revision to Diff 3956.
hselasky added a comment.
Restore how callout_lock() worked, so that a callout can migrate at any time
regardless of callout type.
Update manual page to reflect this change.
Use an unsigned integer for ca
hselasky updated this revision to Diff 3951.
hselasky added a comment.
MPSAFE callouts do not support CPU migration with this implementation
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3922&id=3951
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/m
hselasky updated this revision to Diff 3922.
hselasky added a comment.
Replace spinlock_enter/exit with KASSERT's.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3897&id=3922
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
share/m
hselasky updated this revision to Diff 3897.
hselasky added a comment.
Add context to diff.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3896&id=3897
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
share/man/man9/timeout.9
sys
hselasky updated this revision to Diff 3896.
hselasky added a comment.
Disallow task switching during hard tick interrupts.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3868&id=3896
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
hselasky updated this revision to Diff 3868.
hselasky added a comment.
Integrate manual page comments from Warren Block.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3840&id=3868
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
s
hselasky added a comment.
Let me re-phrase if I was unclear:
I see nothing preventing the callout_reset() macro from reading (c)->c_cpu lock
when it is equal to CPUBLOCK while another CPU is calling callout_cpu_switch()
on the same callout.
Especially in the case of a migration case done by th
hselasky updated this revision to Diff 3840.
hselasky added a comment.
Integrate manual page comments from Warren Block.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3809&id=3840
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
s
hselasky updated this revision to Diff 3839.
hselasky added a comment.
Use MIN() macro.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1893?vs=3838&id=3839
REVISION DETAIL
https://reviews.freebsd.org/D1893
AFFECTED FILES
sys/netinet/ip_output.c
To: hselasky, pluknet, ae, np, meli
hselasky added reviewers: network, glebius.
hselasky added a subscriber: freebsd-net.
hselasky set the repository for this revision to rS (FreeBSD src repository).
hselasky updated this revision to Diff 3838.
hselasky added a comment.
Add full context.
CHANGES SINCE LAST UPDATE
https://reviews.
hselasky added a comment.
Randall: Shooting again:
Thread 1 is executing in "softclock_call_cc()" in the "new_cc =
callout_cpu_switch(c, cc, new_cpu)" it has set "c->c_cpu = CPUBLOCK;"
Thread 2 is now executing callout_reset(). As you can see in the implementation
detail, it is reading "c_cpu"
hselasky added a comment.
randall: You are right I confused the two c_cpu values.
Let my try to shoot again:
static struct callout_cpu *
callout_cpu_switch(struct callout *c, struct callout_cpu *cc, int new_cpu)
{
struct callout_cpu *new_cc;
MPASS(c != NULL && cc != NULL);
hselasky added a comment.
randall: Let me try to explain a bit slower:
Assume that a callout has been cancelled and is now migrating to another CPU.
c->c_cpu = CPUBLOCK.
Upon calling _callout_stop_safe() we will enter the callout_lock() function
which will wait for the condition "c->c_cpu == C
hselasky added a comment.
If you change how "cc_migration_cpu(cc, direct)" works, the
"cc_cce_migrating()" checks become invalid. I think you need to introduce yet
another callout flag
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbr
hselasky added a comment.
Hi,
rrs + hiren:
I think the problem is this:
In "_callout_stop_safe()" we sometimes exit having "cc_migration_cpu(cc,
direct) = CPUBLOCK;". Now if a second call to "_callout_stop_safe()" happens
before the pending callback has returned, which is using a mutex, we ar
hselasky updated this revision to Diff 3809.
hselasky added a comment.
Update diff after r278623. No other changes.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3734&id=3809
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
share/
hselasky updated this revision to Diff 3734.
hselasky added a comment.
Integrate changes after r278469.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3607&id=3734
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
share/man/man9/tim
hselasky added a comment.
Don't forget to add the "MFC after" tag.
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky
Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net
___
hselasky added a comment.
Adrian: We do have one bit left after M_FLOWID was removed. Should I use it for
this? And what would be an appropriate name. M_LENGTH_OK ?
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rrs, glebius, gnn, emaste, lstewart, rwatson, bz, imp, np, adria
hselasky added a comment.
julian: What do you mean by "wait a bit". Spinning or sleeping?
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, hselasky, adrian, imp, sbruno
Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net
hselasky added a comment.
julian: Hence a lock is used, the callback won't be called when callout_stop()
returns 1. Only the mutex will still be used. Maybe a callout_reset() having 1
tick as timeout will work instead of callout_stop(). If the callout_reset()
returns 0 we add a ref instead of g
hselasky edited reviewers, added: np; removed: rmacklem
hselasky removed a subscriber: np.
hselasky updated this revision to Diff 3630.
hselasky added a comment.
Address comments from imp and np:
- Update patch to use IP_MAXPACKET as default for LRO which preserves existing
behaviour.
- Add to n
hselasky added a comment.
Hi,
There is only one or two likely consumers of callout_init_rw() at the present
moment, and one of them is:
./netinet6/nd6.c: canceled = callout_stop(&ln->ln_timer_ch);
./netinet6/nd6.c: canceled =
callout_reset(&ln->ln_timer_ch,
hselasky added a comment.
adrian: I'm not in a position to change the IP header structure to support
32-bit payload length. That's why m_pkthdr.len was chosen.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, imp, adrian, bz, rwatson
Cc: fre
hselasky added a comment.
rwatson: The LRO code ensures that all trailing and padding is stripped. This
happens both before and after my change.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, imp, adrian, bz, rwatson
Cc: freebsd-net
__
hselasky added a comment.
See comments added.
INLINE COMMENTS
sys/netinet/ip_output.c:129 Because the variable is later on compared to the
"mtu" which is also an "int". Else you will get a compile warning about signed
comparison mismatch. Same goes for other location where "int" is used.
sy
hselasky updated this revision to Diff 3607.
hselasky added a comment.
Add full context to patch.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1438?vs=3574&id=3607
REVISION DETAIL
https://reviews.freebsd.org/D1438
AFFECTED FILES
share/man/man9/Makefile
share/man/man9/timeout.9
hselasky updated this revision to Diff 3606.
hselasky added a comment.
Add context to patch.
CHANGES SINCE LAST UPDATE
https://reviews.freebsd.org/D1761?vs=3601&id=3606
REVISION DETAIL
https://reviews.freebsd.org/D1761
AFFECTED FILES
sys/netinet/ip_input.c
sys/netinet/ip_output.c
sys/
hselasky accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, sbruno, lstewart, imp, jhb, adrian, kostikbel, hselasky
Cc: jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net
hselasky added a reviewer: imp.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, bz, adrian, rwatson, imp
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
http://lists.freebsd.org/mailman/lis
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, bz, adrian, rwatson, imp
Cc: freebsd-net
___
freebsd-net@freebsd.org mai
hselasky created this revision.
hselasky added reviewers: rmacklem, rrs, glebius, gnn, emaste, bz, adrian,
rwatson.
hselasky added a subscriber: freebsd-net.
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION SUMMARY
To be able to handle the transfer rates of
hselasky accepted this revision.
hselasky added a comment.
Looks good. There are some non-related changes still, like the definition of
access macros to improve readability.
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, sbruno, lstewart, imp, adrian, hselasky
Cc: jh
hselasky added a comment.
The last patch also corrects the first argument for the "cpu_new_callout()"
function.
REVISION DETAIL
https://reviews.freebsd.org/D1438
To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn,
rrs, kostikbel, delphij, neel, erj
Cc: freebsd-net
hselasky added a subscriber: freebsd-net.
REVISION DETAIL
https://reviews.freebsd.org/D1438
To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn,
rrs, kostikbel, delphij, neel, erj
Cc: freebsd-net
___
freebsd-net@freebsd.org
hselasky accepted this revision.
hselasky added a comment.
This revision is now accepted and ready to land.
This looks usable.
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, rwatson, adrian, sbruno, lstewart, imp, hselasky
Cc: emaste, delphij, neel, erj, freebsd-net
__
hselasky added a comment.
Did you upload the correct patch?
INLINE COMMENTS
sys/kern/kern_timeout.c:674 I don't mean inside the if (c_lock != NULL) { }
There should be an else case after it.
if (c_lock != NULL) {
...
} else {
/* The callout cannot be stopped now */
cc_exec_ca
hselasky requested changes to this revision.
hselasky added a comment.
This revision now requires changes to proceed.
See comments given.
INLINE COMMENTS
sys/kern/kern_timeout.c:674 cc_exec_cancel(cc, direct) should be true when
c_lock == NULL, because the callback cannot be stopped then.
sy
hselasky added a comment.
Hi,
Should the callout_test module be put in a separate directory?
sys/modules/test_frwk
sys/modules/test_frwk/callout
When more tests are added that makes it easy exclude them from the build.
--HPS
REVISION DETAIL
https://reviews.freebsd.org/D1711
To: rrs, gnn, r
hselasky accepted this revision.
hselasky added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
REVISION DETAIL
https://reviews.freebsd.org/D1279
To: rodrigc, bz, hselasky
Cc: freebsd-net
___
freebsd-net@freebsd.org
90 matches
Mail list logo