julian accepted this revision.
julian added a comment.
This revision has a positive review.
as far as I can see it looks good. Same default value as before..
INLINE COMMENTS
> ng_pppoe.c:952
>* Store the originator of this message so we can send
>
julian added a comment.
Considering how much work went into writing this and the fact that we had to
get it approved by verizon (or whatever they were called at the time) its
amazing that I remember almost nothing about how it works.
INLINE COMMENTS
> ng_pppoe.4:111
> +To set a binary Host-
julian added a subscriber: julian.
julian added a comment.
in case I didn't point you at this before...
http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.txt?ac=22
REVISION DETAIL
https:
julian added a subscriber: julian.
julian added a comment.
Is the reason here to just make the lines shorter or is there a deeper reason?
(e.g. to prepare for some upcoming change)
REVISION DETAIL
https://reviews.freebsd.org/D1809
To: davide, kmacy, np, rrs, lstewart, rwatson
Cc: julian, free
julian accepted this revision.
julian added a reviewer: julian.
This revision is now accepted and ready to land.
REVISION DETAIL
https://reviews.freebsd.org/D1805
To: davide, kmacy, np, lstewart, rrs, rwatson, julian
Cc: emaste, freebsd-net
___
freebs
julian added a comment.
let me see if this is correct..
I'm assuming that the reference count can not change if you hold the lock?
if so then before releasing the lock, we can check if the count is 1.. if it is
then we are the only person who even knows where this thing is so there can't
be any
julian added a subscriber: julian.
julian added a comment.
>>! In D1711#66, @rrs wrote:
> 3) The callout_stop() on CPU 2 does what it is supposed to and sets the
> cc_cancel bit to true and
> return 1. This causes callout_stop() to lower the reference count which
> means when llentry_free(
