[Differential] D24989: netinet: Generate a random RSS key on boot.

2020-05-25 Thread melifaro (Alexander V. Chernikov)
melifaro added inline comments. INLINE COMMENTS > rss_config.c:251 >*/ > + arc4random_buf(&rss_key, RSS_KEYSIZE); > } Are we sure that there is enough entropy available at the moment of calling it? REPOSITORY rS FreeBSD src repository CHANGES SINCE LAS

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-12-17 Thread melifaro (Alexander V. Chernikov)
melifaro added inline comments. INLINE COMMENTS sys/net/if_lagg.c:728 What if we have multiple events queued on tasq? e.g mtu AND mac change sys/net/if_lagg.c:763 Not that easy, unfortunately. At this moment original ioctl returned 0, so other things/events were fired: rtsock

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-10-27 Thread melifaro (Alexander V. Chernikov)
melifaro added a subscriber: melifaro. melifaro added a comment. After digging into lagg internals on updating lladdrs on lagg ports, I'd also vote for extenging llq to deal with MTU changes for underlying interfaces REPOSITORY rS FreeBSD src repository REVISION DETAIL

Re: kern/174959: [net] [patch] rnh_walktree_from visits spurious nodes

2014-05-01 Thread melifaro
Synopsis: [net] [patch] rnh_walktree_from visits spurious nodes Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Thu May 1 14:59:13 UTC 2014 Responsible-Changed-Why: Take. http://www.freebsd.org/cgi/query-pr.cgi?pr=174

Re: kern/169664: [bgp] Wrongful replacement of interface connected net route

2013-10-14 Thread melifaro
Synopsis: [bgp] Wrongful replacement of interface connected net route State-Changed-From-To: open->closed State-Changed-By: melifaro State-Changed-When: Mon Oct 14 11:21:16 UTC 2013 State-Changed-Why: Fixed in r248070 and merge to 9-STABLE in r248895. http://www.freebsd.org/cgi/query-pr.cgi

Re: kern/169664: [bgp] Wrongful replacement of interface connected net route

2013-10-14 Thread melifaro
Synopsis: [bgp] Wrongful replacement of interface connected net route State-Changed-From-To: open->feedback State-Changed-By: melifaro State-Changed-When: Mon Oct 14 11:19:17 UTC 2013 State-Changed-Why: http://www.freebsd.org/cgi/query-pr.cgi?pr=169

Re: kern/155772: ifconfig(8): ioctl (SIOCAIFADDR): File exists on directly connected networks

2013-03-08 Thread melifaro
Synopsis: ifconfig(8): ioctl (SIOCAIFADDR): File exists on directly connected networks Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Fri Mar 8 20:45:18 UTC 2013 Responsible-Changed-Why: Take http://www.freebsd.org/cgi/query-pr.

Re: kern/168670: [vlan] [panic] BPF kernel crash

2012-06-10 Thread melifaro
Synopsis: [vlan] [panic] BPF kernel crash Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Mon Jun 11 06:17:08 UTC 2012 Responsible-Changed-Why: Take http://www.freebsd.org/cgi/query-pr.cgi?pr=168

Re: kern/161908: [netgraph] [patch] ng_vlan update for QinQ support

2011-12-03 Thread melifaro
Synopsis: [netgraph] [patch] ng_vlan update for QinQ support Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Sat Dec 3 17:23:08 UTC 2011 Responsible-Changed-Why: Take http://www.freebsd.org/cgi/query-pr.cgi?pr=161

Re: kern/155585: [tcp] [panic] tcp_output tcp_mtudisc loop until kernel panic

2011-11-03 Thread melifaro
Synopsis: [tcp] [panic] tcp_output tcp_mtudisc loop until kernel panic State-Changed-From-To: open->feedback State-Changed-By: melifaro State-Changed-When: Thu Nov 3 09:52:26 UTC 2011 State-Changed-Why: Take Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: me

Re: bin/136661: [patch] ndp(8) ignores -f option

2011-11-03 Thread melifaro
Synopsis: [patch] ndp(8) ignores -f option Responsible-Changed-From-To: freebsd-net->melifaro Responsible-Changed-By: melifaro Responsible-Changed-When: Thu Nov 3 09:49:06 UTC 2011 Responsible-Changed-Why: Take my own PR http://www.freebsd.org/cgi/query-pr.cgi?pr=136