[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius : if you have time can you review this? you have expressed interest in PF + VIMAGE fixes in the past. @bz : do you have time to review this? I understand you are going to be doing some VIMAGE work REVISION DETAIL https://reviews.freebsd.org/D1944 E

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @mmoll : It would be nice if @glebius could review this patch. He previously committed some patches I committed to FreeBSD which attempted to fix this problem, so he has an interest in this area. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. @glebius: Nikos updated the patch. Can you review it? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: farr

[Differential] [Accepted] D1944: PF and VIMAGE fixes

rodrigc accepted this revision. rodrigc added a comment. This revision has a positive review. Looks OK to me. We can hopefully fix some of the LOR's later. @glebius : can you provide your feedback on this patch? REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://r

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I can confirm that: kldunload -f pf.ko does work to unload the module. That is good. I saw this warning message in dmesg: lock order reversal: (sleepable after non-sleepable) 1st 0x823b72e0 pf rulesets (pf rulesets) @ /opt2/branches/head/sys/modules/pf

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. I tested this patch. # kldload pf # kldunload pf kldunload: can't unload file: Device busy The fact that the pf module cannot be unloaded was one of the reasons that @glebius used to back out the entire changeset last time I committed your pf changes. Can you fix

[Differential] [Commented On] D1944: PF and VIMAGE fixes

rodrigc added a comment. In https://reviews.freebsd.org/D1944#46127, @julian wrote: > in case I didn't point you at this before... > > http://p4web.freebsd.org/@md=d&cd=//depot/projects/vimage/&cdf=//depot/projects/vimage/porting_to_vimage.txt&c=win@//depot/projects/vimage/porting_to_vimage.tx

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a reviewer: kristof. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, gnn, bz, zec, trociny, glebius, rodrigc, kristof Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http:

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a comment. Nikos has posted these patches to improve VIMAGE support in PF. If some of the folks who are experienced with PF and VIMAGE could take a look, that would be really great. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, gnn, bz, zec, tro

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added a reviewer: gnn. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc, gnn Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/lis

[Differential] [Updated] D1944: PF and VIMAGE fixes

rodrigc added reviewers: bz, zec, trociny. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc, gnn, bz, zec, trociny Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http:/

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

rodrigc added a subscriber: freebsd-virtualization. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd

[Differential] [Changed Subscribers] D1944: PF and VIMAGE fixes

rodrigc added subscribers: freebsd-net, freebsd-pf. REVISION DETAIL https://reviews.freebsd.org/D1944 To: nvass-gmx.com, glebius, rodrigc Cc: freebsd-pf, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/fr

[Differential] [Closed] D1315: VIMAGE PF fixes #4

rodrigc closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1315 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, zec Cc: zec, freebsd-virtualization, freebsd-pf, freebsd-net _

[Differential] [Accepted] D1315: VIMAGE PF fixes #4

rodrigc accepted this revision. rodrigc added a reviewer: rodrigc. rodrigc added a comment. This revision is now accepted and ready to land. Committed in rS276747 REVISION DETAIL https://reviews.freebsd.org/D1315 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, a

[Differential] [Abandoned] D1313: VIMAGE PF fixes #3

rodrigc abandoned this revision. rodrigc added a comment. Committed as part of D1309 REVISION DETAIL https://reviews.freebsd.org/D1313 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, zec Cc: freebsd-virtualization, freebsd-pf, freebs

[Differential] [Abandoned] D1312: VIMAGE PF fixes #2

rodrigc abandoned this revision. rodrigc added a comment. Committed as part of D1309 REVISION DETAIL https://reviews.freebsd.org/D1312 To: rodrigc, bz, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson Cc: freebsd-pf, freebsd-virtualization, freebs

[Differential] [Closed] D1309: VIMAGE PF fixes #1

rodrigc closed this revision. rodrigc added a comment. Committed REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson Cc: freebsd-virtualization, freebsd-pf, freebsd-net __

[Differential] [Updated] D1313: VIMAGE PF fixes #3

rodrigc added a reviewer: zec. REVISION DETAIL https://reviews.freebsd.org/D1313 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, zec Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ f

[Differential] [Updated] D1312: VIMAGE PF fixes #2

rodrigc added reviewers: zec, network. REVISION DETAIL https://reviews.freebsd.org/D1312 To: rodrigc, bz, glebius, trociny, zec, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson Cc: freebsd-pf, freebsd-virtualization, freebsd-net _

[Differential] [Updated] D1309: VIMAGE PF fixes #1

rodrigc added a reviewer: zec. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, trociny, zec Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ f

[Differential] [Updated] D1315: VIMAGE PF fixes #4

rodrigc added a reviewer: zec. REVISION DETAIL https://reviews.freebsd.org/D1315 To: rodrigc, bz, glebius, trociny, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, zec Cc: zec, freebsd-virtualization, freebsd-pf, freebsd-net

[Differential] [Request, 100 lines] D1315: VIMAGE PF fixes #4

rodrigc created this revision. rodrigc added reviewers: bz, glebius, trociny, network. rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization. REVISION SUMMARY Instead of creating a purge thread for every vnet, create a single purge thread and clean up all vnets from this t

[Differential] [Request, 26 lines] D1313: VIMAGE PF fixes #3

rodrigc created this revision. rodrigc added reviewers: bz, glebius, trociny, network. rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization. REVISION SUMMARY Only register attach/detach event handlers if the current vnet is vnet0. Submitted by: Nikos Vassiliadis

[Differential] [Updated] D1312: VIMAGE PF fixes #2

rodrigc retitled this revision from "VNET PF fixes #2" to "VIMAGE PF fixes #2". REVISION DETAIL https://reviews.freebsd.org/D1312 To: rodrigc, bz, glebius, trociny Cc: freebsd-pf, freebsd-virtualization, freebsd-net ___ freebsd-net@freebsd.org mailing

[Differential] [Request, 46 lines] D1312: VNET PF fixes #2

rodrigc created this revision. rodrigc added reviewers: bz, glebius, trociny. rodrigc added subscribers: freebsd-net, freebsd-virtualization, freebsd-pf. REVISION SUMMARY Virtualize the pfr_ktables variable. Submitted by: Nikos Vassiliadis REVISION DETAIL https://reviews.freebsd.org

[Differential] [Updated] D1309: VIMAGE PF fixes #1

rodrigc added a reviewer: trociny. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, trociny Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ fr

[Differential] [Updated] D1309: VIMAGE PF fixes #1

rodrigc added a reviewer: network. REVISION DETAIL https://reviews.freebsd.org/D1309 To: rodrigc, bz, glebius, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson Cc: freebsd-virtualization, freebsd-pf, freebsd-net ___ freebsd-net

[Differential] [Request, 70 lines] D1309: VIMAGE PF fixes #1

rodrigc created this revision. rodrigc added reviewers: bz, glebius. rodrigc added subscribers: freebsd-net, freebsd-pf, freebsd-virtualization. REVISION SUMMARY Merge: r258322 from projects/pf branch - Split functions that initialize various pf parts into their vimage parts and global

[Differential] [Closed] D1279: Fix crash when VIMAGE + Infiniband is compiled into the kernel

rodrigc closed this revision. rodrigc added a comment. Committed rS275599 REVISION DETAIL https://reviews.freebsd.org/D1279 To: rodrigc, bz, hselasky Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/f

[Differential] [Updated] D1279: Fix crash when VIMAGE + Infiniband is compiled into the kernel

rodrigc updated the test plan for this revision. REVISION DETAIL https://reviews.freebsd.org/D1279 To: rodrigc, bz, hselasky Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe,

[Differential] [Request, 4 lines] D1279: Fix crash when VIMAGE + Infiniband is compiled into the kernel

rodrigc created this revision. rodrigc added reviewers: bz, hselasky. rodrigc added a subscriber: freebsd-net. REVISION SUMMARY PR: 191468 Use CURVNET macros inside inet_get_local_port_range() function. Without this fix, a kernel with VIMAGE + Infiniband will panic on bootup. Certain

[Differential] [Closed] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

rodrigc closed this revision. rodrigc added a comment. Committed in S27 REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net, emaste, gnn, rwatson __

[Differential] [Accepted] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

rodrigc accepted this revision. rodrigc added a reviewer: rodrigc. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfredperlstein, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net,

[Differential] [Updated] D1201: Allow UMA allocated memory to be freed when VNET jails are torn down.

rodrigc retitled this revision from " Allow UMA allocated memory to be freed when VNET jails are torn down." to "Allow UMA allocated memory to be freed when VNET jails are torn down.". rodrigc added a subscriber: freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1201 To: rodrigc, alfre