smh accepted this revision.
This revision has a positive review.
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, tsoome, glebius, freebsd-net-list, #network, gnn, bapt, oshogbo,
smh
Cc: smh
_
smh requested changes to this revision.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pxe.c:296
> +
> + if (dhcp_try_rfc1048(bootplayer.vendor.d,
> BOOTP_DHCPVEND) < 0 ) {
> + if (pxe_debug)
space befo
smh added a comment.
book -> bool
REVISION DETAIL
https://reviews.freebsd.org/D9847
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, oshogbo, bapt, tsoome, glebius, freebsd-net-list, #network, gnn,
smh
Cc: smh
smh added inline comments.
INLINE COMMENTS
> pxe.c:296
> +
> + if (dhcp_try_rfc1048(bootplayer.vendor.d,
> BOOTP_DHCPVEND)) {
> + if (pxe_debug)
Didn't spot this before but does this need a more explicit test as this method
returns and isn't not
smh requested changes to this revision.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pxe.c:300
> + bootp(pxe_sock, BOOTP_PXE);
> + } else if (pxe_debug)
> + printf("pxe_open:
smh requested changes to this revision.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> pxe.c:300
> + bootp(pxe_sock, BOOTP_PXE);
> + } else {
> + if (pxe_debug)
You can squash
smh requested changes to this revision.
smh added a reviewer: smh.
smh added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> bootp.h:151
> +
> +#ifndef BOOTP
> +#define BOOTP
Is this needed as it looks like its to ensure its only included once by the
_BOOTP_H_
smh added a subscriber: smh.
smh added a comment.
Some general style nits and a question re-loss of the mtu set error.
INLINE COMMENTS
sys/net/if_lagg.c:706 style(9) bool use of pointer type.
sys/net/if_lagg.c:731 style(9) four space additional indent only should be
used, more below.
sy
