wblock added a comment.
Man page changes look good to me. Please remember to bump .Dd. Thanks!
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: ale, #manpages, wb
wblock accepted this revision.
wblock added a comment.
This revision has a positive review.
One suggestion, but looks good otherwise. Thank you!
INLINE COMMENTS
> ng_pppoe.4:115
> +.Qq Li 0x ,
> +eg.
> +.Qq Li 0x6d792d746167
Would prefer "like" or "for example" to exempli gratia here (see
wblock added inline comments.
INLINE COMMENTS
> ng_pppoe.4:108
> +It is possible to request a connection to a specific access concentrator,
> +and/or set a specific host uniq tag, required by some Internet providers,
> +using the "[AC-Name\\][Host-Uniq|]Service-Name" syntax.
"host uniq" should b
wblock added a comment.
Man page looks pretty good, thanks!
REVISION DETAIL
https://reviews.freebsd.org/D1438
To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn,
rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude,
wblock
Cc: wblock, free
wblock added inline comments.
INLINE COMMENTS
share/man/man9/timeout.9:98 Missing the word "if".
share/man/man9/timeout.9:126 British->American: s/behaviour/behavior/
share/man/man9/timeout.9:140 Add comma after "zero".
share/man/man9/timeout.9:295 Use "cannot". "can not" with a space mea
wblock added a reviewer: doc.
REVISION DETAIL
https://reviews.freebsd.org/D1438
To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn,
rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude,
wblock
Cc: wblock, freebsd-net
___
wblock added a subscriber: wblock.
wblock added a comment.
This is as much as I have time for at the moment. I'll add doc to the
reviewers list
INLINE COMMENTS
share/man/man9/timeout.9:73 That is kind of a difficult sentence to parse.
Does this retain the meaning?
API is used to schedu
