[Bug 200323] BPF userland misuse can crash the system

2015-08-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Luiz Otavio O Souza,+55 (14) 99772-1255 changed: What|Removed |Added Status|Open|Closed

[Bug 200323] BPF userland misuse can crash the system

2015-08-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #23 from commit-h...@freebsd.org --- A commit references this bug: Author: loos Date: Mon Aug 17 19:06:15 UTC 2015 New revision: 286859 URL: https://svnweb.freebsd.org/changeset/base/286859 Log: MFC r286260: Remove the mt

[Bug 200323] BPF userland misuse can crash the system

2015-08-03 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #22 from commit-h...@freebsd.org --- A commit references this bug: Author: loos Date: Mon Aug 3 22:14:46 UTC 2015 New revision: 286260 URL: https://svnweb.freebsd.org/changeset/base/286260 Log: Remove the mtx_sleep() from th

[Bug 200323] BPF userland misuse can crash the system

2015-07-31 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #21 from Luiz Otavio O Souza,+55 (14) 99772-1255 --- (In reply to Guy Helmer from comment #20) I studied this code (a lot) and found that some of sleeps are unnecessary. The cases we have to protect are: setting a new filter,

[Bug 200323] BPF userland misuse can crash the system

2015-07-30 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Guy Helmer changed: What|Removed |Added CC||ghel...@freebsd.org --- Comment #20 f

[Bug 200323] BPF userland misuse can crash the system

2015-07-30 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Luiz Otavio O Souza,+55 (14) 99772-1255 changed: What|Removed |Added Resolution|FIXED |---

[Bug 200323] BPF userland misuse can crash the system

2015-06-29 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Ermal Luçi changed: What|Removed |Added Resolution|--- |FIXED Status|Open

[Bug 200323] BPF userland misuse can crash the system

2015-06-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Oliver Pinter changed: What|Removed |Added Flags||mfc-stable10+ --- Comment #18 from

[Bug 200323] BPF userland misuse can crash the system

2015-06-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #17 from Franco Fichtner --- Ah, wasn't picked up by "PR:" in commit message, I see. My bad. Close this ticket then? :) -- You are receiving this mail because: You are the assignee for the bug.

[Bug 200323] BPF userland misuse can crash the system

2015-06-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #16 from Oliver Pinter --- This is already done in 10-STABLE: https://github.com/freebsd/freebsd/commit/5d11dcc72032e3027520c3aa2ffb5905115760e7 -- You are receiving this mail because: You are the assignee for the bug. ___

[Bug 200323] BPF userland misuse can crash the system

2015-06-28 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #15 from Franco Fichtner --- MFC still pending. Having this in 10.2 would be awesome. :) -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@fr

[Bug 200323] BPF userland misuse can crash the system

2015-06-17 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #14 from commit-h...@freebsd.org --- A commit references this bug: Author: eri Date: Wed Jun 17 12:23:05 UTC 2015 New revision: 284512 URL: https://svnweb.freebsd.org/changeset/base/284512 Log: If there is a system with a bpf

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #13 from Franco Fichtner --- Looks good now, thanks Ermal. :) -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list http:

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What|Removed |Added Status|New |Open URL|

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #12 from Ermal Luçi --- Moved to https://reviews.freebsd.org/D2828 -- You are receiving this mail because: You are the assignee for the bug. ___ freebsd-net@freebsd.org mailing list

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #11 from Ermal Luçi --- (In reply to Kubilay Kocak from comment #10) Ok i am posting this to phabricator since i am a freebsd developer :) Just for the reference here is another iteration of the patch diff --git a/sys/netinet/

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What|Removed |Added CC||ko...@freebsd.org --- Comment #10

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #9 from Franco Fichtner --- The previous code in place before the "bad" revision in 2008 accessed la, made its changes and called arprequest() after releasing the lock, like the other code block still does. You can maybe set a

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #8 from Ermal Luçi --- (In reply to Franco Fichtner from comment #7) Oh you refer to the decrement of the la preempt value. Yeah but i highly dislike unlock and relock again code paths, that can be a solution. Or moving this to

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #7 from Franco Fichtner --- You read a value from a lock-protected entity, you acquire a (read) lock. You write a value to a lock-protected entity, you acquire a (write) lock. After the patch, there is neither. Do you want to

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #6 from Ermal Luçi --- (In reply to Franco Fichtner from comment #4) Yeah but its a very quick read to me which does not create any race of sort from what i could tell. For sure la will be there when the fields are accessed. --

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #5 from Franco Fichtner --- https://github.com/freebsd/freebsd/commit/ec826ad5c7f97de814529d3b3bae7950f91d9a5d#diff-e08033318b7a3c6cc3ffb3e431a0f8f2L461 vs. https://github.com/freebsd/freebsd/commit/ec826ad5c7f97de814529d3b3bae7

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #4 from Franco Fichtner --- la is being read and modified after unlock with the attached patch. Though it looks like arprequest() may indeed work as expected without the lock held. Not sure if unlock/lock around arprequest is

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #3 from Ermal Luçi --- Here is a patch against HEAD of FreeBSD. Also take a look at this link for a trace https://redmine.pfsense.org/issues/4685 If its ok with you Andrey i would like to commit this one. diff --git a/sys/net

[Bug 200323] BPF userland misuse can crash the system

2015-06-15 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Andrey V. Elsukov changed: What|Removed |Added CC||a...@freebsd.org --- Comment #

[Bug 200323] BPF userland misuse can crash the system

2015-06-14 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What|Removed |Added Keywords||needs-qa, patch -- You are receiv

[Bug 200323] BPF userland misuse can crash the system

2015-06-13 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #1 from Ermal Luçi --- This patch fixes the issue and the issue seems to a locked LLE which does not allow BPF to sleep when it needs to. +diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c +index baa9c26..f31576d 100

[Bug 200323] BPF userland misuse can crash the system

2015-05-20 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Mark Linimon changed: What|Removed |Added Assignee|freebsd-b...@freebsd.org|freebsd-net@FreeBSD.org -- You are