https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
--- Comment #8 from Konstantin Belousov ---
(In reply to White Knight from comment #7)
The patch is mostly fine. I do not see a need in the casts to uint32_t in
sctp_sysctl_handle_assoclist(), the normal promotion rules
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Alfred Perlstein changed:
What|Removed |Added
Assignee|freebsd-net@FreeBSD.org
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
White Knight changed:
What|Removed |Added
Attachment #162281|0 |1
is
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Konstantin Belousov changed:
What|Removed |Added
CC|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
--- Comment #4 from White Knight ---
(In reply to Konstantin Belousov from comment #3)
Is there another consumer of that structure than netstat?
Can you suggest how to change the structure and maintain the ABI?
--
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
--- Comment #6 from Alfred Perlstein ---
The correct way would be to retain the field as-is but rename it to "_old".
Then add a field with the correct width.
Then when exporting the field make sure to continue to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
--- Comment #5 from Konstantin Belousov ---
(In reply to White Knight from comment #4)
I have no idea about any users of the structure, I am only sure that it was
written with intent of keeping its ABI.
The extra_padding
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Chris Hutchinson changed:
What|Removed |Added
CC|
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Kubilay Kocak changed:
What|Removed |Added
Keywords||needs-qa,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Sean Bruno changed:
What|Removed |Added
CC||g...@freebsd.org,
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922
Garrett Cooper,425-314-3911 changed:
What|Removed |Added
CC|
11 matches
Mail list logo