hselasky added a reviewer: jfvogel.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rrs, glebius, gnn, emaste, lstewart, rwatson, bz, imp, np,
adrian, jfvogel
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rrs, glebius, gnn, emaste, lstewart, rwatson, bz, imp, np,
adrian, jfvogel
Cc: freebsd-net
___
imp added a comment.
Except for the signed / unsigned issue, I like this change. However, please get
approval from some of the networking guys before committing.
INLINE COMMENTS
sys/netinet/ip_input.c:1450 Shouldn't this be unsigned?
sys/netinet/ip_output.c:129 shouldn't this be unsigned?
bz added a comment.
I have raised my concerns about the change a few weeks ago elsewhere already
but gnn mentioned a possible idea today to keep it clean(er). I'll let him
follow-up here.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste,
adrian added a comment.
Hi,
My main concern with this patch is the special casing of what is the packet
length being sprinkled all throughout the code. It feels like we could be
chasing down obscure is this the right length for this kind of packet bugs
for quite some time.
Is there any way
rwatson added a comment.
Historically, I believe that we've allowed additional trailer content/padding
to be included at the end of mbuf chains that isn't in the IP datagram, and is
silently ignored, as it isn't included in the IP packet length. I may
misunderstand what was going on there, but
hselasky set the repository for this revision to rS (FreeBSD src repository).
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, bz, adrian, rwatson, imp
Cc: freebsd-net
___
freebsd-net@freebsd.org
hselasky added a reviewer: imp.
REVISION DETAIL
https://reviews.freebsd.org/D1761
To: hselasky, rmacklem, rrs, glebius, gnn, emaste, bz, adrian, rwatson, imp
Cc: freebsd-net
___
freebsd-net@freebsd.org mailing list
