[Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency

gallatin added inline comments. INLINE COMMENTS > iflib.c:590 > +int iflib_tx_update_freq = IFLIB_DEFAULT_TX_UPDATE_FREQ; > +SYSCTL_UINT(_net_iflib, OID_AUTO, tx_update_freq, CTLFLAG_RW, > +&iflib_tx_update_freq, IFLIB_DEFAULT_TX_UPDATE_FREQ, Can you please make this a tunable as

[Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency

aleksandr.fedorov_itglobal.com added inline comments. INLINE COMMENTS > iflib.c:2916 > > #define TXD_NOTIFY_COUNT(txq) (((txq)->ift_size / (txq)->ift_update_freq)-1) > static inline qidx_t I am worried that if the user sets the value to 1, then this will lead to division by zero and to kern

[Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency

koobs added a comment. In D24937#560621 , @neel_neelc.org wrote: > I have a new patch making net.iflib.tx_update_freq a sysctl. I attempted to net.iflib.tx_update_freq=32 from 16 (without rebooting!) and it worked. > > Luckily with a brand-n

[Differential] D24937: Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency

neel_neelc.org updated this revision to Diff 73493. neel_neelc.org retitled this revision from "Add readonly tunable net.iflib.tx_update_freq to set transmit descriptor update frequency" to "Add sysctl net.iflib.tx_update_freq to set transmit descriptor update frequency". neel_neelc.org edited th