[Differential] D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages

2019-01-06 Thread s3erios_gmail.com (Andriy Voskoboinyk)
s3erios_gmail.com added a reviewer: s3erios_gmail.com. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D5165/new/ REVISION DETAIL https://reviews.freebsd.org/D5165 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/

[Differential] D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages

2019-01-06 Thread s3erios_gmail.com (Andriy Voskoboinyk)
s3erios_gmail.com added a comment. Hi! Actually, the code tries to find a 'next' (fallback) rate, which will be used if transmission on the current rate fails; the code will be incorrect, when HT support will be added to the driver (but currently it should 'just work'). rix is the '

[Differential] D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages

2019-01-07 Thread bz (Bjoern A. Zeeb)
bz added a comment. Depending on the outcome here, it look like bwi will need similar treatment? REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D5165/new/ REVISION DETAIL https://reviews.freebsd.org/D5165 EMAIL PREFERENCES https://reviews.

[Differential] D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages

2019-01-07 Thread bz (Bjoern A. Zeeb)
bz added a comment. Ok looks like bwi doesn't need. I don't know too much about bwn(4). Given we have hard coded mapping tables with a limited set of 'rates' according to bwn_hwrate2ieeerate() and bwn_ieeerate2hwrate() would it make sense to manually code a "one lower than this" table?

[Differential] D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages

2019-01-07 Thread adrian (Adrian Chadd)
adrian added a comment. Yeah, we should have a fallback rate function in net80211. Why? Just to make sure that you're using the previously /negotiated/ rate, all the way back down to the lowest basic rate. Eg, you may not actually be allowed to use CCK 1Mbit rate according to the AP.