Marko Zec wrote this message on Fri, Jul 17, 2020 at 23:54 +0200:
> On Fri, 17 Jul 2020 11:56:09 -0700
> John-Mark Gurney wrote:
> > Marko Zec wrote this message on Fri, Jul 17, 2020 at 12:03 +0200:
> ...
> > > #define IFQ_DRV_IS_EMPTY(ifq) \
> > > (((ifq)->ifq_drv_len == 0) && ((ifq)->ifq_len
On Fri, 17 Jul 2020 11:56:09 -0700
John-Mark Gurney wrote:
> Marko Zec wrote this message on Fri, Jul 17, 2020 at 12:03 +0200:
...
> > #define IFQ_DRV_IS_EMPTY(ifq) \
> > (((ifq)->ifq_drv_len == 0) && ((ifq)->ifq_len == 0))
> >
> > So, if per altq(9) the contract is that with IFQ_DRV_* the if
Marko Zec wrote this message on Fri, Jul 17, 2020 at 12:03 +0200:
> On Thu, 16 Jul 2020 11:56:29 -0700
> John-Mark Gurney wrote:
>
> > Marko Zec wrote this message on Thu, Jul 16, 2020 at 07:49 +0200:
> > > On Thu, 16 Jul 2020 07:26:22 +0200
> > > Marko Zec wrote:
> > >
> > > > On Wed, 15 Jul
On Thu, 16 Jul 2020 11:56:29 -0700
John-Mark Gurney wrote:
> Marko Zec wrote this message on Thu, Jul 16, 2020 at 07:49 +0200:
> > On Thu, 16 Jul 2020 07:26:22 +0200
> > Marko Zec wrote:
> >
> > > On Wed, 15 Jul 2020 16:26:25 -0700
> > > John-Mark Gurney wrote:
> > >
> > > > I happen to b
Marko Zec wrote this message on Thu, Jul 16, 2020 at 07:49 +0200:
> On Thu, 16 Jul 2020 07:26:22 +0200
> Marko Zec wrote:
>
> > On Wed, 15 Jul 2020 16:26:25 -0700
> > John-Mark Gurney wrote:
> >
> > > I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
> > > unlike IFQ_DRV_DEQU
On Thu, 16 Jul 2020 07:26:22 +0200
Marko Zec wrote:
> On Wed, 15 Jul 2020 16:26:25 -0700
> John-Mark Gurney wrote:
>
> > I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
> > unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating
> > the ifq. I took a brief loo
On Wed, 15 Jul 2020 16:26:25 -0700
John-Mark Gurney wrote:
> I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
> unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating
> the ifq. I took a brief look at a few drivers, and it looks like some
> of them expect that _
I happen to be looking at the implementation of IFQ_DRV_PREPEND, and
unlike IFQ_DRV_DEQUEUE, it doesn't obtain the lock when manipulating
the ifq. I took a brief look at a few drivers, and it looks like some
of them expect that _PREPEND lock the Q like _DEQUEUE does.
This is likely not an issue o
