Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-21 Thread Mark Johnston
On Mon, Apr 20, 2020 at 04:39:07PM -0700, Eric Joyner wrote: > On Thu, Apr 9, 2020 at 2:29 PM Eric Joyner wrote: > > > On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > > > >> On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > >> > >>> I spent some time looking at the core. It looks like

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-20 Thread Eric Joyner
On Thu, Apr 9, 2020 at 2:29 PM Eric Joyner wrote: > On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > >> On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: >> >>> I spent some time looking at the core. It looks like we have yet >>> another problem: the gtaskqueue code won't exit the net epo

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-09 Thread Eric Joyner
On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > >> On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: >> > On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: >> > >> > > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wr

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-09 Thread Eric Joyner
On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: > > On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: > > > > > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > > > > Mark, > > > > > > > > I think I was mistaken a

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-07 Thread Hans Petter Selasky
On 2020-04-08 01:23, Mark Johnston wrote: On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: Mark, I think I was mistaken about the backtrace looking the same. I was l

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-07 Thread Mark Johnston
On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: > On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: > > > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > > > Mark, > > > > > > I think I was mistaken about the backtrace looking the same. I was > > looking > > > at it

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-06 Thread Eric Joyner
On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > > Mark, > > > > I think I was mistaken about the backtrace looking the same. I was > looking > > at it from within ddb, and I think I focused on the > > epoch_block_handler_preempt

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-06 Thread Mark Johnston
On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > Mark, > > I think I was mistaken about the backtrace looking the same. I was looking > at it from within ddb, and I think I focused on the > epoch_block_handler_preempt line and didn't notice that it only stopped > there this time. Her

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-06 Thread Eric Joyner
On Tue, Mar 31, 2020 at 12:28 PM Mark Johnston wrote: > On Tue, Mar 31, 2020 at 12:14:20PM -0700, Eric Joyner wrote: > > Mark, > > > > I tried out a kernel with the tip of CURRENT with both D24214 and D24215 > > applied, and I still see the problem. As well, after doing a "sysctl > > debug.kdb.en

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-31 Thread Mark Johnston
On Tue, Mar 31, 2020 at 12:14:20PM -0700, Eric Joyner wrote: > Mark, > > I tried out a kernel with the tip of CURRENT with both D24214 and D24215 > applied, and I still see the problem. As well, after doing a "sysctl > debug.kdb.enter=1" and viewing the stack trace there for kldunload, it > appear

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-31 Thread Eric Joyner
Mark, I tried out a kernel with the tip of CURRENT with both D24214 and D24215 applied, and I still see the problem. As well, after doing a "sysctl debug.kdb.enter=1" and viewing the stack trace there for kldunload, it appears to be similar to the one I posted in my last post. - Eric On Mon, Mar

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-30 Thread Eric Joyner
On Sat, Mar 28, 2020 at 3:52 PM Mark Johnston wrote: > On Wed, Mar 11, 2020 at 04:32:40PM -0700, Eric Joyner wrote: > > Mark, > > > > I did get some time to get back and retry this; however your second patch > > still doesn't solve the problem. Looking into it a bit, it looks like the > > kldunlo

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-28 Thread Mark Johnston
On Wed, Mar 11, 2020 at 04:32:40PM -0700, Eric Joyner wrote: > Mark, > > I did get some time to get back and retry this; however your second patch > still doesn't solve the problem. Looking into it a bit, it looks like the > kldunload process isn't hitting the code you've changed; it's hanging in

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-11 Thread Eric Joyner
On Wed, Feb 12, 2020 at 2:22 PM Mark Johnston wrote: > On Mon, Feb 10, 2020 at 01:30:47PM -0800, Eric Joyner wrote: > > On Fri, Jan 31, 2020 at 11:44 AM Eric Joyner wrote: > > > Hi Mark, > > > > > > I applied your patch to a FreeBSD-current VM and reran the test I was > > > running originally, a

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-02-12 Thread Mark Johnston
On Mon, Feb 10, 2020 at 01:30:47PM -0800, Eric Joyner wrote: > On Fri, Jan 31, 2020 at 11:44 AM Eric Joyner wrote: > > Hi Mark, > > > > I applied your patch to a FreeBSD-current VM and reran the test I was > > running originally, and I still see the same behavior. > > > > Your patch doesn't appear

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-02-10 Thread Eric Joyner
On Fri, Jan 31, 2020 at 11:44 AM Eric Joyner wrote: > On Wed, Jan 29, 2020 at 7:09 PM Mark Johnston wrote: > >> On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: >> > On 2020-01-29 22:44, Eric Joyner wrote: >> > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky >> wrote:

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-31 Thread Eric Joyner
On Wed, Jan 29, 2020 at 7:09 PM Mark Johnston wrote: > On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: > > On 2020-01-29 22:44, Eric Joyner wrote: > > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > > > > > On 2020-01-29 22:30, Eric Joyner wrote: > > > >

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Mark Johnston
On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: > On 2020-01-29 22:44, Eric Joyner wrote: > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > > wrote: > > > > > On 2020-01-29 22:30, Eric Joyner wrote: > > > > Hi freebsd-net, > > > > > > > > We've encountered an issue

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
On Wed, Jan 29, 2020 at 5:12 PM Hans Petter Selasky wrote: > On 2020-01-29 22:44, Eric Joyner wrote: > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > >> On 2020-01-29 22:30, Eric Joyner wrote: > >>> Hi freebsd-net, > >>> > >>> We've encountered an issue with unloading the i

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Hans Petter Selasky
On 2020-01-29 22:44, Eric Joyner wrote: On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: On 2020-01-29 22:30, Eric Joyner wrote: Hi freebsd-net, We've encountered an issue with unloading the iavf(4) driver on FreeBSD 12.1 (and stable). On a VM with two iavf(4) interfaces, if we sen

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: > On 2020-01-29 22:30, Eric Joyner wrote: > > Hi freebsd-net, > > > > We've encountered an issue with unloading the iavf(4) driver on FreeBSD > > 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy > > traffic to iavf

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Hans Petter Selasky
On 2020-01-29 22:30, Eric Joyner wrote: Hi freebsd-net, We've encountered an issue with unloading the iavf(4) driver on FreeBSD 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy traffic to iavf1 and try to kldunload the driver, the kldunload process hangs on iavf0 until ia

Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
Hi freebsd-net, We've encountered an issue with unloading the iavf(4) driver on FreeBSD 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy traffic to iavf1 and try to kldunload the driver, the kldunload process hangs on iavf0 until iavf1 stops receiving traffic. After some d