Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-25 Thread Bruce Evans
On Wed, 24 Sep 2008 [EMAIL PROTECTED] wrote: At Wed, 24 Sep 2008 12:53:31 -0700, John-Mark Gurney wrote: George V. Neville-Neil wrote this message on Tue, Sep 23, 2008 at 15:29 -0400: It turns out that the last time anyone looked at this constant was before 1994 and it's very likely time to t

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread Julian Elischer
[EMAIL PROTECTED] wrote: At Wed, 24 Sep 2008 12:53:31 -0700, John-Mark Gurney wrote: George V. Neville-Neil wrote this message on Tue, Sep 23, 2008 at 15:29 -0400: It turns out that the last time anyone looked at this constant was before 1994 and it's very likely time to turn it into a kernel t

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread gnn
At Wed, 24 Sep 2008 12:53:31 -0700, John-Mark Gurney wrote: > > George V. Neville-Neil wrote this message on Tue, Sep 23, 2008 at 15:29 -0400: > > It turns out that the last time anyone looked at this constant was > > before 1994 and it's very likely time to turn it into a kernel > > tunable. On

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread John-Mark Gurney
George V. Neville-Neil wrote this message on Tue, Sep 23, 2008 at 15:29 -0400: > It turns out that the last time anyone looked at this constant was > before 1994 and it's very likely time to turn it into a kernel > tunable. On hosts that have a high rate of packet transmission > packets can be dro

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread gnn
At Wed, 24 Sep 2008 15:50:32 +0100, Bruce M. Simpson wrote: > > Hi, > > I agree with the intent of the change that IPv4 and IPv6 input queues > should have a tunable queue length. However, the change provided is > going to make the definition of IFQ_MAXLEN global and dependent upon a > variabl

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread Bruce M. Simpson
[EMAIL PROTECTED] wrote: ... I found no occurrences of the above in our code base. I used cscope to search all of src/sys. Are you aware of any occurrences of this? I have been using IFQ_MAXLEN to size buffer queues internal to some IGMPv3 stuff. I don't feel comfortable with a change w

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-24 Thread Bruce M. Simpson
Hi, I agree with the intent of the change that IPv4 and IPv6 input queues should have a tunable queue length. However, the change provided is going to make the definition of IFQ_MAXLEN global and dependent upon a variable. [EMAIL PROTECTED] wrote: Hi, It turns out that the last time anyone

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-23 Thread gnn
At Wed, 24 Sep 2008 00:17:18 +0400, Ruslan Ermilov wrote: > > Hi, > > On Tue, Sep 23, 2008 at 03:29:06PM -0400, [EMAIL PROTECTED] wrote: > > It turns out that the last time anyone looked at this constant was > > before 1994 and it's very likely time to turn it into a kernel > > tunable. On hosts

Re: Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-23 Thread Ruslan Ermilov
Hi, On Tue, Sep 23, 2008 at 03:29:06PM -0400, [EMAIL PROTECTED] wrote: > It turns out that the last time anyone looked at this constant was > before 1994 and it's very likely time to turn it into a kernel > tunable. On hosts that have a high rate of packet transmission > packets can be dropped at

Proposed patch, convert IFQ_MAXLEN to kernel tunable...

2008-09-23 Thread gnn
Hi, It turns out that the last time anyone looked at this constant was before 1994 and it's very likely time to turn it into a kernel tunable. On hosts that have a high rate of packet transmission packets can be dropped at the interface queue because this value is too small. Rather than make a s