Re: igb and ALTQ in 9.1-rc3

2013-04-04 Thread Barney Cordoba
--- On Tue, 4/2/13, Adrian Chadd wrote: > From: Adrian Chadd > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Nick Rogers" > Cc: "Karim Fodil-Lemelin" , > "freebsd-net@freebsd.org" > Date: Tuesday, April 2, 2013, 6:39 PM > Yes: > >

Re: igb and ALTQ in 9.1-rc3

2013-04-04 Thread Barney Cordoba
ty as to how to make the driver better is particularly troubling. So I just have to recommend that igb cards not be used for production flows, because there is little hope that it will improve any time soon. BC --- On Sun, 3/31/13, Adrian Chadd wrote: > From: Adrian Chadd > Subject: Re:

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tue, Apr 2, 2013 at 3:39 PM, Adrian Chadd wrote: > Yes: > > * you need to add it to conf/options - see if there's an opt_igb.h to > add it to, otherwise you'll need to add one; > * Make sure the driver code includes opt_igb.h; > * Then make sure you make kernel modules using either make buildke

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Adrian Chadd
Yes: * you need to add it to conf/options - see if there's an opt_igb.h to add it to, otherwise you'll need to add one; * Make sure the driver code includes opt_igb.h; * Then make sure you make kernel modules using either make buildkernel KERNCONF=X, or you set the environment appropriately so the

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tue, Apr 2, 2013 at 1:59 PM, Karim Fodil-Lemelin wrote: > Hi Nick, > > Thanks for the testing, I am glad I could help. Please note that by setting: > > > static int igb_num_queues = 1; > > You are effectively only using 1 TX queue from the hardware (instead of 4 or > 8) so this might not be app

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Karim Fodil-Lemelin
Hi Nick, Thanks for the testing, I am glad I could help. Please note that by setting: static int igb_num_queues = 1; You are effectively only using 1 TX queue from the hardware (instead of 4 or 8) so this might not be applicable to a generic kernel without ALTQ. Best regards, Karim. On 02/

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tue, Apr 2, 2013 at 9:17 AM, Nick Rogers wrote: > On Tue, Apr 2, 2013 at 7:47 AM, Karim Fodil-Lemelin > wrote: >> Hi Nick, >> >> Unfortunately I do not have a FBSD 9 box around where I can compile and test >> this so bear with me as this is pretty much straight out of looking at the >> source

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tue, Apr 2, 2013 at 7:47 AM, Karim Fodil-Lemelin wrote: > Hi Nick, > > Unfortunately I do not have a FBSD 9 box around where I can compile and test > this so bear with me as this is pretty much straight out of looking at the > source code directly (i.e it might not even compile). > > But if you

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tue, Apr 2, 2013 at 7:20 AM, Karim Fodil-Lemelin wrote: > Hi Nick, > > You need to set the ALTQF_READY flag inside the igb driver. Make sure you > have something like this in if_igb.c: > > ifp->if_start = igb_start; > IFQ_SET_MAXLEN(&ifp->if_snd, adapter->num_tx_desc - 1); > ifp->if

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Karim Fodil-Lemelin
Hi Nick, Unfortunately I do not have a FBSD 9 box around where I can compile and test this so bear with me as this is pretty much straight out of looking at the source code directly (i.e it might not even compile). But if your desperate please try the following (untested) patch (applied to s

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Karim Fodil-Lemelin
Hi Nick, You need to set the ALTQF_READY flag inside the igb driver. Make sure you have something like this in if_igb.c: ifp->if_start = igb_start; IFQ_SET_MAXLEN(&ifp->if_snd, adapter->num_tx_desc - 1); ifp->if_snd.ifq_drv_maxlen = adapter->num_tx_desc - 1; IFQ_SET_READY(&ifp-

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Nick Rogers
On Tuesday, April 2, 2013, Karim Fodil-Lemelin wrote: > Hi Nick, > > Can you verify that you have at least one of those options in your kernel > config file: > > ALTQ_CBQ > ALTQ_PRIQ > ALTQ_HFSC Yes I have hfsc included in the kernel. I have other machines using altq with em(4) interfaces and si

Re: igb and ALTQ in 9.1-rc3

2013-04-02 Thread Karim Fodil-Lemelin
Hi Nick, Can you verify that you have at least one of those options in your kernel config file: ALTQ_CBQ ALTQ_PRIQ ALTQ_HFSC Regards, Karim. On 01/04/2013 8:22 PM, Nick Rogers wrote: On Mon, Apr 1, 2013 at 8:44 AM, Karim Fodil-Lemelin wrote: Hi Jack, I think this would help M. Rogers ca

Re: igb and ALTQ in 9.1-rc3

2013-04-01 Thread Nick Rogers
On Mon, Apr 1, 2013 at 8:44 AM, Karim Fodil-Lemelin wrote: > Hi Jack, > > I think this would help M. Rogers case as we have done something similar > here to circumvent the issue and it seems to work well. I would also add > that when using ALTQ we found it much more stable to set the number of > q

Re: igb and ALTQ in 9.1-rc3

2013-04-01 Thread Karim Fodil-Lemelin
Hi Jack, I think this would help M. Rogers case as we have done something similar here to circumvent the issue and it seems to work well. I would also add that when using ALTQ we found it much more stable to set the number of queues to 1: static int igb_num_queues = 1; Our approach consiste

Re: igb and ALTQ in 9.1-rc3

2013-03-31 Thread Adrian Chadd
gt; multiple cards when you havemore queues than you have physical cpus? > What made you decide to use buf_ring? Something new to play with? > I'm guessing that you have no idea. > BC--- On Fri, 3/29/13, Jack Vogel wrote: > > From: Jack Vogel > Subject: Re: igb and ALTQ in 9.

Re: igb and ALTQ in 9.1-rc3

2013-03-31 Thread Barney Cordoba
--- On Fri, 3/29/13, Adrian Chadd wrote: > From: Adrian Chadd > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Nick Rogers" > Cc: "Pieper, Jeffrey E" , > "freebsd-net@freebsd.org" , "Clement Hermann > (nodens)" , "Jack Vogel&quo

Re: igb and ALTQ in 9.1-rc3

2013-03-31 Thread Barney Cordoba
ng? Something new to play with? I'm guessing that you have no idea. BC--- On Fri, 3/29/13, Jack Vogel wrote: From: Jack Vogel Subject: Re: igb and ALTQ in 9.1-rc3 To: "Pieper, Jeffrey E" Cc: "Barney Cordoba" , "Nick Rogers" , "freebsd-net@freebsd.org"

Re: igb and ALTQ in 9.1-rc3

2013-03-31 Thread Barney Cordoba
developer would do. Or are you just hurling insults because you're devoid of actual ideas? BC --- On Fri, 3/29/13, Scott Long wrote: > From: Scott Long > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Barney Cordoba" > Cc: "Nick Rogers" , "Adrian Chad

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Adrian Chadd
On 29 March 2013 10:04, Nick Rogers wrote: > Multiqueue or not, I would appreciate any help with this thread's > original issue. Whether or not its the ideal thing to do, I cannot > simply just replace the NICs with an em(4) variant, as I have hundreds > of customers/systems already in productio

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Nick Rogers
age- >> From: owner-freebsd-...@freebsd.org [mailto:owner-freebsd-...@freebsd.org] >> On Behalf Of Barney Cordoba >> Sent: Friday, March 29, 2013 5:51 AM >> To: Jack Vogel; Nick Rogers >> Cc: freebsd-net@freebsd.org; Clement Hermann (nodens) >> Subject: Re:

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Scott Long
more than a patch. It needs to be completely re-thunk > > --- On Fri, 3/29/13, Adrian Chadd wrote: > > From: Adrian Chadd > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Barney Cordoba" > Cc: "Jack Vogel" , "Nick Rogers" , > "Jeffrey

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Barney Cordoba
it needs a lot more than a patch. It needs to be completely re-thunk --- On Fri, 3/29/13, Adrian Chadd wrote: From: Adrian Chadd Subject: Re: igb and ALTQ in 9.1-rc3 To: "Barney Cordoba" Cc: "Jack Vogel" , "Nick Rogers" , "Jeffrey EPieper" , "

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Jack Vogel
ogel; Nick Rogers > Cc: freebsd-net@freebsd.org; Clement Hermann (nodens) > Subject: Re: igb and ALTQ in 9.1-rc3 > > > > --- On Thu, 3/28/13, Nick Rogers wrote: > > > From: Nick Rogers > > Subject: Re: igb and ALTQ in 9.1-rc3 > > To: "Jack Vogel" >

RE: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Barney Cordoba
--- On Fri, 3/29/13, Pieper, Jeffrey E wrote: > From: Pieper, Jeffrey E > Subject: RE: igb and ALTQ in 9.1-rc3 > To: "Barney Cordoba" , "Jack Vogel" > , "Nick Rogers" > Cc: "freebsd-net@freebsd.org" , "Clement He

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Adrian Chadd
Barney, Patches gratefully accepted. Adrian On 29 March 2013 08:54, Barney Cordoba wrote: > > > --- On Fri, 3/29/13, Pieper, Jeffrey E wrote: > > > From: Pieper, Jeffrey E > > Subject: RE: igb and ALTQ in 9.1-rc3 > > To: "Barney Cordoba" , &q

RE: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Barney Cordoba
--- On Fri, 3/29/13, Pieper, Jeffrey E wrote: > From: Pieper, Jeffrey E > Subject: RE: igb and ALTQ in 9.1-rc3 > To: "Barney Cordoba" , "Jack Vogel" > , "Nick Rogers" > Cc: "freebsd-net@freebsd.org" , "Clement He

RE: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Pieper, Jeffrey E
-Original Message- From: owner-freebsd-...@freebsd.org [mailto:owner-freebsd-...@freebsd.org] On Behalf Of Barney Cordoba Sent: Friday, March 29, 2013 5:51 AM To: Jack Vogel; Nick Rogers Cc: freebsd-net@freebsd.org; Clement Hermann (nodens) Subject: Re: igb and ALTQ in 9.1-rc3 --- On

Re: igb and ALTQ in 9.1-rc3

2013-03-29 Thread Barney Cordoba
--- On Thu, 3/28/13, Nick Rogers wrote: > From: Nick Rogers > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Jack Vogel" > Cc: "Barney Cordoba" , "Clement Hermann (nodens)" > , "freebsd-net@freebsd.org" > Date: Thursday, March 28, 201

Re: igb and ALTQ in 9.1-rc3

2013-03-28 Thread Nick Rogers
On Thu, Mar 28, 2013 at 4:16 PM, Jack Vogel wrote: > Have been kept fairly busy with other matters, one thing I could do short > term is > change the defines in igb the way I did in the em driver so you could still > define > the older if_start entry. Right now those are based on OS version and so

Re: igb and ALTQ in 9.1-rc3

2013-03-28 Thread Jack Vogel
Have been kept fairly busy with other matters, one thing I could do short term is change the defines in igb the way I did in the em driver so you could still define the older if_start entry. Right now those are based on OS version and so you will automatically get if_transmit, but I could change it

Re: igb and ALTQ in 9.1-rc3

2013-03-28 Thread Nick Rogers
On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel wrote: > On Mon, Dec 10, 2012 at 11:58 PM, Gleb Smirnoff wrote: > >> On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: >> J> UH, maybe asking the owner of the driver would help :) >> J> >> J> ... and no, I've never been aware of doing anything

Re: igb and ALTQ in 9.1-rc3

2012-12-12 Thread Karim Fodil-Lemelin
2012 9:15 AM, Ermal Luçi wrote: On Tue, Dec 11, 2012 at 2:05 PM, Barney Cordoba < barney_cord...@yahoo.com **wrote: --- On Tue, 12/11/12, Gleb Smirnoff wrote: From: Gleb Smirnoff Subject: Re: igb and ALTQ in 9.1-rc3 To: "Jack Vogel" Cc: "Clement Hermann (nodens)&qu

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Ermal Luçi
9:15 AM, Ermal Luçi wrote: >>> >>> On Tue, Dec 11, 2012 at 2:05 PM, Barney Cordoba < >>>> barney_cord...@yahoo.com >>>> >>>>> **wrote: >>>>> >>>> >>>> --- On Tue, 12/11/12, Gleb Smirnoff wrote: >

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Adrian Chadd
On 11 December 2012 13:49, Andre Oppermann wrote: >> We -know- we need a much more generic implementation of packet queue >> management. Someone just needs to come up with one. :-) > > > As I've said earlier I'm working and cleaning up of the stack/driver > interface and API. It started out to b

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Andre Oppermann
On 11.12.2012 22:36, Adrian Chadd wrote: .. the ALTQ compatibility stuff for buf_ring and drbr_* is just plain ew. The question is, who is going to step up and make that work? I'm certainly not going to; when I teach net80211 and ath(4) about if_transmit, I'm going to do it in a way that breaks

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Adrian Chadd
.. the ALTQ compatibility stuff for buf_ring and drbr_* is just plain ew. The question is, who is going to step up and make that work? I'm certainly not going to; when I teach net80211 and ath(4) about if_transmit, I'm going to do it in a way that breaks ALTQ. And it'll stay broken until I've iron

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Karim Fodil-Lemelin
On 11/12/2012 1:03 PM, Adrian Chadd wrote: The if_transmit versus multiqueue thing is orthogonal. Indeed, although ALTQ isn't using if_transmit and doing a simple drop in (replacing if_start with if_transmit) breaks ALTQ with multiqueue capable drivers. I'm planning to make net80211 and ath(4

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Karim Fodil-Lemelin
: Gleb Smirnoff Subject: Re: igb and ALTQ in 9.1-rc3 To: "Jack Vogel" Cc: "Clement Hermann (nodens)" , "Barney Cordoba" , freebsd-net@FreeBSD.org Date: Tuesday, December 11, 2012, 2:58 AM On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: J> UH, may

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Adrian Chadd
The if_transmit versus multiqueue thing is orthogonal. I'm planning to make net80211 and ath(4) use if_transmit instead of if_start. It won't be a multi-queue driver; I'm actually going down the path of if_transmit specifically so I can control the TX queue serialisation and actively _serialise_ f

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Ermal Luçi
e: >>> >>> From: Gleb Smirnoff >>>> Subject: Re: igb and ALTQ in 9.1-rc3 >>>> To: "Jack Vogel" >>>> Cc: "Clement Hermann (nodens)" , "Barney Cordoba" >>>> >>> , freebsd-net@FreeBSD.org >>

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Barney Cordoba
--- On Tue, 12/11/12, Karim Fodil-Lemelin wrote: > From: Karim Fodil-Lemelin > Subject: Re: igb and ALTQ in 9.1-rc3 > To: freebsd-net@freebsd.org > Cc: nodens2...@gmail.com > Date: Tuesday, December 11, 2012, 9:56 AM > On 11/12/2012 9:15 AM, Ermal Luçi > wrote: > >

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Karim Fodil-Lemelin
On 11/12/2012 9:15 AM, Ermal Luçi wrote: On Tue, Dec 11, 2012 at 2:05 PM, Barney Cordoba wrote: --- On Tue, 12/11/12, Gleb Smirnoff wrote: From: Gleb Smirnoff Subject: Re: igb and ALTQ in 9.1-rc3 To: "Jack Vogel" Cc: "Clement Hermann (nodens)" , "Barne

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Ermal Luçi
On Tue, Dec 11, 2012 at 2:05 PM, Barney Cordoba wrote: > > > --- On Tue, 12/11/12, Gleb Smirnoff wrote: > > > From: Gleb Smirnoff > > Subject: Re: igb and ALTQ in 9.1-rc3 > > To: "Jack Vogel" > > Cc: "Clement Hermann (nodens)" , "

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Barney Cordoba
--- On Tue, 12/11/12, Gleb Smirnoff wrote: > From: Gleb Smirnoff > Subject: Re: igb and ALTQ in 9.1-rc3 > To: "Jack Vogel" > Cc: "Clement Hermann (nodens)" , "Barney Cordoba" > , freebsd-net@FreeBSD.org > Date: Tuesday, December 11, 2012, 2:58

Re: igb and ALTQ in 9.1-rc3

2012-12-11 Thread Jack Vogel
On Mon, Dec 10, 2012 at 11:58 PM, Gleb Smirnoff wrote: > On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: > J> UH, maybe asking the owner of the driver would help :) > J> > J> ... and no, I've never been aware of doing anything to stop supporting > altq > J> so you wouldn't see any com

Re: igb and ALTQ in 9.1-rc3

2012-12-10 Thread Gleb Smirnoff
On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: J> UH, maybe asking the owner of the driver would help :) J> J> ... and no, I've never been aware of doing anything to stop supporting altq J> so you wouldn't see any commits. If there's something in the altq code or J> support (which I h

Re: igb and ALTQ in 9.1-rc3

2012-12-10 Thread Clement Hermann (nodens)
Le 11/12/2012 00:31, Jack Vogel a écrit : > UH, maybe asking the owner of the driver would help :) Indeed. I just assumed anyone on the mailing list would be more knowledgeable than I am. Sorry about that. > > ... and no, I've never been aware of doing anything to stop supporting > altq > so you

Re: igb and ALTQ in 9.1-rc3

2012-12-10 Thread Jack Vogel
UH, maybe asking the owner of the driver would help :) ... and no, I've never been aware of doing anything to stop supporting altq so you wouldn't see any commits. If there's something in the altq code or support (which I have nothing to do with) that caused this no-one informed me. Jack On Mon

Re: igb and ALTQ in 9.1-rc3

2012-12-10 Thread Clement Hermann (nodens)
Le 10/12/2012 23:09, Barney Cordoba a écrit : > > --- On Mon, 12/10/12, Clément Hermann (nodens) wrote: > >> altq(4) states that igb is supported. There are some >> references to altq in >> if_igb.c (include opt_altq in an ifdef), but they are not in >> the em driver >> (though my ruleset load fin

Re: igb and ALTQ in 9.1-rc3

2012-12-10 Thread Barney Cordoba
--- On Mon, 12/10/12, Clément Hermann (nodens) wrote: > From: Clément Hermann (nodens) > Subject: igb and ALTQ in 9.1-rc3 > To: freebsd-net@freebsd.org > Date: Monday, December 10, 2012, 6:03 AM > Hi there, > > I'm trying to install a new pf/altq router. I needed to use > 9.1-rc3 due to > RAI