Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-28 Thread Julian Elischer
On Tue, 27 Nov 2001, Luigi Rizzo wrote: On Tue, Nov 27, 2001 at 02:52:49PM -0500, Andrew R. Reiter wrote: Just as a note, I decided against MFC'ing this and similar changes because I didn't feel it was necesary for -STABLE to have this fix. why not ? code is more compact (and cache

RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Bruce A. Mah
Hi-- I've been reading through src/sys/net/bpf.c, and I noticed that the changes to make it use M_ZERO haven't been MFC-ed to RELENG_4 yet. Any objection if I do this? (Nothing broke in my quick testing.) Thanks, Bruce. Index: bpf.c

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Andrew R. Reiter
Just as a note, I decided against MFC'ing this and similar changes because I didn't feel it was necesary for -STABLE to have this fix. On Tue, 27 Nov 2001, Bruce A. Mah wrote: :Hi-- : :I've been reading through src/sys/net/bpf.c, and I noticed that the :changes to make it use M_ZERO haven't

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Mike Silbersack
On Tue, 27 Nov 2001, Bruce A. Mah wrote: Hi-- I've been reading through src/sys/net/bpf.c, and I noticed that the changes to make it use M_ZERO haven't been MFC-ed to RELENG_4 yet. Any objection if I do this? (Nothing broke in my quick testing.) Thanks, Bruce. Possibly a dumb

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Luigi Rizzo
On Tue, Nov 27, 2001 at 02:52:49PM -0500, Andrew R. Reiter wrote: Just as a note, I decided against MFC'ing this and similar changes because I didn't feel it was necesary for -STABLE to have this fix. why not ? code is more compact (and cache friendly) and readable, diffs from HEAD are

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Bruce A. Mah
If memory serves me right, Andrew R. Reiter wrote: Just as a note, I decided against MFC'ing this and similar changes because I didn't feel it was necesary for -STABLE to have this fix. I agree it's not necessary. I'm reviewing some other BPF patches (which have been sitting in my queue for

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Andrew R. Reiter
Yea, I think MFC'ing it would be fine. Don't hesitate to thwap me one if you guys think I should MFC some things Im not. Cheers, Andrew On Tue, 27 Nov 2001, Bruce A. Mah wrote: :If memory serves me right, Andrew R. Reiter wrote: : : Just as a note, I decided against MFC'ing this and similar

Re: RFC: MFC M_ZERO usage for bpf.c

2001-11-27 Thread Bruce A. Mah
If memory serves me right, Andrew R. Reiter wrote: Yea, I think MFC'ing it would be fine. Don't hesitate to thwap me one if you guys think I should MFC some things Im not. I'm sure there's plenty of people who'll be just itching to take you up on this offer. :-) :-) :-) Thanks, Bruce.