Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Stefan Lambrev
Andrew Thompson wrote: On Mon, Jun 30, 2008 at 07:16:29PM +0900, Pyun YongHyeon wrote: On Mon, Jun 30, 2008 at 12:11:40PM +0300, Stefan Lambrev wrote: Greetings, I just noticed, that when I add em network card to bridge the checksum offload is turned off. I even put in my

Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Stefan Lambrev
Hi, May be a stupid questions, but: 1) There are zero matches of IFCAP_TOE in kernel sources .. there is not support for TOE in 7.0, but may be this is work in progress for 8-current? 2) In #define BRIDGE_IFCAPS_MASK (IFCAP_TOE|IFCAP_TSO|IFCAP_TXCSUM) - TOE should be repleaced with RXCSUM or

Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Stefan Lambrev
Hi, Sorry to reply to myself. Stefan Lambrev wrote: Hi, May be a stupid questions, but: 1) There are zero matches of IFCAP_TOE in kernel sources .. there is not support for TOE in 7.0, but may be this is work in progress for 8-current? 2) In #define BRIDGE_IFCAPS_MASK

Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Andrew Thompson
On Tue, Jul 01, 2008 at 12:51:42PM +0300, Stefan Lambrev wrote: Hi, May be a stupid questions, but: 1) There are zero matches of IFCAP_TOE in kernel sources .. there is not support for TOE in 7.0, but may be this is work in progress for 8-current? Yes, its in current only. Just remove

Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Stefan Lambrev
Greetings Andrew, The patch compiles and works as expected. I noticed something strange btw - swi1: net was consuming 100% WCPU (shown on top -S) but I'm not sure this have something to do with your patch, as I can't reproduce it right now .. Andrew Thompson wrote: On Tue, Jul 01, 2008 at

Re: if_bridge turns off checksum offload of members?

2008-07-01 Thread Sam Leffler
Andrew Thompson wrote: On Tue, Jul 01, 2008 at 12:51:42PM +0300, Stefan Lambrev wrote: Hi, May be a stupid questions, but: 1) There are zero matches of IFCAP_TOE in kernel sources .. there is not support for TOE in 7.0, but may be this is work in progress for 8-current? Yes, its in

if_bridge turns off checksum offload of members?

2008-06-30 Thread Stefan Lambrev
Greetings, I just noticed, that when I add em network card to bridge the checksum offload is turned off. I even put in my rc.conf: ifconfig_em0=rxcsum up ifconfig_em1=rxcsum up but after reboot both em0 and em1 have this feature disabled. Is this expected behavior? Should I care about csum in

Re: if_bridge turns off checksum offload of members?

2008-06-30 Thread Pyun YongHyeon
On Mon, Jun 30, 2008 at 12:11:40PM +0300, Stefan Lambrev wrote: Greetings, I just noticed, that when I add em network card to bridge the checksum offload is turned off. I even put in my rc.conf: ifconfig_em0=rxcsum up ifconfig_em1=rxcsum up but after reboot both em0 and em1 have

Re: if_bridge turns off checksum offload of members?

2008-06-30 Thread Andrew Thompson
On Mon, Jun 30, 2008 at 07:16:29PM +0900, Pyun YongHyeon wrote: On Mon, Jun 30, 2008 at 12:11:40PM +0300, Stefan Lambrev wrote: Greetings, I just noticed, that when I add em network card to bridge the checksum offload is turned off. I even put in my rc.conf:

Re: if_bridge turns off checksum offload of members?

2008-06-30 Thread Andrew Thompson
On Mon, Jun 30, 2008 at 07:16:29PM +0900, Pyun YongHyeon wrote: On Mon, Jun 30, 2008 at 12:11:40PM +0300, Stefan Lambrev wrote: Greetings, I just noticed, that when I add em network card to bridge the checksum offload is turned off. I even put in my rc.conf: