Re: sis(4) flow control

2013-07-17 Thread Marius Strobl
On Wed, Jul 17, 2013 at 12:01:36PM +, Christian Weisgerber wrote: > Yonghyeon PYUN wrote: > > > msk(4) supported flow-control from day 1 with a hack and it was > > re-implemented later with proper way such that it always announces > > flow-control. However for other drivers(i.e vr(4)) that di

Re: sis(4) flow control

2013-07-17 Thread Christian Weisgerber
Yonghyeon PYUN wrote: > msk(4) supported flow-control from day 1 with a hack and it was > re-implemented later with proper way such that it always announces > flow-control. However for other drivers(i.e vr(4)) that didn't > support the feature in the beginning, you have to explicitly enable > the

Re: sis(4) flow control

2013-07-14 Thread Yonghyeon PYUN
On Sun, Jul 14, 2013 at 09:52:38PM +0200, Andreas Longwitz wrote: > Yonghyeon PYUN wrote: > > >> Maybe there is a bug in vr(4) that generates the hang, but why is > > > > Probably yes and I shall have to narrow down the issue. > > One more hint: No hang - but of course no TX support - anymore, w

Re: sis(4) flow control

2013-07-14 Thread Andreas Longwitz
Yonghyeon PYUN wrote: >> Maybe there is a bug in vr(4) that generates the hang, but why is > > Probably yes and I shall have to narrow down the issue. One more hint: No hang - but of course no TX support - anymore, when I use --- if_vr.c.orig2013-06-25 09:58:29.0 +0200 +++ if_vr

Re: sis(4) flow control

2013-07-14 Thread Yonghyeon PYUN
On Sat, Jul 13, 2013 at 10:30:40PM +0200, Andreas Longwitz wrote: > Yonghyeon PYUN wrote: > > >>> Try attached patch and let me know how it works. > >> Thanks for your patch. I will test it on next update of my soekris boxes > >> with sis interfaces. Because they are all remote far away this will

Re: sis(4) flow control

2013-07-13 Thread Andreas Longwitz
Yonghyeon PYUN wrote: >>> Try attached patch and let me know how it works. >> Thanks for your patch. I will test it on next update of my soekris boxes >> with sis interfaces. Because they are all remote far away this will need >> some time. > > Ok. Make sure to check established link before testi

Re: sis(4) flow control

2013-07-10 Thread Yonghyeon PYUN
On Thu, Jul 11, 2013 at 12:18:19AM +0200, Andreas Longwitz wrote: > Yonghyeon PYUN wrote: > > > Hmm, does the change really make flow-control work? > > I believe flow-control should be negotiated with remote link > > partner so you have to announce flow-control capability to link > > partner. In a

Re: sis(4) flow control

2013-07-10 Thread Andreas Longwitz
Yonghyeon PYUN wrote: > Hmm, does the change really make flow-control work? > I believe flow-control should be negotiated with remote link > partner so you have to announce flow-control capability to link > partner. In addition, it seems DP83815/DP83816 does not support > TX flow-control so it jus

Re: sis(4) flow control

2013-07-09 Thread Yonghyeon PYUN
On Tue, Jul 09, 2013 at 03:52:25PM +0200, Andreas Longwitz wrote: > Some of my soekris boxes run with sis interfaces. Because I need > ethernet flow control on these boxes I use the following patch (against > 8-Stable) for some years: > > --- if_sis.c.orig 2013-05-15 20:01:16.0 +0200

sis(4) flow control

2013-07-09 Thread Andreas Longwitz
Some of my soekris boxes run with sis interfaces. Because I need ethernet flow control on these boxes I use the following patch (against 8-Stable) for some years: --- if_sis.c.orig 2013-05-15 20:01:16.0 +0200 +++ if_sis.c 2013-06-24 15:58:05.0 +0200 @@ -1965,6 +1965,