Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Maxim Sobolev
Kris Kennaway wrote: On Mon, May 08, 2006 at 06:18:18PM -0700, Maxim Sobolev wrote: Kris Kennaway wrote: On Mon, May 08, 2006 at 02:52:07AM -0400, Kris Kennaway wrote: OK, David's patch fixes the umtx thundering herd (and seems to give a 4-6% boost). I also fixed a thundering herd in FILEDESC

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Maxim Sobolev
Kris Kennaway wrote: On Mon, May 08, 2006 at 02:52:07AM -0400, Kris Kennaway wrote: OK, David's patch fixes the umtx thundering herd (and seems to give a 4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (which was also waking up 2-7 CPUs at once about 30% of the time) by doing s/w

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Kris Kennaway
On Mon, May 08, 2006 at 06:18:18PM -0700, Maxim Sobolev wrote: > Kris Kennaway wrote: > >On Mon, May 08, 2006 at 02:52:07AM -0400, Kris Kennaway wrote: > >>OK, David's patch fixes the umtx thundering herd (and seems to give a > >>4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (whic

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Kris Kennaway
On Mon, May 08, 2006 at 08:43:28PM -0400, Kris Kennaway wrote: > On Mon, May 08, 2006 at 02:52:07AM -0400, Kris Kennaway wrote: > > OK, David's patch fixes the umtx thundering herd (and seems to give a > > 4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (which > > was also waking up

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Kris Kennaway
On Mon, May 08, 2006 at 02:52:07AM -0400, Kris Kennaway wrote: > OK, David's patch fixes the umtx thundering herd (and seems to give a > 4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (which > was also waking up 2-7 CPUs at once about 30% of the time) by doing > s/wakeup/wakeup_one

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Kris Kennaway
On Tue, May 09, 2006 at 03:34:59AM +0300, Sven Petai wrote: > > Hmm, with this patch mysql 4.1 seems to crash at startup. I haven't > > yet had time to investigate. Is anyone else seeing this? > > > > Seems to run fine here with 4.1.18 on amd64, but doesn't seem to make much > difference though

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Sven Petai
> Hmm, with this patch mysql 4.1 seems to crash at startup. I haven't > yet had time to investigate. Is anyone else seeing this? > Seems to run fine here with 4.1.18 on amd64, but doesn't seem to make much difference though. I ran the tests again on the 8 core machine with and without rwatsons

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Mike Jakubik
David Xu wrote: On Tuesday 09 May 2006 02:43, Kris Kennaway wrote: Hmm, with this patch mysql 4.1 seems to crash at startup. I haven't yet had time to investigate. Is anyone else seeing this? Kris I only have tested mysql 4.0, I will try 4.1 later. What about 5.0? Have any of

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread David Xu
On Tuesday 09 May 2006 02:43, Kris Kennaway wrote: > Hmm, with this patch mysql 4.1 seems to crash at startup. I haven't > yet had time to investigate. Is anyone else seeing this? > > Kris I only have tested mysql 4.0, I will try 4.1 later. ___ freebs

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Kris Kennaway
On Mon, May 08, 2006 at 06:43:31PM +0800, David Xu wrote: > On Monday 08 May 2006 14:52, Kris Kennaway wrote: > > OK, David's patch fixes the umtx thundering herd (and seems to give a > > 4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (which > > was also waking up 2-7 CPUs at once

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread David Xu
On Monday 08 May 2006 14:52, Kris Kennaway wrote: > OK, David's patch fixes the umtx thundering herd (and seems to give a > 4-6% boost). I also fixed a thundering herd in FILEDESC_UNLOCK (which > was also waking up 2-7 CPUs at once about 30% of the time) by doing > s/wakeup/wakeup_one/. This did

Re: Fine-grained locking for POSIX local sockets (UNIX domain sockets)

2006-05-08 Thread Robert Watson
On Mon, 8 May 2006, Kris Kennaway wrote: unp contention has risen a bit. The other big gain is to sleep mtxpool contention, which roughly doubled: In the general case, you can increase the size of the mutex pool. However, since this is per-uid for the socket buffer resource limits, that wo