Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-23 Thread Gábor Kövesdán
Kris Kennaway wrote: On Tue, Aug 15, 2006 at 12:37:50PM -0600, John E Hein wrote: The hard part is to get ports writers to think the right way about DESTDIR after ignoring it for so many years. And once you decide to go about fixing it, there's no way around that problem. My

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Kris Kennaway
On Tue, Aug 15, 2006 at 12:37:50PM -0600, John E Hein wrote: The hard part is to get ports writers to think the right way about DESTDIR after ignoring it for so many years. And once you decide to go about fixing it, there's no way around that problem. My preferred solution involves a couple

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Gábor Kövesdán
Kris Kennaway wrote: On Wed, Aug 16, 2006 at 07:55:20PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Tue, Aug 15, 2006 at 12:37:50PM -0600, John E Hein wrote: The hard part is to get ports writers to think the right way about DESTDIR after ignoring it for so many

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread John E Hein
Kris Kennaway wrote at 13:36 -0400 on Aug 16, 2006: mount_nullfs ${PORTSDIR} ${DESTDIR}${PORTSDIR} mount_nullfs ${WRKDIR} ${DESTDIR}${WRKDIR} mount_devfs foo ${DESTDIR}/dev chroot ${DESTDIR} cd ${.CURDIR} make install A suitable version of the above should allow all ports to be

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Brooks Davis
On Wed, Aug 16, 2006 at 08:14:08PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Wed, Aug 16, 2006 at 07:55:20PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Tue, Aug 15, 2006 at 12:37:50PM -0600, John E Hein wrote: The hard part is to get ports writers

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Gábor Kövesdán
Brooks Davis wrote: On Wed, Aug 16, 2006 at 08:14:08PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Wed, Aug 16, 2006 at 07:55:20PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Tue, Aug 15, 2006 at 12:37:50PM -0600, John E Hein wrote:

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Kris Kennaway
On Wed, Aug 16, 2006 at 01:35:22PM -0500, Brooks Davis wrote: On Wed, Aug 16, 2006 at 08:14:08PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Wed, Aug 16, 2006 at 07:55:20PM +0200, G?bor K?vesd?n wrote: Kris Kennaway wrote: On Tue, Aug 15, 2006 at 12:37:50PM -0600,

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Doug Barton
Gábor Kövesdán wrote: if we can work this out a bit better, my progress so far would become pointless... Not at all! If I had a dollar for every Good Idea(TM) that I had which ended up leading me down a completely different road, I'd be retired now. These are not easy problems, and the fact

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Dmitry Marakasov
* Doug Barton ([EMAIL PROTECTED]) wrote: if we can work this out a bit better, my progress so far would become pointless... Not at all! If I had a dollar for every Good Idea(TM) that I had which ended up leading me down a completely different road, I'd be retired now. These are not easy

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-16 Thread Erwin Lansing
On Thu, Aug 17, 2006 at 12:20:09AM +0400, Dmitry Marakasov wrote: * Both current and nullfs-drived DESTDIR implementations require all depends in the DESTDIR. But actually BUILD_DEPENDS from host can be used. This should already be the case with the current implementation and also will

Re: ATTENTION: is the way DESTDIR was introduced completely wrong?

2006-08-15 Thread Sergey Matveychuk
Dmitry Marakasov wrote: What I propose is: - Change variable naming scheme. All *BASE and *DIR vars should be reverted to their original meanings (i.e. local paths). Instead, INSTALL_ vars should be introduced: INSTALL_LOCALBASE=${DESTDIR}/${LOCALBASE} INSTALL_X11BASE=${DESTDIR}/${X11BASE}

DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-15 Thread Gábor Kövesdán
Dmitry Marakasov wrote: Hi! I'm now exploring new DESTDIR-related stuff, and I find it far from being useable. More of that, DESTDIR-related changes seem dangerous to me. As far as I understand, for port to support DESTDIR, it's files should be installed into ${DESTDIR}/${PREFIX}/foo (aka

Re: ATTENTION: is the way DESTDIR was introduced completely wrong?

2006-08-15 Thread Gábor Kövesdán
Sergey Matveychuk wrote: Dmitry Marakasov wrote: What I propose is: - Change variable naming scheme. All *BASE and *DIR vars should be reverted to their original meanings (i.e. local paths). Instead, INSTALL_ vars should be introduced: INSTALL_LOCALBASE=${DESTDIR}/${LOCALBASE}

Re: ATTENTION: is the way DESTDIR was introduced completely wrong?

2006-08-15 Thread Dmitry Marakasov
* G??bor K??vesd??n ([EMAIL PROTECTED]) wrote: I agree with every your word. I was to implement it in this way, but as I said this would require us to change all of the *_DEPENDS lines. Erwin told me that this can't be happen, so I was pushed to go the another way. Erwin is in portmgr, and

Re: DESTDIR implementation [Was:: ATTENTION: is the way DESTDIR was introduced completely wrong?]

2006-08-15 Thread John E Hein
Gábor Kövesdán wrote at 11:32 +0200 on Aug 15, 2006: Dmitry Marakasov wrote: Now, I think the way DESTDIR-related changes were done to bsd.port.mk is absolutely wrong. For example, X11BASE, LOCALBASE, DATADIR now contain DESTDIR. But, these variables are frequently used when changing

ATTENTION: is the way DESTDIR was introduced completely wrong?

2006-08-14 Thread Dmitry Marakasov
Hi! I'm now exploring new DESTDIR-related stuff, and I find it far from being useable. More of that, DESTDIR-related changes seem dangerous to me. As far as I understand, for port to support DESTDIR, it's files should be installed into ${DESTDIR}/${PREFIX}/foo (aka ${TARGETDIR}/foo), but all

Re: ATTENTION: is the way DESTDIR was introduced completely wrong?

2006-08-14 Thread Andrew Pantyukhin
So now that Dmitry sounded a sober thought, I'll give a one of my own. I would rather see PREFIX respect DESTDIR and go through all the pains of respecting PREFIX. This way we reach a double cause: * ensure PREFIX is respected (this will reveal thousands of erring ports, but it will be worth