Re: Approving a patch

2015-03-04 Thread Doug Hardie
On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope. This of course requires the

Re: Approving a patch

2015-03-04 Thread Kubilay Kocak
On 4/03/2015 9:05 PM, Kubilay Kocak wrote: On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug

Re: Approving a patch

2015-03-04 Thread Kubilay Kocak
On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag to + *on the attachment/patch*. The maintainer-feedback flag is at the issue/bug scope, not the attachment/patch scope.

Re: Approving a patch

2015-03-04 Thread Chris H
On Wed, 04 Mar 2015 21:23:23 +1100 Kubilay Kocak ko...@freebsd.org wrote On 4/03/2015 9:05 PM, Kubilay Kocak wrote: On 4/03/2015 9:00 PM, Doug Hardie wrote: On 3 March 2015, at 22:45, Kubilay Kocak ko...@freebsd.org wrote: Canonically and preferred: Set maintainer-approval flag

Re: Approving a patch

2015-03-03 Thread Kurt Jaeger
Hi! I am the maintainer for a port. I received a suggested patch for the port that is good. Did you receive it as part of a problem report in bugzilla or per e-mail ? Hmm, you're maintainer for mail/qpopper, as listed in /usr/ports/INDEX-10. There's a PR:

Re: Approving a patch

2015-03-03 Thread Bryan Drewery
On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I

Approving a patch

2015-03-03 Thread Doug Hardie
I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is gone (or at least I didn’t find it). I went through the porters manual and didn’t

Re: Approving a patch

2015-03-03 Thread Kubilay Kocak
On 4/03/2015 5:45 PM, Kubilay Kocak wrote: On 4/03/2015 7:11 AM, Bryan Drewery wrote: On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve

Re: Approving a patch

2015-03-03 Thread Kubilay Kocak
On 4/03/2015 7:11 AM, Bryan Drewery wrote: On 3/3/2015 1:53 PM, Doug Hardie wrote: I am the maintainer for a port. I received a suggested patch for the port that is good. There used to be a link in the notification email to click on to approve the patch. With the new port system, that is