Re: Introducing USE_SRC and ONLY_FOR_*VER (was: CFR: patch to cleanup usage of SRC_BASE in various ports)

2010-12-03 Thread Ganael LAPLANCHE
On Wed, 1 Dec 2010 10:38:10 +0200, Ion-Mihai Tetcu wrote Hi, It would be interesting to provide something like : USE_BASE= yes Which would do the following : = defines ${SRC_BASE} = checks for ${SRC_BASE}/sys/Makefile = provides a standard error msg if not found or, if

Re: Introducing USE_SRC and ONLY_FOR_*VER (was: CFR: patch to cleanup usage of SRC_BASE in various ports)

2010-12-03 Thread Ion-Mihai Tetcu
On Fri, 3 Dec 2010 08:59:22 +0100 (CET) Ganael LAPLANCHE ganael.laplan...@martymac.org wrote: On Wed, 1 Dec 2010 10:38:10 +0200, Ion-Mihai Tetcu wrote Hi, It would be interesting to provide something like : USE_BASE= yes Which would do the following : = defines

Re: Introducing USE_SRC and ONLY_FOR_*VER (was: CFR: patch to cleanup usage of SRC_BASE in various ports)

2010-12-03 Thread Ganael LAPLANCHE
On Fri, 3 Dec 2010 14:07:35 +0200, Ion-Mihai Tetcu wrote Submit a PR with it please. Done ports/152804. BTW, there was a mistake in the patch file name. It's been fixed ; the correct URL is now : http://people.freebsd.org/~martymac/patches/20101203-patch-bsd.port.mk.txt Best regards, --

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-12-01 Thread Ion-Mihai Tetcu
On Tue, 30 Nov 2010 22:16:17 +0100 (CET) Ganael LAPLANCHE ganael.laplan...@martymac.org wrote: On Tue, 30 Nov 2010 14:09:35 -0600, Ade Lovett wrote Hi Ade, hi Mark ! Patch incorporating these suggestions, along with some other edge cases I found, uploaded:

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Ade Lovett
On Nov 29, 2010, at 22:13 , Mark Linimon wrote: I would appreciate feedback on the following patch: http://people.freebsd.org/~linimon/patches/diff.out.srcbase Seems like there's an awful lot of duplication of: SRC_BASE?= /usr/src in those port Makefiles. What's wrong with adding the

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Mark Linimon
On Tue, Nov 30, 2010 at 03:33:27AM -0600, Ade Lovett wrote: Seems like there's an awful lot of duplication of: SRC_BASE?= /usr/src in those port Makefiles. What's wrong with adding the above, with a bit of documentation, to bsd.port.mk ? Nothing at all, but this is a fix I'd like to go

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Rene Ladan
Op 30-11-2010 05:13, Mark Linimon schreef: I am trying to debug a problem in the package building scripts, and in the process of debugging it, have found some inconsistencies with ports that require kernel sources. For installations that keep their latest sources in /usr/src, this patch

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Mark Linimon
Patch incorporating these suggestions, along with some other edge cases I found, uploaded: http://people.freebsd.org/~linimon/patches/diff.out.srcbase mcl ___ freebsd-ports@freebsd.org mailing list

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Ade Lovett
On Nov 30, 2010, at 13:19 , Mark Linimon wrote: Patch incorporating these suggestions, along with some other edge cases I found, uploaded: http://people.freebsd.org/~linimon/patches/diff.out.srcbase http://people.FreeBSD.org/~ade/bpm.src_base.diff Trivial addition to Mk/bsd.port.mk to

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Ganael LAPLANCHE
On Tue, 30 Nov 2010 14:09:35 -0600, Ade Lovett wrote Hi Ade, hi Mark ! Patch incorporating these suggestions, along with some other edge cases I found, uploaded: http://people.freebsd.org/~linimon/patches/diff.out.srcbase http://people.FreeBSD.org/~ade/bpm.src_base.diff Trivial

Re: CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-30 Thread Mark Linimon
ok, but I'm trying to fix something before I have time to do an -exp run ... mcl ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

CFR: patch to cleanup usage of SRC_BASE in various ports

2010-11-29 Thread Mark Linimon
I am trying to debug a problem in the package building scripts, and in the process of debugging it, have found some inconsistencies with ports that require kernel sources. For installations that keep their latest sources in /usr/src, this patch should have no effect; however, for others (such as