Re: New port needs review: net/erlyvideo

2011-01-27 Thread Ruslan Mahmatkhanov
25.01.2011 00:22, Ruslan Mahmatkhanov пишет: Hi! Thank you all much for all the tips and guidance. So it seems i'm finally was able to produce a port, that installs and deinstalls fine both installed from a port and package. The only question that i have: what if my port installs some stuff

Re: New port needs review: net/erlyvideo

2011-01-24 Thread Ruslan Mahmatkhanov
Hi! Thank you all much for all the tips and guidance. So it seems i'm finally was able to produce a port, that installs and deinstalls fine both installed from a port and package. The only question that i have: what if my port installs some stuff into /var/lib/%%PORTNAME%%/snmp (i.e. that

Re: New port needs review: net/erlyvideo

2011-01-17 Thread Ruslan Mahmatkhanov
17.01.2011 00:45, Jason Helfman пишет: You may wish to consider a for loop on the make install target. Are these directories created during the install process of the package? I didn't see these directories created outside of the Makefile. Do you mean something like this? DIRS=

Re: New port needs review: net/erlyvideo

2011-01-17 Thread Matthew Seaman
On 17/01/2011 20:26, Jason Helfman wrote: .for dir in /var/lib/${PORTNAME}/movies /var/lib/${PORTNAME}/plugins \ /var/log/${PORTNAME} ${ETCDIR} ${ERLYDIR} ${WWWDIR} ${MKDIR} ${dir} .endfor This snippet needs to be associated with some sort of make target or it will never get

Re: New port needs review: net/erlyvideo

2011-01-16 Thread Ruslan Mahmatkhanov
16.01.2011 00:31, Ruslan Mahmatkhanov пишет: Hello! I'm finally completed with port of erlyvideo (see erlyvideo.org for details). But before i'll post PR, i want that somebody review it. Because i'm sure there is something that can be made better. I'm attached the diff to make commenting

Re: New port needs review: net/erlyvideo

2011-01-16 Thread Jason Helfman
On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: 16.01.2011 00:31, Ruslan Mahmatkhanov пишет: Hello! I'm finally completed with port of erlyvideo (see erlyvideo.org for details). But before i'll post PR, i want that somebody review it. Because i'm sure there is

Re: New port needs review: net/erlyvideo

2011-01-16 Thread Ruslan Mahmatkhanov
16.01.2011 23:44, Jason Helfman пишет: On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: 16.01.2011 00:31, Ruslan Mahmatkhanov пишет: Hello! I'm finally completed with port of erlyvideo (see erlyvideo.org for details). But before i'll post PR, i want that somebody

Re: New port needs review: net/erlyvideo

2011-01-16 Thread Jason Helfman
On Mon, Jan 17, 2011 at 12:22:59AM +0300, Ruslan Mahmatkhanov thus spake: 16.01.2011 23:44, Jason Helfman пишет: On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: As you can see this patch indeed eliminates using of git, because this part isn't really needed for

Re: New port needs review: net/erlyvideo

2011-01-16 Thread Wesley Shields
On Sun, Jan 16, 2011 at 01:45:57PM -0800, Jason Helfman wrote: On Mon, Jan 17, 2011 at 12:22:59AM +0300, Ruslan Mahmatkhanov thus spake: 16.01.2011 23:44, Jason Helfman ??: On Sun, Jan 16, 2011 at 08:25:18PM +0300, Ruslan Mahmatkhanov thus spake: As you can see this patch indeed

New port needs review: net/erlyvideo

2011-01-15 Thread Ruslan Mahmatkhanov
Hello! I'm finally completed with port of erlyvideo (see erlyvideo.org for details). But before i'll post PR, i want that somebody review it. Because i'm sure there is something that can be made better. I'm attached the diff to make commenting more convenient but you can also download port