Re: Optional Patches

2011-05-22 Thread Ion-Mihai Tetcu
On Wed, 18 May 2011 19:01:31 -0400 Matthew Pounsett wrote: > > Based on the responses here it sounds like I've been doing nothing > wrong so I played around a bit more. I guess in my testing there > must've been some combination of things I didn't get right... I did a > bunch more testing and e

Re: Optional Patches

2011-05-18 Thread Matthew Pounsett
Based on the responses here it sounds like I've been doing nothing wrong so I played around a bit more. I guess in my testing there must've been some combination of things I didn't get right... I did a bunch more testing and eventually I made it work doing exactly what I've been doing, except

Re: Optional Patches

2011-05-18 Thread Matthew Seaman
On 18/05/2011 23:17, Doug Barton wrote: > On 05/18/2011 15:10, Matthew Seaman wrote: >> # Testing both WITH_ and WITHOUT_ is a good idea... > > I'm not sure why you would need to test both, unless it's to catch wacky > stuff coming in from the environment? That's one reason. Another is that it m

Re: Optional Patches

2011-05-18 Thread Doug Barton
On 05/18/2011 15:10, Matthew Seaman wrote: # Testing both WITH_ and WITHOUT_ is a good idea... I'm not sure why you would need to test both, unless it's to catch wacky stuff coming in from the environment? The usual way is to test the opposite of the default. So for default on you would tes

Re: Optional Patches

2011-05-18 Thread Matthew Seaman
On 18/05/2011 22:29, Matthew Pounsett wrote: > I've added a new option (call it 'FOO') to the OPTIONS definition, > and I'm attempting to add something like this directly below MASTER_SITES > near the top of the Makefile: > > .if defined(FOO) > PATCH_SITES= http://location.site.com/path/ > PA

Re: Optional Patches

2011-05-18 Thread Matthew Pounsett
Following up my own post. Bleargh. On 2011/05/18, at 17:29, Matthew Pounsett wrote: > .if defined(FOO) > PATCH_SITES= http://location.site.com/path/ > PATCHFILES= port-${PORTVERSION}.patch > PATCH_DIST_STRIP= -p1 > .endif I should note that I have actually been doing this using '.i

Optional Patches

2011-05-18 Thread Matthew Pounsett
I posted the other day about an issue I was having working around a distribution CGI when adding a patch to a port. Thanks to a suggestion from Matthew Seaman that problem is solved, but I seem to have bumped up against another. It seems that I can't find a way to make applying the patch optio