Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-29 Thread Doug Barton
On Wed, 28 Jul 2010, Mark Linimon wrote: These are the results that I get on my home machine: -- Here is my /etc/make.conf: OPENSSH_OVERWRITE_BASE=yes WITH_APACHE2=yes X11BASE=${LOCALBASE} USE_LOCAL_MK= yes

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-29 Thread Mark Linimon
On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: When I asked you what was necessary to test this, you said all that was necessary was to define _PERL_REFACTORING_COMPLETE. And my memory slipped. The explanation, however, was correct: the problem is that if you unconditionally

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-29 Thread Doug Barton
On Thu, 29 Jul 2010, Mark Linimon wrote: On Wed, Jul 28, 2010 at 11:47:11PM -0700, Doug Barton wrote: When I asked you what was necessary to test this, you said all that was necessary was to define _PERL_REFACTORING_COMPLETE. And my memory slipped. The explanation, however, was correct: the

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-28 Thread Mark Linimon
These are the results that I get on my home machine: $ make index Generating INDEX-7 - please wait..make_index: thunderbird-3.0.5_1: no entry for :/home/pcvs/ports/lang make_index: thunderbird-3.0.5_1: no entry for :/home/pcvs/ports/lang make_index: thunderbird-3.0.5_1: no entry for

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-28 Thread Philip M. Gollucci
Its a bit to late for me to think about this tonight, but on quick glance our diffs not equivalent. On 7/29/2010 12:14 AM, Mark Linimon wrote: These are the results that I get on my home machine: $ make index Generating INDEX-7 - please wait..make_index: thunderbird-3.0.5_1: no entry

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Philip M. Gollucci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've long been interested in this. I must be using the wrong options or something. About 1 yr ago I was able to build the index after removing the appropriate things in Mk/. On 07/19/10 02:12, Doug Barton wrote: On 07/18/10 15:38, Mark Linimon

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Doug Barton
On Mon, 19 Jul 2010, Philip M. Gollucci wrote: I've long been interested in this. I must be using the wrong options or something. About 1 yr ago I was able to build the index after removing the appropriate things in Mk/. Well, seems like I have good news. :) I ran tests on both 9-current

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Philip M. Gollucci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/20/10 03:57, Doug Barton wrote: On Mon, 19 Jul 2010, Philip M. Gollucci wrote: I've long been interested in this. I must be using the wrong options or something. About 1 yr ago I was able to build the index after removing the appropriate

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Doug Barton
On Tue, 20 Jul 2010, Philip M. Gollucci wrote: You didn't quite test everything. I didn't try. :) In talking to Mark his previous testing clearly demonstrated that with the knob set would cause the INDEX generation to fail spectacularly. So the fact that this did not happen, seems like a

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Philip M. Gollucci
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/20/10 04:52, Doug Barton wrote: So yeah, a pointyhat run is almost certainly a good idea before actually making the change, however 'make index' was the canary in Mark's original coal mine, and fortunately that bird is still singing. :)

Re: bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-19 Thread Doug Barton
On Tue, 20 Jul 2010, Philip M. Gollucci wrote: On 07/20/10 04:52, Doug Barton wrote: So yeah, a pointyhat run is almost certainly a good idea before actually making the change, however 'make index' was the canary in Mark's original coal mine, and fortunately that bird is still singing. :)

bsd.perl.mk (Was: Re: _PERL_REFACTORING_COMPLETE lang/perl5.12 Mk/bsd.perl.mk)

2010-07-18 Thread Doug Barton
On 07/18/10 15:38, Mark Linimon wrote: The intention of bsd.perl.mk was to eventually allow a bunch of code to be pulled out of bsd.port.mk, and to have bsd.perl.mk only included conditionally, on the theory that it will speed up INDEX building somewhat. (I have not tested for speedup).