Re: net/samba-libsmbclient SAMBA_PORT= - SAMBA_PORT?=

2011-06-20 Thread Chris Rees
On 12 March 2011 18:18, J. Hellenthal jh...@dataix.net wrote: In any case would you mind adding a variable to the Makefile then ? SAMBA_PORT =    ${SAMBA_LIBSMBPORT:=samba34} Translated from sh to Mk: .if defined (SAMBA_LIBSMBPORT) SAMBA_PORT= ${SAMBA_LIBSMBPORT} .else SAMBA_PORT= samba34

Re: net/samba-libsmbclient SAMBA_PORT= - SAMBA_PORT?=

2011-03-12 Thread Timur I. Bakeyev
Hi! On Tue, Mar 1, 2011 at 6:46 AM, jhell jh...@dataix.net wrote: Could you please change the SAMBA_PORT= directive in samba-libsmbclient to SAMBA_PORT?= samba34 so it can be overridden by make.conf or command line ? No, I believe it's a bad idea. There is probably some bad magic that will

Re: net/samba-libsmbclient SAMBA_PORT= - SAMBA_PORT?=

2011-03-12 Thread J. Hellenthal
On Sat, 12 Mar 2011 10:25, timur@ wrote: Hi! On Tue, Mar 1, 2011 at 6:46 AM, jhell jh...@dataix.net wrote: Could you please change the SAMBA_PORT= directive in samba-libsmbclient to SAMBA_PORT?= samba34 so it can be overridden by make.conf or command line ? No, I believe it's a bad idea.