Re: ffs_alloc panic patch

2004-10-26 Thread Don Lewis
On 27 Aug, Pavel Merdine wrote: > Hello, > > I'd like to propose the following patch: > > -- > --- ffs_alloc.c.origFri May 14 19:03:50 2004 > +++ ffs_alloc.c Sat Aug 7 03:36:32 2004 > @@ -712,7 +712,7 @@ > minbfr

Re[2]: ffs_alloc panic patch

2004-08-28 Thread Pavel Merdine
Hello , I think that umount should be the last resort. For example, we are going to write a file. This fails at the bottom of the code. Why can we just report that we failed to write it? For example if we didn't change any internal structures? I'm sure we can still read from that disk. (I hope the

Re[2]: ffs_alloc panic patch

2004-08-28 Thread Pavel Merdine
Hello , Yes. That I was trying to say. For example, the Windows does not show the blue screen in such situations. In my practice I saw many times the situation of panic() when file system was not fsck'd. Actually it may even lead to security holes. E.g. a user may change an fs somehow to