Re: Re: Re: Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-13 Thread Rick Macklem
On Sun, 13 Jun 2010, Kostik Belousov wrote: My note was not an objection, only a note. Also, when committing, please add a comment explaining what is going on. Righto, and my response was just my opinion. I'm assuming Mikolaj is looking at committing this? rick ___

Re: Re: Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Kostik Belousov
On Sat, Jun 12, 2010 at 07:06:11PM -0400, Rick Macklem wrote: > > > On Sat, 12 Jun 2010, Kostik Belousov wrote: > > > > >Yes, I hoped that Mikolaj ends up with something similar :). Please note > >that this is racy, since we cannot know why usecount is greater then 1. > >This might cause the sil

Re: Re: Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Rick Macklem
On Sat, 12 Jun 2010, Kostik Belousov wrote: Yes, I hoped that Mikolaj ends up with something similar :). Please note that this is racy, since we cannot know why usecount is greater then 1. This might cause the silly rename to kick in some time where it should not, but the race is rare. I'd

Re: Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Kostik Belousov
On Sat, Jun 12, 2010 at 11:15:49AM -0400, Rick Macklem wrote: > > > On Sat, 12 Jun 2010, Kostik Belousov wrote: > > >On Sat, Jun 12, 2010 at 11:56:10AM +0300, Mikolaj Golub wrote: > >> > >>On Sun, 6 Jun 2010 16:44:43 +0200 Leon Me??ner wrote: > >> > >> LM> Hi, > >> LM> I hope this is not the wro

Re: Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Rick Macklem
On Sat, 12 Jun 2010, Kostik Belousov wrote: On Sat, Jun 12, 2010 at 11:56:10AM +0300, Mikolaj Golub wrote: On Sun, 6 Jun 2010 16:44:43 +0200 Leon Me??ner wrote: LM> Hi, LM> I hope this is not the wrong list to ask. Didn't get any answers on LM> -questions. LM> When you try to do the fo

Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Kostik Belousov
On Sat, Jun 12, 2010 at 11:56:10AM +0300, Mikolaj Golub wrote: > > On Sun, 6 Jun 2010 16:44:43 +0200 Leon Me??ner wrote: > > LM> Hi, > LM> I hope this is not the wrong list to ask. Didn't get any answers on > LM> -questions. > > LM> When you try to do the following inside a nullfs mounted di

Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Mikolaj Golub
On Sat, 12 Jun 2010 11:56:10 +0300 Mikolaj Golub wrote to Leon Meßner: MG> See the attached patch (it works for me on both 8-STABLE and CURRENT). Sorry, actually here is the patch. -- Mikolaj Golub Index: sys/fs/nullfs/null_vnops.c

Re: freeBSD nullfs together with nfs and "silly rename"

2010-06-12 Thread Mikolaj Golub
On Sun, 6 Jun 2010 16:44:43 +0200 Leon Meßner wrote: LM> Hi, LM> I hope this is not the wrong list to ask. Didn't get any answers on LM> -questions. LM> When you try to do the following inside a nullfs mounted directory, LM> where the nullfs origin is itself mounted via nfs you get an error

freeBSD nullfs together with nfs and "silly rename"

2010-06-06 Thread Leon Meßner
Hi, I hope this is not the wrong list to ask. Didn't get any answers on -questions. When you try to do the following inside a nullfs mounted directory, where the nullfs origin is itself mounted via nfs you get an error: # foo # tail -f foo& # rm -f foo tail: foo: Stale NFS file handle # fg Th