Re: [toolchain] disable -Wtautological-compare for clang

2011-10-17 Thread Gerald Pfeifer
On Mon, 17 Oct 2011, Alexander Best wrote: any chance we could disable -Wtautological-compare for clang? i don't think comparing an unsigned int against 0 is worth a warning. actually it's always nice to have such a seatbelt, in case somebody changes the type to int and forgets to

Re: [toolchain] disable -Wtautological-compare for clang

2011-10-17 Thread Warner Losh
I'm all for leaving it on because things like char are signed on some architectures and unsigned on others. This leads to bugs that only appear on one architecture. This warning will, at least, flag those usages. On Oct 17, 2011, at 10:56 AM, Gerald Pfeifer wrote: On Mon, 17 Oct 2011,

Re: disable -Wtautological-compare for clang

2011-10-17 Thread Matthias Andree
Am 17.10.2011 17:25, schrieb Alexander Best: any chance we could disable -Wtautological-compare for clang? i don't think comparing an unsigned int against 0 is worth a warning. actually it's always nice to have such a seatbelt, in case somebody changes the type to int and forgets to

Re: [toolchain] disable -Wtautological-compare for clang

2011-10-17 Thread Gerald Pfeifer
On Tue, 18 Oct 2011, Matthias Andree wrote: any chance we could disable -Wtautological-compare for clang? i don't think comparing an unsigned int against 0 is worth a warning. actually it's always nice to have such a seatbelt, in case somebody changes the type to int and forgets to