Re: Lock annotations: enable them for libpthread, libstdthreads

2014-08-28 Thread Adrian Chadd
On 28 August 2014 10:34, Ed Schouten wrote: > On 28 August 2014 19:18, Steve Kargl > wrote: >> What it is the performance penalty (time and memory)? That is, >> buildworld already takes a long time on my system because >> of clang. > > My gut feeling is that impact is minimal. Buildworl

Re: Lock annotations: enable them for libpthread, libstdthreads

2014-08-28 Thread Steve Kargl
On Thu, Aug 28, 2014 at 07:02:55PM +0200, Ed Schouten wrote: > > small number of patches to build with this flag, I am also going to > add -Wthread-safety to WARNS=6, to make sure it won't regress. I'm > also planning on MFC'ing at least the changes to , so it > is at least possible to write porta

Re: Lock annotations: enable them for libpthread, libstdthreads

2014-08-28 Thread Ed Schouten
On 28 August 2014 19:18, Steve Kargl wrote: > What it is the performance penalty (time and memory)? That is, > buildworld already takes a long time on my system because > of clang. My gut feeling is that impact is minimal. Buildworlds seem to take approximately the same time, mainly beca

Lock annotations: enable them for libpthread, libstdthreads

2014-08-28 Thread Ed Schouten
written a patch that adds #defines for the attributes that are relevant for us (read: things that are useful for C programs) to and patched up all functions in libpthread and libstdthreads to use these attributes where possible: http://80386.nl/pub/20140828-lock_annotate.txt One of my observations