[Differential] [Commented On] D2933: Significantly speed up ar(1) on UFS file systems

2015-06-29 Thread kib (Konstantin Belousov)
kib added inline comments. INLINE COMMENTS usr.bin/ar/write.c:568 It is simpler to do if (s == 0) return; for (p = buf; p < buf + s; p += page_size) *p; *(volatile const char *)(buf + s - 1); I do not insist. REVISION DETAIL https://reviews.freebsd.org/D2933

[Differential] [Updated, 26 lines] D2933: Significantly speed up ar(1) on UFS file systems

2015-06-29 Thread emaste (Ed Maste)
emaste updated this revision to Diff 6543. emaste added a comment. This revision now requires review to proceed. - give full path to file with comment explaining the deadlock avoidance - avoid confusing page mask manipulation and just touch the last byte explicitly CHANGES SINCE LAST UPDATE ht

[Differential] [Accepted] D2933: Significantly speed up ar(1) on UFS file systems

2015-06-29 Thread kib (Konstantin Belousov)
kib accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D2933 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, eadler, kib Cc: kib, freebsd-toolchain-list, dim, davide _

[Differential] [Closed] D2933: Significantly speed up ar(1) on UFS file systems

2015-06-29 Thread emaste (Ed Maste)
This revision was automatically updated to reflect the committed changes. Closed by commit rS284928: speed up ar(1) on UFS file systems (authored by emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2933?vs=6543&id=6545#toc REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST