[Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

2015-07-23 Thread bapt (Baptiste Daroussin)
bapt accepted this revision. bapt added a comment. This is one of the changes I really needed! REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, imp, brooks, bapt Cc: freebsd-toolchain-list _

[Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

2015-07-23 Thread brooks (Brooks Davis)
brooks accepted this revision. brooks added a comment. Looks good to me REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, bapt, imp, brooks Cc: freebsd-toolchain-list

[Differential] [Accepted] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

2015-07-23 Thread imp (Warner Losh)
imp accepted this revision. imp added a reviewer: imp. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D3175 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks, bapt, imp Cc: freebsd-toolchain-list __

[Differential] [Request, 39 lines] D3175: ar: add -U (unique) option to disable -D (deterministic) mode

2015-07-23 Thread emaste (Ed Maste)
emaste created this revision. emaste added reviewers: brooks, bapt. emaste added a subscriber: freebsd-toolchain-list. REVISION SUMMARY I'd like to make ar(1) produce deterministic output by default. In order to do so we'll first need an option to turn off deterministic mode. Note that thi

[Differential] [Accepted] D2338: readelf: avoid division by zero for files with invalid sh_entsize

2015-07-23 Thread brooks (Brooks Davis)
brooks accepted this revision. brooks added a comment. This revision has a positive review. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-li

[Differential] [Commented On] D2338: readelf: avoid division by zero for files with invalid sh_entsize

2015-07-23 Thread emaste (Ed Maste)
emaste added a comment. Yes - sorry for the delay. I realized I had a newer implementation that factored the divide-by-zero checks into a helper function, and uploaded the new diff a few days ago. REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd

[Differential] [Commented On] D2338: readelf: avoid division by zero for files with invalid sh_entsize

2015-07-23 Thread brooks (Brooks Davis)
brooks added a comment. Is this still live? REVISION DETAIL https://reviews.freebsd.org/D2338 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: emaste, brooks Cc: brooks, freebsd-toolchain-list ___ freebsd-toolcha