[Differential] [Updated] D1446: Add the AArch64 llvm backend

dim added a comment. Are we sure we already want to hook this up to the build by default? There were already a few complaints about building non-default arches... Also, the other usr.bin/clang tools should be updated, otherwise they won't link. Those are the ones that are enabled via WITH_CLA

[Differential] [Commented On] D1446: Add the AArch64 llvm backend

dim added inline comments. BRANCH /head INLINE COMMENTS lib/clang/clang.build.mk:33 That should not be "arm53", but "arm64", obviously. REVISION DETAIL https://reviews.freebsd.org/D1446 To: andrew, emaste, dim Cc: freebsd-toolchain, emaste ___

[Differential] [Commandeered] D1446: Add the AArch64 llvm backend

dim commandeered this revision. dim edited reviewers, added: andrew; removed: dim BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1446 To: dim, emaste, andrew Cc: freebsd-toolchain, emaste ___ freebsd-toolchain@freebsd.org mailing list ht

[Differential] [Updated, 332 lines] D1446: Add the AArch64 llvm backend

dim updated this revision to Diff 3033. dim added a comment. This revision now requires review to proceed. * Unexpanded $FreeBSD$ keywords * Added aarch64 libraries to both the WITH_CLANG_EXTRAS programs and lldb * For some Makefiles, made the library order mostly the same as an upstream autoconf

[Differential] [Closed] D1446: Add the AArch64 llvm backend

dim closed this revision. dim updated this revision to Diff 3035. dim added a comment. Closed by commit rS276783 (authored by @dim). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1446?vs=3033&id=3035#toc REVISION DETAIL https://reviews.freebsd.org/D1446 AFFECTED FILES head/lib/clan

[Differential] [Accepted] D1468: Fix the ARM build of compiler-rt

dim accepted this revision. dim added a comment. Yes, this looks fine. Though it would be nice to somehow make use of some of these routines? E.g., clang can possibly insert calls to quicker VFP based primitives, if you compile with the correct CPU settings. BRANCH /head REVISION DETAIL h

[Differential] [Request, 52 lines] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

dim created this revision. dim added reviewers: andrew, bapt, emaste, imp. dim added a subscriber: freebsd-toolchain. REVISION SUMMARY I added the libclang_rt libraries (Address Sanitizer, Undefined Behavior Sanitizer and Profile Guided Optimization) from compiler-rt to the tree recently, bu

[Differential] [Commented On] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

dim added a comment. Minor note: this survived a "make universe" on one of the FreeBSD.org reference machines. REVISION DETAIL https://reviews.freebsd.org/D1505 To: dim, andrew, bapt, emaste, imp Cc: freebsd-toolchain ___ freebsd-toolchain@freebsd.o

[Differential] [Updated, 63 lines] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

dim updated this revision to Diff 3130. dim added a comment. * Added new directories to BSD.debug.dist * Added explanatory comment to lib/Makefile CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1505?vs=3129&id=3130 BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1505 AF

[Differential] [Updated, 63 lines] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

dim updated this revision to Diff 3131. dim added a comment. Avoid specifically listing architectures. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1505?vs=3130&id=3131 BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1505 AFFECTED FILES etc/mtree/BSD.debug.dist et

[Differential] [Closed] D1505: Enable building libclang_rt (asan, ubsan and profile) for selected arches

dim closed this revision. dim updated this revision to Diff 3155. dim added a comment. Closed by commit rS277146 (authored by @dim). REVISION DETAIL https://reviews.freebsd.org/D1505 AFFECTED FILES head/etc/mtree/BSD.debug.dist head/etc/mtree/BSD.usr.dist head/lib/Makefile head/lib/lib

[Differential] [Accepted] D1663: elfcopy: Consider program name to start after last -

dim added a subscriber: dim. dim accepted this revision. dim added a reviewer: dim. dim added a comment. This revision is now accepted and ready to land. LGTM. REVISION DETAIL https://reviews.freebsd.org/D1663 To: emaste, dim Cc: dim, freebsd-toolchain _

[Differential] [Request, 6 lines] D1932: Remove the non-standard CC alias for c++

dim created this revision. dim added reviewers: emaste, theraven. dim added a subscriber: freebsd-toolchain. REVISION SUMMARY Since r34282 (almost 17 years ago) we have been carrying the alias 'CC' for 'c++, to invoke the C++ compiler. The original reason in O'Brien's commit message is "for

[Differential] [Updated, 8 lines] D1932: Remove the non-standard CC alias for c++

dim updated this revision to Diff 3900. dim added a comment. Added one more instance of CC.1. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1932?vs=3899&id=3900 BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D1932 AFFECTED FILES ObsoleteFiles.inc gnu/usr.bin/cc/c++

[Differential] [Request, 37 lines] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim created this revision. dim added reviewers: imp, bapt, rodrigc. dim added a subscriber: freebsd-toolchain. Herald added a subscriber: imp. REVISION SUMMARY When I tried replicating Craig Rodrigues's efforts at building head with the amd64-xtoolchain-gcc package, I noticed that during the b

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim added inline comments. INLINE COMMENTS Makefile.inc1:416 These are also unconditionally used in the previous block for WMAKENV, e.g.: ``` WMAKEENV+= CC="${XCC} ${XCFLAGS}" CXX="${XCXX} ${XCFLAGS} ${XCXXFLAGS}" \ DEPFLAGS="${DEPFLAGS}" \ CPP="$

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim added inline comments. BRANCH /head INLINE COMMENTS Makefile.inc1:416 I just looked for the LD="${LD}" assignments, and replaced them all. Maybe, for consistency, we should add OBJCOPY=${XOBJCOPY} for the powerpc case too, but I'm not sure if it's used at all in the powerpc build... RE

[Differential] [Updated, 38 lines] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim updated this revision to Diff 4577. dim added a comment. This revision now requires review to proceed. Add XOBJCOPY for powerpc too. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2187?vs=4554&id=4577 BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2187 AFFECTED FIL

[Differential] [Commented On] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim added inline comments. BRANCH /head INLINE COMMENTS Makefile.inc1:427 Btw, I'm not sure about AS here, since it might not even be used in the 32 bit stage, and also I'm not sure of the syntax. Is it -a32? REVISION DETAIL https://reviews.freebsd.org/D2187 To: dim, rodrigc, imp, bapt,

[Differential] [Closed] D2187: Ensure cross assembler, linker and objcopy are used for the build32 stage

dim closed this revision. dim updated this revision to Diff 4593. dim added a comment. Closed by commit rS280980 (authored by @dim). REVISION DETAIL https://reviews.freebsd.org/D2187 AFFECTED FILES head/Makefile.inc1 head/lib/csu/i386-elf/Makefile head/sys/boot/i386/boot2/Makefile head

[Differential] [Changed Subscribers] D2285: gcc 4.9.1 compilation fixes for aesni

dim added a subscriber: dim. INLINE COMMENTS sys/crypto/aesni/aesni_wrap.c:49 This part seems to be superfluous, since "aesencdec.h", just two files above this one, already defines _MM_MALLOC_INCLUDED. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: dim, freebsd-tool

[Differential] [Commented On] D2285: gcc 4.9.1 compilation fixes for aesni

dim added a comment. LGTM. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To

[Differential] [Updated, 8 lines] D1932: Remove the non-standard CC alias for c++

dim updated this revision to Diff 5715. dim added a comment. This revision now requires review to proceed. Herald added a subscriber: imp. Updated for changes in ObsoleteFiles.inc. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1932?vs=3900&id=57

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

dim added a comment. An exp-run was requested in bug 200477 . Out of ~25000 ports, only 5 failed, and those have been trivially fixed. The ports tree no longer requires CC to exist. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freeb

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

dim added a comment. @imp, so are your concerns now addressed? I didn't expect many ports to fail, and there were just a handful, three of which were actual errors (they indended to run ${CC}, but somebody typo'd CC instead). REPOSITORY rS FreeBSD src repository REVISION DETAIL https://re

[Differential] [Commented On] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

dim added inline comments. INLINE COMMENTS usr.sbin/ypbind/ypbind.c:952 Missing an & here? REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2690 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rodrigc, bapt, emaste, di

[Differential] [Commented On] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

dim added inline comments. INLINE COMMENTS usr.sbin/ypbind/ypbind.c:622 While we are here, can we please update this to a post-K&R definition? E.g.: static bool_t broadcast_result(caddr_t out, struct sockaddr_in *addr) REPOSITORY rS FreeBSD src repository REVISION DETAIL https:/

[Differential] [Accepted] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules

dim accepted this revision. dim added a comment. This revision has a positive review. For the rest, LGTM. REPOSITORY rS FreeBSD src repository BRANCH /head REVISION DETAIL https://reviews.freebsd.org/D2690 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/

[Differential] [Request, 27 lines] D3909: Get rid of the vendor suffix patch for clang.

dim created this revision. dim added reviewers: emaste, theraven. dim added a subscriber: freebsd-toolchain-list. Herald added a subscriber: imp. REVISION SUMMARY Get rid of the vendor suffix patch for clang, since it is very unlikely that anyone has ever used the suffix (which was mostly the

[Differential] D22061: Build toolchain components as dynamically linked executables by default

dim created this revision. dim added reviewers: emaste, imp, jhb, kib. Herald added a subscriber: bdrewery. Herald added a reviewer: manpages. REVISION SUMMARY Historically, we have built toolchain components such as cc, ld, etc as statically linked executables. One of the reasons being that