[Differential] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Thanks for taking a look Kristof, I believe all your points are valid. Thing is that all eventhandlers need a more thorough look. They don't work as they should; be it virtualized or not, be it a VIMAGE or GENERIC kernel. I am trying to take a look but I

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Sure, I will take a look REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: mmoll,

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. Hi from me as well, just want to say that I am here too and I am willing to work on this even if i have to do it scratch;) Please review:) Nikos REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES

[Differential] [Updated, 170 lines] D1944: PF and VIMAGE fixes

nvass-gmx.com updated this revision to Diff 6288. nvass-gmx.com added a comment. Updated to today's head branch. Please review CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1944?vs=5290id=6288 REVISION DETAIL https://reviews.freebsd.org/D1944 AFFECTED FILES sys/net/pfvar.h

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. In https://reviews.freebsd.org/D1944#47231, @rodrigc wrote: I tested this patch. # kldload pf # kldunload pf kldunload: can't unload file: Device busy The fact that the pf module cannot be unloaded was one of the reasons that @glebius used to back

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. This guilde is definitely invaluable, I have seen it. It would be great if we could move it in the source tree. Regarding PF it can be further simplified. I think the logic right is OK but there are many *init* functions for sure and some of these functions can

[Differential] [Updated, 197 lines] D1944: PF and VIMAGE fixes

nvass-gmx.com updated this revision to Diff 5290. nvass-gmx.com added a comment. Hi, Please review this. It updates the previous patch, with another way to unload pf. Eventhandlers are also touched, they should behave correctly now. CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1944: PF and VIMAGE fixes

nvass-gmx.com added a comment. ! In D1944#8, @glebius wrote: Nikos, acking that I see the patches. Right now I'm waiting for pf to stablize after recent patches to fragment handling. Kristof is working on the known problem. Meanwhile you can finish your patch moving from almost there to