Nah, let's take it easier for now.
Just leave the trace flags where they are in your diff, remove the
flags check so the debug mask works the way it is, and submit a diff
with _just_ the remaining debug flags line changes.
That way we know what the required changes are, it will only bug
people do
> -Message d'origine-
> De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
> de Adrian Chadd
> Envoyé : samedi 3 août 2013 21:50
> À : Cedric GROSS
> Cc : freebsd-wireless@freebsd.org
> Objet : Re: [IWN] Reviw split 2
>
> On 3 August 2013 12:43, Cedric GROSS wrote:
>
On 3 August 2013 12:43, Cedric GROSS wrote:
>> Ok, why'd you change the debug print macro to check if the debug flags
>> match the check, rather than if the debug flags are set in the check?
>>
>> ie
>>
>> (f) & (v)
>>
>> versus
>> ( (f) & (v) == (v) )
>>
>> ?
>
> It's for reducing tracing verbos
> De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
> de Adrian Chadd
> Envoyé : samedi 3 août 2013 21:37
> À : Cedric GROSS
> Cc : freebsd-wireless@freebsd.org
> Objet : Re: [IWN] Reviw split 2
>
> Ok, why'd you change the debug print macro to check if the debug flags
> match
Ok, why'd you change the debug print macro to check if the debug flags
match the check, rather than if the debug flags are set in the check?
ie
(f) & (v)
versus
( (f) & (v) == (v) )
?
I'd like to tidy up the debugging changes that are left in your source
file before we move onto the next bits.
> De : adrian.ch...@gmail.com [mailto:adrian.ch...@gmail.com] De la part
> de Adrian Chadd
> Envoyé : samedi 3 août 2013 20:20
> À : Cedric GROSS
> Cc : freebsd-wireless@freebsd.org
> Objet : Re: [IWN] Reviw split 2
>
> On 3 August 2013 04:23, Cedric GROSS wrote:
>
> >> Can you please post an up
On 3 August 2013 04:23, Cedric GROSS wrote:
>> Can you please post an updated diff against what's in -HEAD now?
>
> As requested here is full patch.
Thanks!
> It should. 4965 part was not impacted. But Don't you said that full patch
> break your 5100 ?
Yup, it is breaking it very quickly. I'll
