Author: cazfi
Date: Thu Aug 11 04:51:59 2016
New Revision: 33561

URL: http://svn.gna.org/viewcvs/freeciv?rev=33561&view=rev
Log:
Fixed compiler warnings about comparisons of unsigned type 'citizen' against 
negative values.

See bug #24948

Modified:
    trunk/common/city.c
    trunk/common/vision.c
    trunk/server/cityturn.c

Modified: trunk/common/city.c
URL: 
http://svn.gna.org/viewcvs/freeciv/trunk/common/city.c?rev=33561&r1=33560&r2=33561&view=diff
==============================================================================
--- trunk/common/city.c (original)
+++ trunk/common/city.c Thu Aug 11 04:51:59 2016
@@ -2336,7 +2336,6 @@
    * specialists or angry are unhappy. This is changed by luxuries and 
    * buildings later. */
   *unhappy = (size - spes - *content - *angry);
-  fc_assert_action(*unhappy >= 0, *unhappy = 0);
 
   /* No one is born happy. */
   *happy = 0;

Modified: trunk/common/vision.c
URL: 
http://svn.gna.org/viewcvs/freeciv/trunk/common/vision.c?rev=33561&r1=33560&r2=33561&view=diff
==============================================================================
--- trunk/common/vision.c       (original)
+++ trunk/common/vision.c       Thu Aug 11 04:51:59 2016
@@ -134,7 +134,6 @@
 void vision_site_size_set(struct vision_site *psite, citizens size)
 {
   fc_assert_ret(psite != NULL);
-  fc_assert_ret(size <= MAX_CITY_SIZE);
 
   psite->size = size;
 }

Modified: trunk/server/cityturn.c
URL: 
http://svn.gna.org/viewcvs/freeciv/trunk/server/cityturn.c?rev=33561&r1=33560&r2=33561&view=diff
==============================================================================
--- trunk/server/cityturn.c     (original)
+++ trunk/server/cityturn.c     Thu Aug 11 04:51:59 2016
@@ -962,7 +962,7 @@
 {
   int change = size - city_size_get(pcity);
 
-  fc_assert_ret_val(size >= 0 && size <= MAX_CITY_SIZE, TRUE);
+  fc_assert_ret_val(size <= MAX_CITY_SIZE, TRUE);
 
   if (change != 0 && reason != NULL) {
     script_server_signal_emit("city_size_change", 3,


_______________________________________________
Freeciv-commits mailing list
Freeciv-commits@gna.org
https://mail.gna.org/listinfo/freeciv-commits

Reply via email to