Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Eddie Anderson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > "Joan Creus" <[EMAIL PROTECTED]> wrote: > >http://bugs.freeciv.org/Ticket/Display.html?id=39831 > > >I think you mean EFT_VETERAN_BUILD. That sounds right. >I would try to make it shorter, though. >I think your suggestion is g

Re: [Freeciv-Dev] (PR#39830) 2.1.0 border expansion acquires destroyed city

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39830 > Per I. Mathisen wrote: > If you are thinking about the distinction between server view of the > world, and client views of the world (both contained within the > server), then yes, these view may be radically different due to fog of > war. Ho

Re: [Freeciv-Dev] (PR#39734) unittype translation need qualifier

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39734 > _("?unit:?unitclass:Land") Just one qualifier And we'll need some code, as this is likely to affect several things. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/lis

[Freeciv-Dev] (PR#39731) support for appended ruler titles

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39731 > Sounds easier and more fun than the border bugs I'll look at it tonight! ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39734) unittype translation need qualifier

2007-11-04 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39734 > > [dmarks - Sun Sep 30 07:53:23 2007]: > > On 9/29/07, Egor Vyscrebentsov <[EMAIL PROTECTED]> wrote: > > > > http://bugs.freeciv.org/Ticket/Display.html?id=39734 > > > > > Good daytime! > > > > Unittype strings have contradictions with rules

[Freeciv-Dev] (PR#39731) support for appended ruler titles

2007-11-04 Thread Daniel Markstedt
http://bugs.freeciv.org/Ticket/Display.html?id=39731 > > [wsimpson - Thu Sep 27 12:33:21 2007]: > > Daniel Markstedt wrote: > > On 9/27/07, Egor Vyscrebentsov <[EMAIL PROTECTED]> wrote: > >> So, what do you want? A function which will return string contains > >> leader name and title in proper o

[Freeciv-Dev] (PR#39565) NULL instead of valid impr_type in punittype->need_improvement

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39565 > As explained in PR#39385, this is exactly the kind of bug that PR#39553 was intended to catch. The old code didn't check for a valid improvement before using it. The fix was much easier than removing the useful log, or writing this report..

Re: [Freeciv-Dev] (PR#39828) 2.1.0 crash shared vision in send_tile_info()

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39828 > This patch has two parts. The quick and dirty solution is to treat terrain just like resources: when the pointer is NULL, send -1. That fixes the server crash. - info.type = plrtile->terrain->index; + info.type = plrtile->terrain

[Freeciv-Dev] (PR#39836) The freeciv theme only overwrites the gtk theme only particular

2007-11-04 Thread
http://bugs.freeciv.org/Ticket/Display.html?id=39836 > I use for my gtk-apps the Graphite Metal Theme. http://themes.freshmeat.net/projects/graphitemetal-gtk2 The civclient shows the Golden freeciv decoration only on tabs (Maps, Scientific, Cities,... as well as Travellers, News,...) and on th

[Freeciv-Dev] (PR#39834) get_embassy_status function removed(#13567), but there is call to it in win32 client

2007-11-04 Thread
http://bugs.freeciv.org/Ticket/Display.html?id=39834 > Call to get_embassy_status is left in gui-win32/plrdlg.c ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Joan Creus
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > I think you mean EFT_VETERAN_BUILD. I would try to make it shorter, though. I think your suggestion is great for the general manual, but here we are dealing with the individual unit help. The original sentence ("may become veteran throught tr

[Freeciv-Dev] (PR#39835) BUG: 2.2.0-test fix PR#39562 and PR#39565

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39835 > Committed S2_2 revision 13914. Committed trunk revision 13915. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39835) BUG: 2.2.0-test fix PR#39562 and PR#39565

2007-11-04 Thread William Allen Simpson
http://bugs.freeciv.org/Ticket/Display.html?id=39835 > Another problem found with PR#39562, this time on its stated purpose, better choice asserts. The assert() itself tests both ">= CT_NONE" and "!= CT_NONE" -- the previous version had commented out "!= CT_NONE". The assert() also doesn't use

Re: [Freeciv-Dev] (PR#39831) Training and combat

2007-11-04 Thread Eddie Anderson
http://bugs.freeciv.org/Ticket/Display.html?id=39831 > "Joan Creus" <[EMAIL PROTECTED]> wrote: > >http://bugs.freeciv.org/Ticket/Display.html?id=39831 > > >Good suggestion. I like it. Just one point: shouldn't it be "with Barracks" >instead of "with a Barracks"? I'm not a native English speaker,

Re: [Freeciv-Dev] (PR#39833) AutoReply: Citizen Manager cannot work with Gold deficit of more than 20.

2007-11-04 Thread Pavel N. Krivitsky
http://bugs.freeciv.org/Ticket/Display.html?id=39833 > This transaction appears to have no content This patch implements the suggestion, by only testing if surplus is less than minimal surplus if minimal surplus is greater than -20. This is, literally, a 1-line change. However, all the UIs would