Re: [Freeciv-Dev] (PR#40274) [Patch] connectmsg command

2008-06-13 Thread Jason Dorje Short
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > Madeline Book wrote: > http://bugs.freeciv.org/Ticket/Display.html?id=40274 > > >> [EMAIL PROTECTED] - Fri Jun 13 19:12:57 2008]: >> >> + notify_conn(dest, NULL, E_MESSAGE_WALL, >> > > It might be better to just send this as an unprefixed >

[Freeciv-Dev] (PR#40184) [editor] Toolbar GUI front-end preliminary work

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40184 > > [book - Wed Jun 11 20:43:45 2008]: > > > [EMAIL PROTECTED] - Wed Jun 11 19:15:25 2008]: > > > > - packhand.c:2368: handle_tile_info: Assertion > > `unit_list_size(ptile->units) == 0' failed. I were removing vision > > from tile with someb

[Freeciv-Dev] (PR#40267) [editor] icons

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40267 > File editor.png added to data/misc in S2_2 and trunk (r14748 and r14749 resp.). -- 大きなプロジェクトは一歩一歩作っています。 ___ Freeciv-dev mailing

[Freeciv-Dev] (PR#40269) [patch] civclient helper functions

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40269 > Committed to S2_2 (r14746). Committed to trunk (r14747). - 日本語勉強のために ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://m

[Freeciv-Dev] (PR#40264) [patch] Fix typo in spanish translation.

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40264 > I assume that's a yes. Committed to S2_1 (r14743). Committed to S2_2 (r14744). Committed to trunk (r14745). P.S. Sorry I forgot to include the PR# in the commit message for S2_1. I'll try not in the future. :/

[Freeciv-Dev] (PR#40274) Re: [Patch] connectmsg command

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > Compare with the warclient version which also supports % escape sequences and loading from a file. Commands: /wmessage /wfile Functions: welcome_message_command (server/stdinhand.c) welcome_file_command (server/stdinhand.c) generate_we

[Freeciv-Dev] (PR#40274) [Patch] connectmsg command

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > > [EMAIL PROTECTED] - Fri Jun 13 20:19:09 2008]: > > 2008/6/13 Madeline Book: > > > > Compare with the warclient version which also supports % > > escape sequences and loading from a file. > > It seems to send message line by line. I guess

Re: [Freeciv-Dev] (PR#40274) Re: [Patch] connectmsg command

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > 2008/6/13 Madeline Book: > > Compare with the warclient version which also supports % > escape sequences and loading from a file. It seems to send message line by line. I guess it's never used as popup? (or there would be separate popup for

[Freeciv-Dev] (PR#40274) [Patch] connectmsg command

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > > [EMAIL PROTECTED] - Fri Jun 13 19:12:57 2008]: > > + notify_conn(dest, NULL, E_MESSAGE_WALL, > It might be better to just send this as an unprefixed "chat" message. E_MESSAGE_WALL usually creates a popup (and if users configure it to not p

[Freeciv-Dev] (PR#40274) [Patch] connectmsg command

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40274 > This patch adds /connectmsg command that can be used to set message to display new clients connecting to server. This version is for S2_2 & TRUNK. I have been using S2_1 version in my public server for custom rulesets to inform newcomers a

[Freeciv-Dev] (PR#38372) [Bug] AI tries to trade unreachable techs

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=38372 > > [EMAIL PROTECTED] - Fri Jun 13 18:05:10 2008]: > > 2008/6/13 Madeline Book: > > > > How about player_tech_is_reachable(player, tech) ? Or substitute > > "tech" for whatever is the usual name for technologies in the > > code. > > In other

Re: [Freeciv-Dev] (PR#38372) [Bug] AI tries to trade unreachable techs

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=38372 > 2008/6/13 Madeline Book: > > How about player_tech_is_reachable(player, tech) ? Or substitute > "tech" for whatever is the usual name for technologies in the > code. In other parts of the code word "reachable" means that all parent techs a

[Freeciv-Dev] (PR#38372) [Bug] AI tries to trade unreachable techs

2008-06-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=38372 > > [EMAIL PROTECTED] - Fri Jun 13 16:46:22 2008]: > > 2007/3/18 Marko Lindqvist: > > > > 1: Treaty: The White Horde can't have tech Asian Architecture > > Per's patch updated for S2_2. > > Function to check if tech is ever available for p

[Freeciv-Dev] (PR#40273) [Patch] Correct copypaste comment

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40273 > Function header of can_player_build_improvement_now() is identical to header of can_player_build_improvement_later() Fix attached. - ML diff -Nurd -X.diff_ignore freeciv/common/improvement.c freeciv/common/improvement.c --- freeciv/co

Re: [Freeciv-Dev] (PR#38372) [Bug] AI tries to trade unreachable techs

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=38372 > 2007/3/18 Marko Lindqvist: > > 1: Treaty: The White Horde can't have tech Asian Architecture Per's patch updated for S2_2. Function to check if tech is ever available for player has been renamed as player_invention_is_ready() ?? Unless s

Re: [Freeciv-Dev] (PR#40268) [Patch] Backport some configure fixes to S2_1

2008-06-13 Thread Marko Lindqvist
http://bugs.freeciv.org/Ticket/Display.html?id=40268 > 2008/6/12 Marko Lindqvist: > > $subject > > I took diff between S2_1 and S2_2 configure.ac and backported changes > that fix bugs, even if minor ones. This is mainly for keeping S2_1 and > S2_2 & TRUNK build similar enough that same test bu