[Freeciv-Dev] [bug #15325] Help: misc corrections to autogenerated help text, e.g. "near" for REQ_RANGE_ADJACENT

2010-02-09 Thread Jacob Nevins
Additional Item Attachment, bug #15325 (project freeciv): File name: S2_2-effects-help-misc-ter.diff Size:8 KB ___ Reply to this item at: ___ Message sent via/

[Freeciv-Dev] [bug #15325] Help: misc corrections to autogenerated help text, e.g. "near" for REQ_RANGE_ADJACENT

2010-02-09 Thread Jacob Nevins
Follow-up Comment #2, bug #15325 (project freeciv): And yet more, e.g. missed plural in technology help (plus some idiom/typographical fixes that will just annoy me if not fixed before string freeze). (file #8038) ___ Additional Item Attac

[Freeciv-Dev] [patch #1435] Aztec fixes

2010-02-09 Thread Jacob Nevins
Follow-up Comment #4, patch #1435 (project freeciv): I think this change causes the following warning with civ1/civ2 ruleset. It's probably harmless. "data/civ2/nations.ruleset" [nation_aztec] cities: terrain "lake" not found; skipping it. last message repeated 2 times _

[Freeciv-Dev] [bug #15325] Help: misc corrections to autogenerated help text, e.g. "near" for REQ_RANGE_ADJACENT

2010-02-09 Thread Jacob Nevins
Update of bug #15325 (project freeciv): Summary: "Near" in description of effects for REQ_RANGE_ADJACENT is too vague => Help: misc corrections to autogenerated help text, e.g. "near" for REQ_RANGE_ADJACENT ___ Follow-up C

[Freeciv-Dev] [patch #1401] [Metaticket] Improve in-game help

2010-02-09 Thread Jacob Nevins
Update of patch #1401 (project freeciv): Depends on: => bugs #15325 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [bug #15325] "Near" in description of effects for REQ_RANGE_ADJACENT is too vague

2010-02-09 Thread Jacob Nevins
URL: Summary: "Near" in description of effects for REQ_RANGE_ADJACENT is too vague Project: Freeciv Submitted by: jtn Submitted on: Wednesday 10/02/10 at 00:16 Category: docs S

[Freeciv-Dev] [bug #15324] Line feed not escaped in help text

2010-02-09 Thread Jacob Nevins
Update of bug #15324 (project freeciv): Category: general => docs Assigned to:None => jtn ___ Reply to this item at:

[Freeciv-Dev] [bug #15324] Line feed not escaped in help text

2010-02-09 Thread Joan Creus
URL: Summary: Line feed not escaped in help text Project: Freeciv Submitted by: jcreus Submitted on: Tuesday 02/09/10 at 23:05 Category: general Severity: 3 - Normal

[Freeciv-Dev] [bug #15323] server crash in tile_city() at common/tile.c:76

2010-02-09 Thread Andreas
Follow-up Comment #1, bug #15323 (project freeciv): a different backtrace produced by another crash from the same savegame, common part is "ferry boat" #0 0x0042aba7 in aiferry_find_boat (punit=0x1d24cf0, cap=1, path=) at ../../ai/aiferry.c:429 #1 0x00420bb3 in find_something_

[Freeciv-Dev] [bug #15323] server crash in tile_city() at common/tile.c:76

2010-02-09 Thread Andreas
URL: Summary: server crash in tile_city() at common/tile.c:76 Project: Freeciv Submitted by: anbe Submitted on: Tuesday 02/09/2010 at 21:54 Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread pepeto
Update of patch #1460 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #5: Good patch! ___ Reply to this item a

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #4, patch #1460 (project freeciv): OK; another version (I first had to find the correct place within the patch) (file #8032) ___ Additional Item Attachment: File name: version3-20100209-trunk-add-information-to-the

[Freeciv-Dev] [bug #15301] Rework trade route messages

2010-02-09 Thread Jacob Nevins
Update of bug #15301 (project freeciv): Status: In Progress => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15301] Rework trade route messages

2010-02-09 Thread Jacob Nevins
Update of bug #15301 (project freeciv): Status: Ready For Test => In Progress ___ Reply to this item at: ___ Message sen

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread pepeto
Follow-up Comment #15, patch #1284 (project freeciv): And there is already an item for this: bug #14311 ___ Reply to this item at: ___ Message posté via/par Gna

[Freeciv-Dev] [patch #1235] [Metaticket] variable city radii

2010-02-09 Thread Matthias Pfafferodt
) ___ Additional Item Attachment: File name: 20100209-cityradius_sq.diffSize:124 KB ___ Reply to this item at: <http://gna.org/patch/?1235> ___ Nachricht geschic

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

2010-02-09 Thread pepeto
Update of patch #1444 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #10: Nice patch. ___ Reply to this item

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread pepeto
Follow-up Comment #3, patch #1460 (project freeciv): Looks good for me. Unfortunately, size_t variable doesn't fir "%lu" format in all configuration. You need to cast them to (unsigned long) to keep compatibility. ___ Reply to this item

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #14, patch #1284 (project freeciv): > You could have a look to the /unloadmap command. But I am not > sure the code around is exactly the same. I don't think I will have this much time in the near future so I will stay with the open patches I have at the moment ... __

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #9, patch #1444 (project freeciv): update patch; reject_msg is initialised as char reject_msg[258] = ""; ___ Reply to this item at: ___ Nach

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #1460 (project freeciv): updated patch; the first invalid character is shown (file #8030) ___ Additional Item Attachment: File name: version2-20100209-trunk-add-information-to-the-reject_msg-within

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread pepeto
Follow-up Comment #13, patch #1284 (project freeciv): > so there is more work needed; was something like this available > in warserver? You could have a look to the /unloadmap command. But I am not sure the code around is exactly the same. _

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #12, patch #1284 (project freeciv): an 'reset map' is really a thing for another patch. I tried it using * map_free(); map_init(): => crash Program terminated with signal 11, Segmentation fault. #0 0x00555c32 in player_invention_set (pplayer=, tech=0, value=TECH_KNOW

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto
Follow-up Comment #8, bug #15312 (project freeciv): Seems good! ___ Reply to this item at: ___ Message posté via/par Gna! http://gna.org/ __

[Freeciv-Dev] [bug #15297] Trireme behavior in 2.2

2010-02-09 Thread pepeto
Update of bug #15297 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #7, bug #15312 (project freeciv): yet another version (S2_2 using RETURN_VAL_IF_FAIL()) (file #8029) ___ Additional Item Attachment: File name: version3-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch Size:0 KB

[Freeciv-Dev] [bug #15255] update make_island() - generator 3

2010-02-09 Thread pepeto
Update of bug #15255 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

2010-02-09 Thread pepeto
Follow-up Comment #9, bug #15305 (project freeciv): > Maybe nothing, I just tried to make a patch like you did and > server crashed on map generation... But I didn't investigate > more. I may have done a mistake in my patch, I don't know where. I tested your patch with success. However, it sho

[Freeciv-Dev] [bug #15309] fix tmap_y2str(); mixed up ysize and xsize

2010-02-09 Thread pepeto
Follow-up Comment #4, bug #15309 (project freeciv): > I will read the web page now and will be carefull in the future. No problem, you are welcome. Your work is very appreciated. ___ Reply to this item at:

[Freeciv-Dev] [bug #15309] fix tmap_y2str(); mixed up ysize and xsize

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #3, bug #15309 (project freeciv): > According to the commit rules, you should normally wait > minimum 36h before commit... This is not a problem for this > item, but be vigilant for future... I did not know this page. As this was only a small correction of my own error I did i

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread pepeto
Update of patch #1284 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #11: > This would be an additional patch. Then, in another item...

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread pepeto
Follow-up Comment #10, patch #1284 (project freeciv): > Is map_free() enough for this? I have no idea about it. Maybe additional map_init() would be needed. That's so sad that the game and map structures are absolutely not object-deigned...

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

2010-02-09 Thread pepeto
Follow-up Comment #8, bug #15305 (project freeciv): > Pepeto, what am I missing? Maybe nothing, I just tried to make a patch like you did and server crashed on map generation... But I didn't investigate more. ___ Reply to this item at:

[Freeciv-Dev] [bug #15322] fix global_warming() and nuclear_winter() [again]

2010-02-09 Thread pepeto
Update of bug #15322 (project freeciv): Priority: 5 - Normal => 7 - High Status:None => Ready For Test Assigned to:None => pepeto _

[Freeciv-Dev] [bug #15309] fix tmap_y2str(); mixed up ysize and xsize

2010-02-09 Thread pepeto
Follow-up Comment #2, bug #15309 (project freeciv): According to the commit rules , you should normally wait minimum 36h before commit... This is not a problem for this item, but be vigilant for future... __

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread pepeto
Follow-up Comment #6, bug #15312 (project freeciv): > That's due to the fact that log_assert_ret_val() is only defined > within trunk. For S2_2 assert() will be needed ... (S2_2 can use RETURN_VAL_IF_FAIL()). ___ Reply to this item at:

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #9, patch #1284 (project freeciv): > Or maybe it should be possible to do it from the /reset game > command? reset game restores the settings to the values used at the start of the game > Maybe a /reset map would be required to unload a scenario? This would be an additional p

[Freeciv-Dev] [patch #1461] fix duplicated check for min/max integer value

2010-02-09 Thread pepeto
Update of patch #1461 (project freeciv): Status:None => Ready For Test Assigned to:None => pepeto ___ Follow-up Comment #1: Good patch!

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread pepeto
Update of patch #1460 (project freeciv): Assigned to:None => pepeto ___ Follow-up Comment #1: Maybe I would have set a string to store only the forbidden characters. Example: the user set

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

2010-02-09 Thread pepeto
Follow-up Comment #8, patch #1444 (project freeciv): > Not actually... The real stuff is that you cannot use a string > returned by a function directly. (but gettext() has a special > case). Actually, cannot be used as a format a unknown string in general, because the string could contain '%' ch

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

2010-02-09 Thread pepeto
Follow-up Comment #7, patch #1444 (project freeciv): > Some times ago there was a discussion to include the c-format > string ("%s") in all functions. Not actually... The real stuff is that you cannot use a string returned by a function directly. (but gettext() has a special case). Personally

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread pepeto
Update of patch #1284 (project freeciv): Assigned to: cazfi => pepeto ___ Follow-up Comment #8: Maybe a _/reset map_ would be required to unload a scenario? Or maybe it should be possible t

[Freeciv-Dev] [patch #1200] game settings can be locked by the ruleset

2010-02-09 Thread pepeto
Update of patch #1200 (project freeciv): Status: In Progress => Ready For Test ___ Reply to this item at: ___ Message po

[Freeciv-Dev] [patch #1453] Benin nation

2010-02-09 Thread Daniel Markstedt
Follow-up Comment #1, patch #1453 (project freeciv): Flag attached. Adapted from a Public Domain image drawn by Wikimedia user Orange Tuesday. http://en.wikipedia.org/wiki/File:Flag_of_the_Benin_Empire.svg (file #8024) ___ Additional Item

[Freeciv-Dev] [patch #1457] Colombia fixes

2010-02-09 Thread Daniel Markstedt
Update of patch #1457 (project freeciv): Status: Need Info => Ready For Test ___ Follow-up Comment #3: Thanks for the clarification. I think this patch would do it. Let's revisit Latin American ru

[Freeciv-Dev] [patch #1451] Improvements to Canadian nation

2010-02-09 Thread Daniel Markstedt
Update of patch #1451 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1450] Laotian cities overhaul

2010-02-09 Thread Daniel Markstedt
Update of patch #1450 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1443] Chola fix

2010-02-09 Thread Daniel Markstedt
Update of patch #1443 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1436] Dutch fixes

2010-02-09 Thread Daniel Markstedt
Update of patch #1436 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #1435] Aztec fixes

2010-02-09 Thread Daniel Markstedt
Update of patch #1435 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #15293] Italy scenario doesn't load correctly

2010-02-09 Thread Daniel Markstedt
Update of bug #15293 (project freeciv): Category:None => general Status: Ready For Test => Fixed Open/Closed:Open => Closed

[Freeciv-Dev] [bug #15305] memory leak in map_allocate

2010-02-09 Thread anonymous
Follow-up Comment #7, bug #15305 (project freeciv): The server code is OK. * The server calls server_game_free right before server_game_init in server/stdinhand.c:load_command(). This frees any old game data which may exist before loading a new game. Note that all code paths which load saved g

[Freeciv-Dev] [bug #15314] Client crashes after setting worklist to cities

2010-02-09 Thread Michael Kozielski
Follow-up Comment #2, bug #15314 (project freeciv): I have compiled it and now it runs without a crash. ___ Reply to this item at: ___ Message sent via/by Gna!

[Freeciv-Dev] [bug #15322] fix global_warming() and nuclear_winter() [again]

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #1, bug #15322 (project freeciv): > it should be valid for S2_1, S2_2 and trunk S2_1 needs its own patch ... (file #8021) ___ Additional Item Attachment: File name: 20100209-S2_1-fix-global_warm

[Freeciv-Dev] [bug #15322] fix global_warming() and nuclear_winter() [again]

2010-02-09 Thread Matthias Pfafferodt
Update of bug #15322 (project freeciv): Depends on: => bugs #15258 ___ Reply to this item at: ___ Nachricht g

[Freeciv-Dev] [bug #15322] fix global_warming() and nuclear_winter() [again]

2010-02-09 Thread Matthias Pfafferodt
ivserver.c:372 ___ File Attachments: --- Date: Dienstag 09.02.2010 um 17:13 Name: 20100209-trunk-fix-global_warming-nuclear_winter.patch Size: 2kB By: syntron <http://gna.org/bugs/download

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #5, bug #15312 (project freeciv): updated version for trunk * fix the check; it has to be ptile != NULL (file #8019) ___ Additional Item Attachment: File name: 20100209-trunk-add-check-for-ptile-NULL-within

[Freeciv-Dev] [bug #15320] fix gui-xaw for libpng14

2010-02-09 Thread Vijay Kiran Kamuju
URL: Summary: fix gui-xaw for libpng14 Project: Freeciv Submitted by: infyquest Submitted on: Tuesday 02/09/2010 at 10:40 Category: client-xaw Severity: 4 - Important

[Freeciv-Dev] [bug #15309] fix tmap_y2str(); mixed up ysize and xsize

2010-02-09 Thread Matthias Pfafferodt
Update of bug #15309 (project freeciv): Open/Closed:Open => Closed ___ Follow-up Comment #1: committed as svn revision 16763 ___ R

[Freeciv-Dev] [bug #14944] fogged borders are not restored from a savegame

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #8, bug #14944 (project freeciv): I checked again; this bug is only valid for trunk ... ___ Reply to this item at: ___ Nachricht geschickt von

[Freeciv-Dev] [bug #15312] add check for ptile == NULL within map_colatitude()

2010-02-09 Thread Matthias Pfafferodt
he attached patch for S2_2 (file #8018) ___ Additional Item Attachment: File name: 20100209-S2_2-add-check-for-ptile-NULL-within-map_colatitude.patch Size:0 KB ___ Reply to this item a

[Freeciv-Dev] [patch #1301] Metaticket: settings patch series

2010-02-09 Thread Matthias Pfafferodt
Update of patch #1301 (project freeciv): Depends on: => patch #1461 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1301] Metaticket: settings patch series

2010-02-09 Thread Matthias Pfafferodt
Update of patch #1301 (project freeciv): Depends on: => patch #1460 ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [patch #1461] fix duplicated check for min/max integer value

2010-02-09 Thread Matthias Pfafferodt
etails: additional fix error message for booleans ___ File Attachments: --- Date: Dienstag 09.02.2010 um 10:21 Name: 20100209-trunk-fix-duplicated-check-for-min-max-integer-value.patch Siz

[Freeciv-Dev] [patch #1460] add information to the reject_msg within settings.c

2010-02-09 Thread Matthias Pfafferodt
etails: ___ File Attachments: --- Date: Dienstag 09.02.2010 um 10:20 Name: 20100209-trunk-add-information-to-the-reject_msg-within-settings.c.patch Size: 5kB By: syntron <http:

[Freeciv-Dev] [patch #1444] implement setting_log() / setting_error() functions

2010-02-09 Thread Matthias Pfafferodt
was a discussion to include the c-format string ("%s") in all functions. Therefore I kept it. Attached is an updated patch. (file #8015) ___ Additional Item Attachment: File name: 20100209-trunk-replace-char-rejec

[Freeciv-Dev] [patch #1284] update reset command

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #7, patch #1284 (project freeciv): rebased and updated patch (file #8014) ___ Additional Item Attachment: File name: 20100209-trunk-update-reset-command.patch Size:19 KB

[Freeciv-Dev] [patch #1200] game settings can be locked by the ruleset

2010-02-09 Thread Matthias Pfafferodt
Follow-up Comment #11, patch #1200 (project freeciv): rebased and update patch; one minor correction: check setting_locked() before setting_is_changeable() (file #8013) ___ Additional Item Attachment: File name: 20100209-trunk-game

Re: [Freeciv-Dev] [Freeciv-i18n] Release update

2010-02-09 Thread Daniel Markstedt
On Tue, Feb 9, 2010 at 12:35 AM, Jacob Nevins <0jacobnk.fc...@chiark.greenend.org.uk> wrote: > Daniel Markstedt writes: >> We have very nearly resolved all bugs targeted for 2.2.0 final >> release. As a result, a Release Candidate for 2.2.0 scheduled is >> planned to be released on February 14. > >