[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #12, patch #3001 (project freeciv): > Here's one addressing issues you found. As a crash fix probably > causing problems for many users will commit immediately. Do you know why it crashs for some and for others not? ___ R

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #10, patch #3001 (project freeciv): > OK, don't think it's that store after all. Well, as condition is for() was broken, it ended up storing to traits[-1]. > (No patch file as it's past my bedtime) Here's one addressing issues you found. As a crash fix probably causing proble

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #9, patch #3001 (project freeciv): OK, don't think it's that store after all. Error continued to happen with -O0. Think it's this in ruleset_load_traits(): for (tr = trait_begin(); trait_names[tr] != NULL && tr < trait_end(); tr = trait_next(tr)) { The specenum iterators p

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #8, patch #3001 (project freeciv): Seems to be the store to traits[tr] where it barfs. I can't see why either. Haven't tried winding down optimisation yet, but it seems pretty stable over perturbations to source code (e.g. changing load_ruleset_nations:default_traits[] to a hard

[Freeciv-Dev] [patch #2928] Section to README.packaging about 2.3.0 to 2.3.1 upgrade

2011-11-08 Thread Marko Lindqvist
Update of patch #2928 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3011] Add cimpletoon to debian packet

2011-11-08 Thread Marko Lindqvist
Update of patch #3011 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3038] Qt module installer

2011-11-08 Thread Marko Lindqvist
URL: Summary: Qt module installer Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 01:56:32 AM EET Category: module installer Priority: 5 - Normal

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #7, patch #3001 (project freeciv): CAnnot reproduce and see no obvious error by reading sources. Does it happen if you disable optimization with CFLAGS="-g -O0"? If so, you may get more informative backtrace from that kind of compilation, without compiler inlining and omitting s

[Freeciv-Dev] [patch #3037] can_build_road()

2011-11-08 Thread Marko Lindqvist
URL: Summary: can_build_road() Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 01:42:57 AM EET Category: general Priority: 5 - Normal Statu

[Freeciv-Dev] [patch #3007] City center roads subject to terrain restrictions

2011-11-08 Thread Marko Lindqvist
Update of patch #3007 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3036] specenum _size()

2011-11-08 Thread Marko Lindqvist
URL: Summary: specenum _size() Project: Freeciv Submitted by: cazfi Submitted on: Wed 09 Nov 2011 01:00:11 AM EET Category: general Priority: 3 - Low Status:

[Freeciv-Dev] [patch #3025] Prepare savegame2.c for 2.5 development

2011-11-08 Thread Marko Lindqvist
Update of patch #3025 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #6, patch #3001 (project freeciv): I can not confirm - svn 20513 is running fine for me (did a short test game). As 'bus error' is something which could be connected to the environment here some data: freeciv trunk (svn20513) compile with '--enable-debug=checks --enable-client=

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #5, patch #3001 (project freeciv): I've confirmed that r20500 is the commit where it starts dying for me. Not attempted to work out why it's dying. ___ Reply to this item at: _

[Freeciv-Dev] Modifying svn commit message

2011-11-08 Thread Jacob Nevins
Marko Lindqvist writes: > How was it possible to modify commit messages after commit? The file > commit messages are read was not correclty updated for this, so it got > message of previous commit. This is patch #3001, not #3014. Short answer: it's not possible unless an svn administrator does it

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Jacob Nevins
Follow-up Comment #4, patch #3001 (project freeciv): On a checkout of latest trunk (r20513), the server dies immediately with a bus error for me. Since it dies in ruleset_load_traits(), I'm assuming this checkin (r20500 ) is somehow impl

[Freeciv-Dev] [bug #18776] /remove perhaps faulty

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #18, bug #18776 (project freeciv): any update to the status of this bug? I can not reproduce a segfault with the patch applied. I will commit it for 2.3.1 if there are no comments. ___ Reply to this item at:

[Freeciv-Dev] [bug #18886] fix loading of shuffle information

2011-11-08 Thread Matthias Pfafferodt
Update of bug #18886 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #18880] assertion 'adv->phase_is_initialized' failed.

2011-11-08 Thread Matthias Pfafferodt
Update of bug #18880 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed Planned Release: 2.3.1?, 2.4.0 => 2.4.0 _

[Freeciv-Dev] [patch #2883] [lua116] lua function to save a game (as 'manual' save)

2011-11-08 Thread Matthias Pfafferodt
Update of patch #2883 (project freeciv): Status: In Progress => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #18875] map.c: 3x assertion failed

2011-11-08 Thread Matthias Pfafferodt
Update of bug #18875 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => syntron Open/Closed:Open => Closed

[Freeciv-Dev] [bug #18641] allow remove command for access level >= ADMIN in running games

2011-11-08 Thread Matthias Pfafferodt
Update of bug #18641 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #3, patch #3001 (project freeciv): The problem in comment #2 is solved. Part of the svn checkout was missing. ___ Reply to this item at: ___ N

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #2, patch #3001 (project freeciv): is it correct that aitraits.h is included by plrhand.c? This breaks build as the AI header files are not available for the server ... ___ Reply to this item at:

[Freeciv-Dev] [bug #18835] Make many diplomacy dialogs easier to manage (e.g. using vertical tabs)

2011-11-08 Thread Matthias Pfafferodt
Follow-up Comment #35, bug #18835 (project freeciv): I think this patch set is working fine and an improvement if playing with a large number of nations. Now to the question: there and when should this patch be applied? * S2_3: Not for 2.3.1 but for the next release - so after 2.3.1 has taged.

[Freeciv-Dev] [patch #3018] List of unit classes road is native to

2011-11-08 Thread Marko Lindqvist
Update of patch #3018 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [bug #18922] Server address binding fails

2011-11-08 Thread anonymous
Follow-up Comment #10, bug #18922 (project freeciv): Well, through "printf debugging" I came up with this: it's not a valid patch, as it still is mostly "printf debugging", but the two technical changes (or at least one of them) make the server work again. In a way it might be a variation of the

[Freeciv-Dev] [bug #18922] Server address binding fails

2011-11-08 Thread anonymous
Follow-up Comment #9, bug #18922 (project freeciv): Well, I think I should have been more explicit about were I put those debug lines: they are called when bind *already* failed, when 'fc_get_errno() == EADDRNOTAVAIL' right above 'fc_closesocket(s)'. ___

[Freeciv-Dev] Fwd: [Freeciv-commits] r20500 - in /trunk: ai/Makefile.am ai/aitraits.c ai/aitraits.h common/Makefile.am common/nation.c common/nation.h common/player.c common/player.h common/traits.h s

2011-11-08 Thread Marko Lindqvist
How was it possible to modify commit messages after commit? The file commit messages are read was not correclty updated for this, so it got message of previous commit. This is patch #3001, not #3014. -- Forwarded message -- From: Marko Lindqvist Date: 8 November 2011 19:11 Subje

[Freeciv-Dev] [patch #3001] AI traits framework

2011-11-08 Thread Marko Lindqvist
Update of patch #3001 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed ___

[Freeciv-Dev] [patch #3035] my_uname() -> fc_uname()

2011-11-08 Thread Marko Lindqvist
URL: Summary: my_uname() -> fc_uname() Project: Freeciv Submitted by: cazfi Submitted on: Tue 08 Nov 2011 06:58:05 PM EET Category: bootstrap Priority: 5 - Normal

[Freeciv-Dev] [bug #18922] Server address binding fails

2011-11-08 Thread Marko Lindqvist
Additional Item Attachment, bug #18922 (project freeciv): File name: NullifyFNFPHints_18922.diffSize:0 KB ___ Reply to this item at: ___ Message sent via/b

[Freeciv-Dev] [bug #18922] Server address binding fails

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #8, bug #18922 (project freeciv): Here's patch for the find_next_free_port() part. I'll commit this in a couple of days even if no fix for the other part has been found. Do you have IPV&_V6ONLY defined, or not? Maybe you are trying to bind IPv4 address both explicitly and impli

[Freeciv-Dev] [bug #18243] map window displayed incorrectly with gtk+ 2.24.5 (and Ubuntu Oneiric's 2.24.6)

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #29, bug #18243 (project freeciv): > at first running freeciv built against gtk3 resulted in an > immediate segfault - that changed after I added 'if (f)' check > in load_default_files(void) This is now bug #18952 It turns out that freeciv starts to act funny when ever someth

[Freeciv-Dev] [bug #18952] gtk-client crashes when no usable theme available

2011-11-08 Thread Marko Lindqvist
URL: Summary: gtk-client crashes when no usable theme available Project: Freeciv Submitted by: cazfi Submitted on: Tue 08 Nov 2011 06:36:06 PM EET Category: client Severity: 3

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

2011-11-08 Thread Marko Lindqvist
Follow-up Comment #58, patch #2715 (project freeciv): Please read through CodingStyle document, and check "final" versions of your patches, so I don't need to spend hours fixing simple style issues and obvious oversights with your future patches. - CodingStyle corrections - Renamed some variable

Re: [Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

2011-11-08 Thread Gilles J. Seguin
On Mon, 2011-11-07 at 17:53 +0100, anonymous wrote: > Follow-up Comment #50, patch #2715 (project freeciv): > > After a bit checking, I came up with that better solution - if client can > change view, overview is invalidated on mapview scroll change. > > Implemented in this version. > > But I've

[Freeciv-Dev] [bug #18922] Server address binding fails

2011-11-08 Thread anonymous
Follow-up Comment #7, bug #18922 (project freeciv): Well, I've read a couple manpages and added char hbuf[NI_MAXHOST], sbuf[NI_MAXSERV]; if (getnameinfo(&paddr->saddr, sockaddr_size(paddr), hbuf, sizeof(hbuf), sizeof(sbuf), NI_NUMERICHOST | NI_NUMERICSERV) == 0) printf("host=%s, serv=%sn", hb