[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #3, bug #24133 (project freeciv): > The activity Railroad is removed from every unit in the > savegame. The activity road is preserved. Those are not separate activities in 2.5 & up, but generic road building activities with specified target road.

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Jordi Negrevernis i Font
Follow-up Comment #2, bug #24133 (project freeciv): I was not accurate. Sorry. The activity Railroad is removed from every unit in the savegame. The activity road is preserved. I attach a savegame. Thanks (file #26020) ___ Additional

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #5, bug #24133 (project freeciv): Player technologies are not loaded when unit activities are sanity checked -> player is not known to know required techs. ___ Reply to this item at:

[Freeciv-Dev] [bug #23971] Savegames have invalid research targets and goals for teams

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #2, bug #23971 (project freeciv): Actually this is about the same loading sequence problem as bug #24133. Player is loaded before his/her research. ___ Reply to this item at:

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #6, bug #24133 (project freeciv): Another symptom: bug #23971 ___ Reply to this item at: ___ Message sent via/by Gna! http://gna.org/

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #4, bug #24133 (project freeciv): Savegame loading cancels several "Road"/"Railroad" and one "Mine"/"Oil Well" activities. Attached is patch to at least improve logging of these. (S2_6 version - TRUNK will need same to savegame3.c too) (file #26021)

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist
Update of bug #24133 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #7: Fix (file #26022, file #26023) ___

[Freeciv-Dev] [patch #6684] Cleanup includes

2015-12-15 Thread Marko Lindqvist
URL: Summary: Cleanup includes Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 10:56:34 AM EET Category: client-gtk-3.0 Priority: 5 - Normal

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Jacob Nevins
Update of bug #24133 (project freeciv): Release: => S2_6 svn Planned Release: => 2.6.0, 3.0.0 ___ Follow-up Comment #1: Can't reproduce

[Freeciv-Dev] [patch #6685] gtk3x-client to use its own options

2015-12-15 Thread Marko Lindqvist
URL: Summary: gtk3x-client to use its own options Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 01:36:03 PM EET Category: client-gtk-3+ Priority: 5 -

[Freeciv-Dev] [bug #24135] 1: in is_valid_dir() [map.c::1239]: assertion 'direction8_is_valid(dir)' failed

2015-12-15 Thread Jacob Nevins
Follow-up Comment #11, bug #24135 (project freeciv): I wrote: >> dir_to_next_pos = 4294967295, dir_to_here = 134287504} > Directions look uninitialised. My mistake. dir_to_next_pos is 0x (i.e., -1). dir_to_here is 0x08011090, which I don't know where it came from. But valgrind on code

[Freeciv-Dev] [patch #6494] Assumed resolution option

2015-12-15 Thread Marko Lindqvist
Update of patch #6494 (project freeciv): Planned Release: 2.5.x, 2.6.0, 3.0.0 => 2.5.3, 2.6.0, 3.0.0 ___ Reply to this item at: ___ Message

[Freeciv-Dev] [patch #6057] gtk3x-client

2015-12-15 Thread Marko Lindqvist
Update of patch #6057 (project freeciv): Status:None => Ready For Test ___ Follow-up Comment #1: Patch to add gtk3x-client to the build. (If someone wants to check things out in advance, WIP

[Freeciv-Dev] [bug #24172] SDL/2 sub-projects headers not found

2015-12-15 Thread Marko Lindqvist
Follow-up Comment #3, bug #24172 (project freeciv): - Also the other guis include SDL.h to gui_main.c|cpp for sound support. Fix also those includes. (file #26012, file #26013, file #26014) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #6688] ScenarioReserved player flag

2015-12-15 Thread Marko Lindqvist
URL: Summary: ScenarioReserved player flag Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 10:38:37 PM EET Category: general Priority: 5 - Normal

[Freeciv-Dev] [bug #24181] When nation name is picked from leader names, pick randomly if more than one nation shares a leader name

2015-12-15 Thread Jacob Nevins
URL: Summary: When nation name is picked from leader names, pick randomly if more than one nation shares a leader name Project: Freeciv Submitted by: jtn Submitted on: Tue 15 Dec 2015 12:48:55 UTC

[Freeciv-Dev] [bug #23791] Ruleset nation leader uniqueness check doesn't work and is quadratic in total number of leader names

2015-12-15 Thread Jacob Nevins
Update of bug #23791 (project freeciv): Status: Need Info => Ready For Test ___ Follow-up Comment #7: Patches. This improves trunk server startup time from 2.629s to 0.759s on my machine. I expect

[Freeciv-Dev] [task #7961] Make copy of gtk3-client as base for gtk3x-client development

2015-12-15 Thread Marko Lindqvist
Update of task #7961 (project freeciv): Depends on: => patch #6684 ___ Reply to this item at: ___ Message sent

[Freeciv-Dev] [bug #24126] Leader names duplicated between nations

2015-12-15 Thread Jacob Nevins
Follow-up Comment #13, bug #24126 (project freeciv): > If we want to legitimise duplicate leader names, we could make > it pick randomly from matching nations instead. => bug #24181 > As for S2_6 and later branches, we should fix the real problem > of not being able to select nation for

[Freeciv-Dev] [patch #6686] Allow /create to specify nation

2015-12-15 Thread Jacob Nevins
URL: Summary: Allow /create to specify nation Project: Freeciv Submitted by: jtn Submitted on: Tue 15 Dec 2015 12:53:36 UTC Category: None Priority: 5 - Normal

[Freeciv-Dev] [patch #6687] Optimize editor by using extra_type_by_cause_iterate() for EC_ROAD, EC_BASE

2015-12-15 Thread Marko Lindqvist
URL: Summary: Optimize editor by using extra_type_by_cause_iterate() for EC_ROAD, EC_BASE Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 03:36:06 PM EET Category:

[Freeciv-Dev] [bug #24181] When nation name is picked from leader names, pick randomly if more than one nation shares a leader name

2015-12-15 Thread Jacob Nevins
Update of bug #24181 (project freeciv): Status: In Progress => Ready For Test Release: => 2.5.1 ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #24126] Leader names duplicated between nations

2015-12-15 Thread Jacob Nevins
Update of bug #24126 (project freeciv): Assigned to:None => jtn ___ Reply to this item at: ___ Message

[Freeciv-Dev] [bug #24178] Meta knowledge: trade route partner city size is known

2015-12-15 Thread Sveinung Kvilhaugsvik
Update of bug #24178 (project freeciv): Status: Ready For Test => Fixed Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #6682] Action not enabled explain add to size limit

2015-12-15 Thread Sveinung Kvilhaugsvik
Update of patch #6682 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #24182] Extra causes and rmcauses defined as single value while they are bitvector

2015-12-15 Thread Marko Lindqvist
URL: Summary: Extra causes and rmcauses defined as single value while they are bitvector Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 04:13:34 PM EET Category: general

[Freeciv-Dev] [bug #24183] compat_load_030000() not producing savegame2.c format

2015-12-15 Thread Marko Lindqvist
URL: Summary: compat_load_03() not producing savegame2.c format Project: Freeciv Submitted by: cazfi Submitted on: Tue 15 Dec 2015 04:50:28 PM EET Category: None Severity:

[Freeciv-Dev] [patch #6674] Player flags to savegame

2015-12-15 Thread Marko Lindqvist
Update of patch #6674 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [patch #6689] Controls help update about base building activities

2015-12-15 Thread Marko Lindqvist
URL: Summary: Controls help update about base building activities Project: Freeciv Submitted by: cazfi Submitted on: Wed 16 Dec 2015 08:50:19 AM EET Category: docs Priority: 5