[Freeciv-Dev] [bug #24960] req_edit::select_req() crash when adding new requirement

2016-08-13 Thread Marko Lindqvist
Update of bug #24960 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24956] Old base "Diplomat_Defense" not recreatable

2016-08-13 Thread Sveinung Kvilhaugsvik
Update of bug #24956 (project freeciv): Status:None => In Progress Assigned to:None => sveinung ___ Follow-up Comment #9: > For this

[Freeciv-Dev] [patch #7596] rscompat: upgrade existing before adding new

2016-08-13 Thread Sveinung Kvilhaugsvik
URL: Summary: rscompat: upgrade existing before adding new Project: Freeciv Submitted by: sveinung Submitted on: Sun 14 Aug 2016 05:28:58 AM UTC Category: freeciv-ruledit

[Freeciv-Dev] [bug #24970] r33382: city popup failed

2016-08-13 Thread Frank
URL: Summary: r33382: city popup failed Project: Freeciv Submitted by: dunnoob Submitted on: Sun 14 Aug 2016 03:27:38 AM UTC Category: client-gtk-2.0 Severity: 3 - Normal

[Freeciv-Dev] [patch #5468] German Empire (1871-1914) nation

2016-08-13 Thread Frank
Follow-up Comment #1, patch #5468 (project freeciv): Cf. http://freeciv.wikia.com/wiki/File:German_empire.svg (attached) (file #28295) ___ Additional Item Attachment: File name: german_empire.svg Size:0 KB

[Freeciv-Dev] [patch #7595] More refined notion of world size for Output_Waste_By_Rel_Distance etc

2016-08-13 Thread Jacob Nevins
Update of patch #7595 (project freeciv): Summary: More refined notion of world size => More refined notion of world size for Output_Waste_By_Rel_Distance etc Depends on: => patch #6884

[Freeciv-Dev] [patch #7595] More refined notion of world size

2016-08-13 Thread Jacob Nevins
URL: Summary: More refined notion of world size Project: Freeciv Submitted by: jtn Submitted on: Sat 13 Aug 2016 11:38:59 PM BST Category: None Priority: 5 - Normal

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Christian Knoke
Follow-up Comment #4, bug #24969 (project freeciv): Yes, you are right. I didn't see the hills either. Christian ___ Reply to this item at: ___ Nachricht

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Jacob Nevins
Update of bug #24969 (project freeciv): Status:None => Invalid Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Marko Lindqvist
Follow-up Comment #3, bug #24969 (project freeciv): Oh, I didn't see the target was on Hills. It's exactly as jtn said - works better than human would. ___ Reply to this item at:

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Marko Lindqvist
Follow-up Comment #2, bug #24969 (project freeciv): That's probably just a weird case of "one turn travel time is one turn travel time" It shouldn't lose movement points (there's no railroad on its route) but knowing the path finding code this seems like more probable explanation than anything

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Jacob Nevins
Follow-up Comment #1, bug #24969 (project freeciv): I think this is working as designed. If the Diplomat takes the path suggested by Goto (via grassland then road), it arrives at the city with 1/3 MP left. If it moves directly onto the city tile (which is Hills), it has no movement left. Goto

[Freeciv-Dev] [bug #24969] Goto confuses ZOC or Terrain after city destroyed

2016-08-13 Thread Christian Knoke
URL: Summary: Goto confuses ZOC or Terrain after city destroyed Project: Freeciv Submitted by: chrisk Submitted on: Sa 13 Aug 2016 22:33:51 CEST Category: None Severity: 3 -

[Freeciv-Dev] [bug #24968] Default options adjustments made believing screen height to be 0

2016-08-13 Thread Marko Lindqvist
URL: Summary: Default options adjustments made believing screen height to be 0 Project: Freeciv Submitted by: cazfi Submitted on: Sat 13 Aug 2016 11:12:28 PM EEST Category: client-gtk-3.0

[Freeciv-Dev] [bug #23988] Make "Arrange Widgets for Small Display" initial default DISABLED on big screens

2016-08-13 Thread Marko Lindqvist
Update of bug #23988 (project freeciv): Summary: Feature request: all units on a tile are shown in the bar on the right side => Make "Arrange Widgets for Small Display" initial default DISABLED on big screens ___ Reply to

[Freeciv-Dev] [patch #7594] Requirement value editing for requirement kinds with numerical value

2016-08-13 Thread Marko Lindqvist
URL: Summary: Requirement value editing for requirement kinds with numerical value Project: Freeciv Submitted by: cazfi Submitted on: Sat 13 Aug 2016 07:54:08 PM EEST Category: freeciv-ruledit

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #10, bug #24935 (project freeciv): Thank you Gtk for giving us a well-tested client :-) Fixed Maybe the SDL client has the same problem (file #28287, file #28288) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [patch #7592] Support editing requirement value, as long as kind is "tech"

2016-08-13 Thread Marko Lindqvist
Update of patch #7592 (project freeciv): Status: Ready For Test => Done Assigned to:None => cazfi Open/Closed:Open => Closed

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Marko Lindqvist
Follow-up Comment #9, bug #24935 (project freeciv): That would be exactly what comment about gtk client implementation of server_scan_error() says about the reason it does not have the server_scan_finish() call at all. ___ Reply to this

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #8, bug #24935 (project freeciv): > Is that still server_scan_finish() call Yes Using gdb to watch meta_scan, I could see the metaserver thread nulling it just before the crash. I think what happens is: - [metaserver thread] server_scan_error() is called - [meta]

[Freeciv-Dev] [bug #24966] Output_Waste_By_Rel_Distance ineffective without Output_Waste_By_Distance

2016-08-13 Thread Jacob Nevins
Update of bug #24966 (project freeciv): Category: general => None Status: In Progress => Ready For Test ___ Follow-up Comment #2: Mostly untested

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-13 Thread Louis Moureaux
Follow-up Comment #7, patch #7491 (project freeciv): Going forward here because the client isn't heavily multithreaded. I let qtg_version_message to bug #24935, and handle the single-threaded part of the chat. The patch is for trunk only, I'll make one for 2.6 once you deem it ready.

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Marko Lindqvist
Follow-up Comment #7, bug #24935 (project freeciv): > Client crashes with "double free or corruption" in fc_client::destroy_server_scans at pages.cpp:903. Is that still server_scan_finish() call, or does the patch change line numbers so it's not? That would indicate that 'meta_scan' is still not

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-13 Thread Louis Moureaux
Follow-up Comment #6, bug #24935 (project freeciv): > Its only visible when metaserver is up but returning errors. Also fixed this one. To test, I modified default_server_host in client config file to some random URL not allowing POST. The error appears in the status bar. It won't appear in chat,

[Freeciv-Dev] [bug #24966] Output_Waste_By_Rel_Distance ineffective without Output_Waste_By_Distance

2016-08-13 Thread Marko Lindqvist
Update of bug #24966 (project freeciv): Category:None => general ___ Follow-up Comment #1: Sorry about that. I should have checked changed context more carefully when rebasing the patch.

[Freeciv-Dev] [bug #24966] Output_Waste_By_Rel_Distance ineffective without Output_Waste_By_Distance

2016-08-13 Thread Jacob Nevins
URL: Summary: Output_Waste_By_Rel_Distance ineffective without Output_Waste_By_Distance Project: Freeciv Submitted by: jtn Submitted on: Sat 13 Aug 2016 02:11:02 PM BST Category: None

[Freeciv-Dev] [patch #5468] German Empire (1871-1914) nation

2016-08-13 Thread Ferdi
Additional Item Attachment, patch #5468 (project freeciv): File name: german_empire-large.pngSize:0 KB File name: german_empire-shield.png Size:0 KB File name: german_empire.png Size:0 KB File name: german_empire-shield-large.png Size:0 KB

[Freeciv-Dev] [bug #24900] msys2/win64 compiler warning about ioctlsocket() parameter type

2016-08-13 Thread Marko Lindqvist
Update of bug #24900 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #1: - Define type based on presence of __LP64__ macro (file #28278, file #28279)

[Freeciv-Dev] [bug #24902] Broken timeval structure in win64

2016-08-13 Thread Marko Lindqvist
Update of bug #24902 (project freeciv): Status: Ready For Test => Fixed Assigned to:None => cazfi Open/Closed:Open => Closed